-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TS migration] Migrate 'AttachmentModal.js' component to TypeScript #33929
[TS migration] Migrate 'AttachmentModal.js' component to TypeScript #33929
Conversation
…s-migration/AttachmentsModal
canEditReceipt: PropTypes.bool, | ||
}; | ||
/** A function as a child to pass modal launching methods to */ | ||
children?: React.FC<ChildrenProps>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you test if this prop works when using the component?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fabioh8010 what do you mean by that?
If that the prop have some values when using component ?
or just if this component work when we pass children to it?
overall both cases I think yes :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant the TS part, e.g. Use this component in a new file and pass the children props, or convert a component that use this one to TS and see if this prop is properly typed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, LGTM!
…s-migration/AttachmentsModal
Reviewer Checklist
Screenshots/VideosAndroid: NativeattachmentModalAndroid.mp4Android: mWeb ChromeattachmentModalAndroidChrome.mp4iOS: NativeattachmentModaliOS.mp4iOS: mWeb SafariattachmentModaliOSSafari.mp4MacOS: Chrome / SafariattachmentModalChrome.mp4MacOS: DesktopattachmentModalDesktop.mp4 |
@c3024 comments resolved 😄 |
I am not able to add a jpeg attachment from composer. It works fine on main. Are you able to add attachment from composer? Screen.Recording.2024-01-23.at.4.10.28.PM.mov |
…s-migration/AttachmentsModal
…s-migration/AttachmentsModal
@c3024 all resolved, please recheck 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We did not find an internal engineer to review this PR, trying to assign a random engineer to #25130 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, one comment, if that is addressed then I think we're good to merge.
…s-migration/AttachmentsModal
@blimpich its fixed, thanks ! |
…s-migration/AttachmentsModal
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Cherry-picked to staging by https://github.com/francoisl in version: 1.4.33-5 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to staging by https://github.com/blimpich in version: 1.4.34-0 🚀
|
🚀 Deployed to staging by https://github.com/blimpich in version: 1.4.34-0 🚀
|
if (!report) { | ||
return undefined; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This removal caused regression (deploy blocker)
@kubabutkiewicz can you please check this urgently?
🚀 Deployed to production by https://github.com/francoisl in version: 1.4.34-1 🚀
|
Details
Fixed Issues
$ #25130
Tests
Start a chat
Click + icon
Add Attachment
Attachment should be sent
Open RHN
Go to your profile
Click on Avatar
Select new photo
Avatar should be changed
Offline tests
QA Steps
Start a chat
Click + icon
Add Attachment
Attachment should be sent
Open RHN
Go to your profile
Click on Avatar
Select new photo
Avatar should be changed
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.mp4
Android: mWeb Chrome
mchrome.mp4
iOS: Native
ios.mp4
iOS: mWeb Safari
msafari.mp4
MacOS: Chrome / Safari
web.mp4
MacOS: Desktop
desktop.mp4