Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The paid message flickers with negative amount in case of expense report #25473

Closed
1 of 6 tasks
mountiny opened this issue Aug 18, 2023 · 12 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Reviewing Has a PR in review Weekly KSv2

Comments

@mountiny
Copy link
Contributor

mountiny commented Aug 18, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Coming from here

Action Performed:

Break down in numbered steps

  1. User B requests money in a workspace chat.
  2. As User A, open the IOU preview.
  3. As User A, select Pay elsewhere.
  4. Note that the amount in the paid message briefly shows negative value for a while

Expected Result:

Describe what you think should've happened

The amount should be same as the expense report total

Actual Result:

Describe what actually happened

The amount flickers with negative value

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/43995119/dd8fb478-a800-426b-bf12-7ccf85adc523
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

@mountiny mountiny added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Aug 18, 2023
@mountiny mountiny self-assigned this Aug 18, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 18, 2023

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Aug 18, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@mountiny mountiny added the Reviewing Has a PR in review label Aug 18, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Aug 18, 2023
@mountiny
Copy link
Contributor Author

PR is up

@jliexpensify
Copy link
Contributor

Hi @mountiny are we paying Rajat here? He's not on the linked PR. Cheers!

@mountiny
Copy link
Contributor Author

He is on this one #25474

$1000 to @parasharrajat is all to be paid here.

@jliexpensify
Copy link
Contributor

jliexpensify commented Aug 26, 2023

Payments:

@mountiny
Copy link
Contributor Author

mountiny commented Aug 28, 2023

No, this was internal PR that does not have urgency bonus so $1000 flat

@jliexpensify
Copy link
Contributor

Cheers, updated above for @JmillsExpensify to pay. Feel free to close this out Vit, nothing for me to do.

@parasharrajat
Copy link
Member

Payment requested as per #25473 (comment)

@JmillsExpensify
Copy link

$1,000 payment for @parasharrajat approved based on BZ summary.

@jliexpensify
Copy link
Contributor

@mountiny we can close this one right? Payment is completed!

@mountiny
Copy link
Contributor Author

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants