[HOLD for payment 2023-09-11] [$1000] Request money - Address field shows error when saved again and it becomes empty after refresh

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging.new.expensify,com
2. Go to + > Request money > Distance
3. Click Start
4. Enter an address and save
5. Click on Start again
6. Click Save
7. Refresh the page

Expected Result:

In Step 6, since the address is populated, user is able to save the selection
In Step 7. the address field remains populated

Actual Result:

In Step 6, user is unable to save the selection and error 'Please select a suggested address' shows up
In Step 7. the address field is empty

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.56-2

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6173184_20230822_171058.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012df4e765e5dc30c6
• Upwork Job ID: 1694412987696316416
• Last Price Increase: 2023-08-23
• Automatic offers:
• Pujan92 | Contributor | 26396416

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @stitesExpensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[pradeepmdk]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Request money - Address field shows error when saved again and it becomes empty after refresh(#25686 (comment))

What is the root cause of that problem?

for error message we are showing when has the value

if (!network.isOffline && waypointValue !== '') {

for refresh AddressSearch component mounted initially before setting the waypointAddress

What changes do you think we should make in order to solve the problem?

App/src/pages/iou/WaypointEditor.js

Line 87 in c053381

if (!network.isOffline && waypointValue !== '') {

to
if (!network.isOffline && waypointValue === '') {

for a refreshing time before update the defaultValue AddressSearch component is mounted so that the value is not updated we can use the state for update the value and instead of defaultValue we can use value
we need to use onValueChange as well when user typing the value update to state

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Request money - Address field shows error when saved again and it becomes empty after refresh

What is the root cause of that problem?

We're showing error when network is available and waypointValue is not empty which caused this issue.

App/src/pages/iou/WaypointEditor.js

Lines 87 to 89 in 79ea923

	if (!network.isOffline && waypointValue !== '') {
	errors[`waypoint${waypointIndex}`] = 'distance.errors.selectSuggestedAddress';
	}

I also agree about RCA of second issue with about proposal.

What changes do you think we should make in order to solve the problem?

About the first issue, we should update the condition here to:

 if (!network.isOffline && waypointValue === '') { 
     errors[`waypoint${waypointIndex}`] = 'distance.errors.selectSuggestedAddress'; 
 } 

About the second issue, when the InputValue is empty when reloading, we should add the props shouldSaveDraft={true} to our AddressSearch component.

What alternative solutions did you explore? (Optional)

N/A

[pradeepmdk]

@hungvu193 I tried shouldSaveDraft but I think it will create a regression

Screen.Recording.2023-08-23.at.9.48.41.AM.mov

[thienlnam]

I authored this regression so I'll take it

[thienlnam]

Oh, looking at the video this doesn't look like a blocker or a regression but I'll fix it regardless

[allroundexperts]

@thienlnam Since this is not a regression / blocker, let's just allow the contributors to fix it instead? I already see a couple of strong proposals.

[thienlnam]

The current proposals won't fix the issue in a way that doesn't add another regression but yeah we can make this external

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012df4e765e5dc30c6

[melvin-bot]

Triggered auto assignment to @zanyrenney (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[napster125]

@allroundexperts, @thienlnam
Could you kindly review my proposal? I believe we can resolve this issue by utilizing the value and onValueChange attributes. However, in my opinion, my proposed solution offers greater consistency.
Your feedback on this matter would be greatly appreciated.

[thienlnam]

Assigning @Pujan92 - they addressed the requirements first

[melvin-bot]

📣 @allroundexperts Please request via NewDot manual requests for the Reviewer role ($1000)

[melvin-bot]

📣 @Pujan92 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Pujan92]

@allroundexperts PR is ready for review!

[melvin-bot]

🎯 ⚡️ Woah @allroundexperts / @Pujan92, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @Pujan92 got assigned: 2023-08-29 18:15:32 Z
• when the PR got merged: 2023-08-31 23:40:09 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.62-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: Request money - Address field shows error when saved again and it becomes empty after refresh #26371

If no regressions arise, payment will be issued on 2023-09-11. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @Pujan92 requires payment offer (Contributor)
• @allroundexperts does not require payment (Eligible for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[zanyrenney]

Payment summary

External issue reporter - N/A (reported by Applause internal team)
Contributor that fixed the issue (paid @Pujan92 $1500 for work + urgency bonus)
Contributor+ that helped on the issue and/or PR (paid with manual requests) @allroundexperts please request payment outside this! Thanks!

[zanyrenney]

Closing now upwork payment is complete!