[$500] [HOLD for payment 2023-09-07] Update styles for money request header user cannot edit

[mountiny]

Problem

When user cannot edit the money request, we are using the disabled prop which changes the cursor and greys out the fields

Solution

Update the styles so in this case, the header looks exactly the same as for the user who can edit except:

• no chevron - already working
• when user hovers over the rows, they are not highlighted

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011073110a17edacf6
• Upwork Job ID: 1701248547715727360
• Last Price Increase: 2023-09-11
• Automatic offers:
• situchan | Contributor | 26611863

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[koko57]

Hi! I'm Agata from Callstack and I'm ready to help! 🙌🏻

[mountiny]

@koko57 This should be a simple change so no need for a proposal from your side

[situchan]

When user cannot edit the money request

@mountiny We should not use disabled prop in all cases?

• payee side: paid already
• payer side

[mountiny]

correct

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.60-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: change styles for the requestee #25952

If no regressions arise, payment will be issued on 2023-09-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue — @situchan was paid $1000
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @koko57 does not require payment (Contractor)
• @mountiny does not require payment for reporting

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mountiny] The PR that introduced the bug has been identified. Link to the PR:
• [@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@koko57] Determine if we should create a regression test for this bug.
• [@koko57] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@CortneyOfstad] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[CortneyOfstad]

@mountiny Just following up for the payment here — was there a PR and if so, was it merged within 3 days of @koko57 being assigned?

Also for Callstack, is payment required? Or is that handled somewhere else? TIA!

[mountiny]

I believe the only payment here will be $1000 to @situchan for internal review

[CortneyOfstad]

Thanks @mountiny! Getting that tackled now!

[CortneyOfstad]

So it looks like a "job" was never created in Upwork, so going to apply the external label to get the job created, and I'll extend an offer/contract to @situchan ASAP 👍

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011073110a17edacf6

[melvin-bot]

Current assignee @CortneyOfstad is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @burczu (External)

[CortneyOfstad]

@burczu sorry for the false alarm! Issue is already assigned to @situchan so getting this cleared up!

[melvin-bot]

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[CortneyOfstad]

@situchan the payment will be $1000, but Upwork creates the issue under $500. No worries, you'll be paid under the old format (based on when this issue was created) 👍

Please let me know once you accept, and I can get that paid right away. TIA!

[CortneyOfstad]

@situchan — payment has been completed in Upwork! You should be all set!

[CortneyOfstad]

@mountiny Any updates on the checklist above?

[mountiny]

@CortneyOfstad This was a new feature being built and design decision so no need to highlight some bugs as in the checklist here I believe

[CortneyOfstad]

Sounds good! Closing!