[HOLD for payment 2023-09-27] [$500] Money in wallet badge is not center vertically

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. go to settings
2. check the amount in badge

Expected Result:

money should be in center vertically

Actual Result:

money in badge is not center vertically

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.59-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-08-21.at.11.24.04.AM.mov

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692597419368009

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ea8fed02b430b214
• Upwork Job ID: 1696985690595770368
• Last Price Increase: 2023-09-06
• Automatic offers:
• ZhenjaHorbach | Contributor | 26600759
• gadhiyamanan | Reporter | 26600761

[melvin-bot]

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[GItGudRatio]

unable to repro, looks vertically aligned to me

[b4s36t4]

It is vertically aligned. We need to conside $ symbol too.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ea8fed02b430b214

[melvin-bot]

Current assignee @maddylewis is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik (External)

[ZhenjaHorbach]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Fix the position of the text so that it is in the center of the badge.

What is the root cause of that problem?

The problem is in lineHeight.

What changes do you think we should make in order to solve the problem?

We need to remove lineHeight for text in order for the badge to correctly center the text.
But it only reproduce on Safari for me.
Chrome renders correctly lineHeight anyway.

For example, how Safari reacts to remove lineHeight

What alternative solutions did you explore? (Optional)

[melvin-bot]

📣 @ZhenjaHorbach! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[ZhenjaHorbach]

Contributor details
Your Expensify account email: horbachyauhenipetrovich@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01e2ef043508da9f2c

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[anyongjitiger]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The problem is that Money in wallet badge is not center, bottom is bigger than top.

What is the root cause of that problem?

The root cause of the problem is :
The line-height of the badgeText is smaller (16px) than the height of the badge (20px).

What changes do you think we should make in order to solve the problem?

We can set the line-height of the badgeText and the height of the badge to be the same, which will center it.

What alternative solutions did you explore? (Optional)

None

[robertKozik]

Hi all! I'll address each proposal in separate points, as I have questions to both of them:

1. @ZhenjaHorbach — I'm worried about the regression on other badge instances - as we cannot be sure about the behaviour when we are not setting anything for lineHeight. Did you consider setting equal values for the lineHeight and fontSize?
2. @anyongjitiger — Did you check your approach on the safari web? I'm getting a vibe that it's still not centered:

[ZhenjaHorbach]

Hi all! I'll address each proposal in separate points, as I have questions to both of them:

1. @ZhenjaHorbach — I'm worried about the regression on other badge instances - as we cannot be sure about the behaviour when we are not setting anything for lineHeight. Did you consider setting equal values for the lineHeight and fontSize?
2. @anyongjitiger — Did you check your approach on the safari web? I'm getting a vibe that it's still not centered:

Hello )
Yes, I checked today morning, in fact this is the only correct acceptable value (fontSize value) )
And it turns out that in this case the available values are:
-styles without lineHeight;
-lineHeight which is equal to fontSize.

In other cases, bugs appear in Safari.

And I noticed that there are no variables in the styles for such small values for lineHeight(11).
Therefore, it seemed to me that styles without lineHeight would be a more correct answer.

But maybe you're right, styles without lineHeight can lead to potential unpredictability in the future )

[anyongjitiger]

Hi all! I'll address each proposal in separate points, as I have questions to both of them:

1. @ZhenjaHorbach — I'm worried about the regression on other badge instances - as we cannot be sure about the behaviour when we are not setting anything for lineHeight. Did you consider setting equal values for the lineHeight and fontSize?
2. @anyongjitiger — Did you check your approach on the safari web? I'm getting a vibe that it's still not centered:

I just tested it on Safari and it does have display issues. It seems to be a font-related problem. When I disabled the ExpensifyNeue-Regular font in devtools, it displayed correctly. One possible solution could be adjusting the fonts, as mentioned in this answer:
https://stackoverflow.com/a/15860322

[melvin-bot]

@maddylewis, @robertKozik Eep! 4 days overdue now. Issues have feelings too...

[maddylewis]

@robertKozik - bump on proposal review - thx!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[robertKozik]

Hmmm thanks for your findings @anyongjitiger, if it's indeed the problem related with the font I think it's not a bug then. I'm heading OOO for today, but tomorrow morning I'll double check the alignment of the $ sign, I think it can be vertically aligned

[robertKozik]

I've rechecked it, and it appears to be linked to the font ExpenifyNeue-regular, but that's not the sole factor. Even with the same font, there's a discrepancy between Safari and Chrome. Considering this, I'm inclined to agree with @ZhenjaHorbach's proposal for consistency across both browsers.

Selected Proposal: proposal
Contributor: @ZhenjaHorbach

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @thienlnam, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.71-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix styles for wallet money badge which is not center vertically #27137

If no regressions arise, payment will be issued on 2023-09-27. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @robertKozik does not require payment (Contractor)
• @ZhenjaHorbach requires payment offer (Contributor)
• @gadhiyamanan requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@robertKozik] The PR that introduced the bug has been identified. Link to the PR:
• [@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@robertKozik] Determine if we should create a regression test for this bug.
• [@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@maddylewis] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[maddylewis]

@robertKozik - are you able to expand on Jack's comment here - #26308 (comment)

[thienlnam]

cc @kavimuru Do you have more info about the reproducing this bug?

[robertKozik]

Hi! It seems that the remaining discrepancy is likely due to the font, as mentioned here. With the PR, we've addressed how Safari handles vertical centering. Previously, Safari behaved differently than Chrome, but now they're aligned.

before safari:

after safari:

[maddylewis]

Payments

• Reporting bonus: @gadhiyamanan ($250 via Upwork / $250 bc the issue was created 120 mins before announcement 🙃)
• Contributor: @ZhenjaHorbach ($500 via Upwork)
• C+: @robertKozik (no payment required)

[maddylewis]

@robertKozik - can you review this checklist when you have a chance? thanks! #26308 (comment)

[gadhiyamanan]

@maddylewis this is eligible for $250 because it was reported before 30 aug

[maddylewis]

the issue was created on Aug 30, so I'm going with that timestamp:

[gadhiyamanan]

Issue is created before the announcement https://expensify.slack.com/archives/C01GTK53T8Q/p1693424078129649

[maddylewis]

🙄 🙄

[maddylewis]

@robertKozik - bump on this one ty! #26308 (comment)

[maddylewis]

@robertKozik - bump #26308 (comment)

[robertKozik]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@robertKozik] The PR that introduced the bug has been identified. Link to the PR: that was inconsistency between browsers, no particular PR introduced it
• [@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• [@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@robertKozik] Determine if we should create a regression test for this bug. We don't need regression test for visual bugs
• [@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

tldr; I think we don't need regression test for this one as it's purely visual bug which don't interfere with any user flow

[melvin-bot]

@thienlnam, @maddylewis, @robertKozik, @ZhenjaHorbach Whoops! This issue is 2 days overdue. Let's get this updated quick!

[maddylewis]

everyone is paid and a regression test isn't required since this is purely visual. closing!