-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$500] [Distance] - Distance editor menu in IOU report shows Merchant instead of Distance #26559
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Triggered auto assignment to @jasperhuangg ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.The text of the header and of the input are "Merchant" instead of Distance What is the root cause of that problem?In MoneyRequestView here: App/src/components/ReportActionItem/MoneyRequestView.js Lines 154 to 164 in 9701fbe
We have only one MenuItemWithTopDescription for both Merchant and Distance and we navigate to the same page for both. The page we navigate to is https://github.com/Expensify/App/blob/main/src/pages/EditRequestMerchantPage.js In this page we display Merchant and never Distance What changes do you think we should make in order to solve the problem?I think we should do a page specific for Distance because currently when we submit we actually save the distance in the merchant field here: App/src/pages/EditRequestPage.js Lines 159 to 166 in 9701fbe
So here are the changes I suggest: Add CONST.EDIT_REQUEST_FIELD.DISTANCE in the const file In EditRequestPage add a condition to test if the field is distance and navigate to the new page EditRequestDistancePage that will look like EditRequestMerchantPage but with the right text What alternative solutions did you explore? (Optional)The alternative is to test if this is a distance request in EditRequestMerchantPage to display the right text, and we also would need to test that in the submit method to save in the right field |
This will be fixed in Edit distance request PR |
Job added to Upwork: https://www.upwork.com/jobs/~01c148f42c5bc47bd3 |
Triggered auto assignment to @anmurali ( |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr ( |
Triggered auto assignment to @zanyrenney ( |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 ( |
I'm so bad at assigning labels 😭 |
Hey, as @situchan mentioned is in't going taken care at some other PR? is this up for proposals? |
@b4s36t4 I need to confirm with that PR author but probably will be fixed in that PR I gonna keep this issue open but will removed help wanted label |
Ok understood. |
Hey @hayata-suenaga I'm a little lost on this one with the labels. I think Anu is assigned as the BZ manager:
But then it looks like you unassigned her and then the external label again which has also now assigned me...
Can you confirm what's happening here please? Thanks! |
😓 this is probably the fault of my late-night brain... I constantly click wrong buttons 🔘 Anyway, this PR is going to fix the issue. I gonna close this issue for now |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Issue found when executing PR #25707
Action Performed:
Expected Result:
The right hand menu shows Distance as the header
Actual Result:
The right hand menu shows Merchant as the header. The title of the edit field also shows Merchant
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.62-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug6186220_20230902_184437.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: