Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PAID] [$1000] Android-Compose- Header markdown-multiline with URL, vary in format while editing & sending #26942

Closed
6 tasks done
izarutskaya opened this issue Sep 7, 2023 · 94 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review

Comments

@izarutskaya
Copy link

izarutskaya commented Sep 7, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open app and click on a chat
  2. Type into the chat:
    # [google1
    google2
    google3](https://www.google.com)
  1. Try to edit the typed comment. Notice that it has a different markdown structure:
    # [google1](https://www.google.com)
    google2
    google3

Expected Result:

User sending an URL, with 3 rows of multiline message in [ ],all are shown as URL.

Similarly,User sending an URL including header markdown, with 3 rows of multiline message in [ ], all 3 rows multiline message must be shown as URL.

The Header markdown, multiline message with URL, must not display in different format while editing. All three rows of multiline message should display inside [ ], as entered by user

Actual Result:

User sending an URL, with 3 rows of multiline message in [ ],all are shown as URL.

User sending an URL including header markdown, with 3 rows of multiline message in [ ], only first row message is shown as url and remaining two rows message shown as text.

The Header markdown, multiline message with URL, displays in different format while editing. First row text entered only shown inside [ ], and for remaining 2 rows message format changed and shown outside [ ].

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.65-0

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6191062_line_order.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation: @

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01cf462eb26aa8fbe1
  • Upwork Job ID: 1701242002102861824
  • Last Price Increase: 2023-09-28
Issue OwnerCurrent Issue Owner: @robertKozik
Issue OwnerCurrent Issue Owner: @robertKozik
@izarutskaya izarutskaya added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 7, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 7, 2023

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Sep 7, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot
Copy link

melvin-bot bot commented Sep 11, 2023

@strepanier03 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Sep 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 11, 2023

@strepanier03 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@strepanier03
Copy link
Contributor

Working on this now, I've been ill.

@melvin-bot melvin-bot bot removed the Overdue label Sep 11, 2023
@strepanier03
Copy link
Contributor

Repro'd following steps.

image

@strepanier03 strepanier03 added the External Added to denote the issue can be worked on by a contributor label Sep 11, 2023
@melvin-bot melvin-bot bot changed the title Android-Compose- Header markdown-multiline with URL, vary in format while editing & sending [$500] Android-Compose- Header markdown-multiline with URL, vary in format while editing & sending Sep 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 11, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01cf462eb26aa8fbe1

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 11, 2023

Current assignee @strepanier03 is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented Sep 11, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik (External)

@strepanier03
Copy link
Contributor

Waiting for proposals Melvin, we're good for now.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Sep 14, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 18, 2023

@strepanier03, @robertKozik Whoops! This issue is 2 days overdue. Let's get this updated quick!

@robertKozik
Copy link
Contributor

Still waiting for proposals

@melvin-bot melvin-bot bot removed the Overdue label Sep 18, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 18, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@strepanier03
Copy link
Contributor

I don't think we should increase the bounty at this time, there are simply a lot of open issues to be worked on right now and this isn't a critical bug that should take priority.

@melvin-bot
Copy link

melvin-bot bot commented Sep 21, 2023

@strepanier03 @robertKozik this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Sep 21, 2023
@robertKozik
Copy link
Contributor

waiting for proposals

@r3770
Copy link
Contributor

r3770 commented Nov 16, 2023

@cead22 @robertKozik
Expensify/expensify-common#605 is ready to fix extra issue

@r3770
Copy link
Contributor

r3770 commented Nov 17, 2023

@cead22 @robertKozik
The App PR #31477 is ready, but git action tests are failed, not sure why it is
Could you check it ?

r3770 added a commit to r3770/App that referenced this issue Nov 18, 2023
r3770 added a commit to r3770/App that referenced this issue Nov 20, 2023
@r3770
Copy link
Contributor

r3770 commented Nov 22, 2023

@cead22 @strepanier03
When can i get payment from upwork ?
It looks like there is no other regression issue

@r3770
Copy link
Contributor

r3770 commented Nov 27, 2023

@cead22 @strepanier03
Friendly bump

@r3770
Copy link
Contributor

r3770 commented Nov 29, 2023

@cead22 @strepanier03
Kind Bump again

@r3770
Copy link
Contributor

r3770 commented Nov 30, 2023

@cead22 @strepanier03 @robertKozik
It's been a week since the fixed version of regression issue deployed to staging.
Could you check how we can move forward ?

@cead22
Copy link
Contributor

cead22 commented Nov 30, 2023

I DM'ed @strepanier03. @robertKozik can you fill out the items in this checklist?

@strepanier03 strepanier03 added Daily KSv2 and removed Weekly KSv2 labels Nov 30, 2023
@strepanier03
Copy link
Contributor

@r3770 - Please apply for the job here, I've attempted to hire you directly to it but because your Upwork profile is private I cannot.

@r3770
Copy link
Contributor

r3770 commented Nov 30, 2023

@strepanier03
I've applied, could you please check ?

@robertKozik
Copy link
Contributor

  • [@robertKozik] The PR that introduced the bug has been identified. Link to the PR: That was case not handled before
  • [@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
  • [@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
  • [@robertKozik] Determine if we should create a regression test for this bug. N/A there are implemented unit tests which covers this case
  • [@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

@strepanier03
Copy link
Contributor

Thank you @r3770 I'm working on payment now.

Thank you @robertKozik as well!

Update in a moment.

@strepanier03
Copy link
Contributor

@r3770 - There's no applications on the job :(

@strepanier03
Copy link
Contributor

Hmm, actually I think something is up with Upwork.

When I view your profile I can see that you've applied, although there's no way to accept the application from within your profile.

image

However when I view the actual job, your application is not listed.

I'll see if I can figure this out and message Upwork's support if I have to.

@r3770
Copy link
Contributor

r3770 commented Nov 30, 2023

@strepanier03 Here is what I applied

image

@strepanier03
Copy link
Contributor

@r3770 - I found a workaround but had to send you an offer for the job. Please accept that offer then let me know here, and I'll circle back to this payment before I leave for the day.

@r3770
Copy link
Contributor

r3770 commented Nov 30, 2023

@strepanier03
Offer accepted, Thanks

@strepanier03
Copy link
Contributor

I see you did it right away so I just paid it as well!

@strepanier03
Copy link
Contributor

Thank you again for your quick communication @r3770, I'm sorry this went unhandled for this long.

@strepanier03
Copy link
Contributor

Since the checklist is done and no regression test is suggested I'm going to close this out. Thanks everyone and thank you for the 1:1 message @cead22 🙌

@strepanier03 strepanier03 changed the title [HOLD for payment 2023-11-17] [$1000] Android-Compose- Header markdown-multiline with URL, vary in format while editing & sending [PAID] [$1000] Android-Compose- Header markdown-multiline with URL, vary in format while editing & sending Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

9 participants