[HOLD for payment 2023-10-25] [$500] IOU - In Header Workspace, members are not shown and IOU delivered to them

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Login secondary device

1. Go to https://staging.new.expensify.com/
2. Tap profile icon
3. Tap workspaces
4. Tap any workspace
5. Invite a member
6. Navigate to LHN
7. Open Workspace chat
8. Tap request money and create an IOU
9. Tap header -members to note number of members and details
10. Open invited member account - primary device
11. Open Workspace chat

Expected Result:

In header of Workspace chat, all members should be shown. And IOU created must to delivered to its members

Actual Result:

In header of Workspace chat, member are not shown. And IOU created in Workspace chat, not delivered to its members

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.66-3

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6193599_iou.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b02d428c60467905
• Upwork Job ID: 1704060529674792960
• Last Price Increase: 2023-10-03

Issue Owner

Current Issue Owner: @dylanexpensify

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dylanexpensify]

reviewing today

[melvin-bot]

@dylanexpensify Huh... This is 4 days overdue. Who can take care of this?

[dylanexpensify]

Posted in slack internal to have someone test since you need two android phones!

[dylanexpensify]

@peterdbarkerUK confirmed!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b02d428c60467905

[melvin-bot]

Current assignee @dylanexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @burczu (External)

[zukilover]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In Header Workspace, members are not shown and IOU delivered to them

What is the root cause of that problem?

It does not show the complete members because the list of participants is only derived from the report instance itself, and not from the workspace data:

App/src/pages/ReportParticipantsPage.js

Lines 96 to 99 in 56271f0

	const participants = _.map(getAllParticipants(props.report, props.personalDetails, props.translate), (participant) => ({
	...participant,
	isDisabled: ReportUtils.isOptimisticPersonalDetail(participant.accountID),
	}));

What changes do you think we should make in order to solve the problem?

If this is a report from a workspace, we should populate the members from the correct policy members, e.g.:

• connect with the policy members information:

policyMembers: {
            key: (props) => `${ONYXKEYS.COLLECTION.POLICY_MEMBERS}${props.report.policyID}`,
        },

• populate workspace members:

const getMemberOptions = () => {
        let result = [];
        _.each(props.policyMembers, (_, accountID) => {
            const details = lodashGet(props.personalDetails, accountID, {displayName: props.personalDetails.displayName || props.translate('common.hidden'), avatar: ''});

            result.push({
                keyForList: accountID,
                accountID: Number(accountID),
                text: details.displayName,
                displayName: details.displayName,
                alternateText: details.login,
                icons: [
                    {
                        id: accountID,
                        source: UserUtils.getAvatar(details.avatar, accountID),
                        name: details.login,
                        type: CONST.ICON_TYPE_AVATAR,
                    },
                ],
            });
        });

        result = _.sortBy(uniqBy(result, 'alternateText'), (value) => (value.text || '').toLowerCase());

        return result;
    };

• and show the appropriate list of participants:

const data = props.report.policyID && !ReportUtils.isAdminRoom(props.report)
        ? getMemberOptions() 
        : getAllParticipants(props.report, props.personalDetails, props.translate);

const participants = _.map(data, (participant) => ({
            ...participant,
            isDisabled: ReportUtils.isOptimisticPersonalDetail(participant.accountID),
        }))

As pointed by @burczu, participants count is also off on report detail page. This is because ReportDetailsPage is populating the participants from participantAccountIDs, regardless it's a workspace or not.

App/src/pages/ReportDetailsPage.js

Lines 76 to 77 in 25f7ac1

	const participants = useMemo(() => ReportUtils.getParticipantsIDs(props.report), [props.report]);

I propose that we use the same approach, i.e. populating participants from policy members if this is a workspace:

Get workspace members if it's not available in the store yet:

const getWorkspaceMembers = useCallback(() => {
        Policy.openWorkspaceMembersPage(props.report.policyID, workspaceMembers);
    }, [props.report.policyID, workspaceMembers]);

    useEffect(() => {
        if (props.report.policyID && !ReportUtils.isAdminRoom(props.report)) {
            getWorkspaceMembers()
        }
    }, [])

Populate workspace members:

const workspaceMembers = useMemo(() => 
        _.keys(PolicyUtils.getMemberAccountIDsForWorkspace(props.policyMembers, props.personalDetails)), 
        [props.policyMembers, props.personalDetails]
    )

Update participants logic:

const participants = useMemo(() => {
        return props.report.policyID && !ReportUtils.isAdminRoom(props.report)
            ?  workspaceMembers
            : lodashGet(props.report, 'participantAccountIDs', [])
    }, [props.report, workspaceMembers]);

What alternative solutions did you explore? (Optional)

N/A

[dylanexpensify]

@burczu mind giving the above proposal a review soon? 🙇‍♂️

[melvin-bot]

@burczu @dylanexpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[burczu]

@dylanexpensify Sorry for the delay - I was dealing with an issue building the App for Android, but it's sorted now and I'll review this one today.

[burczu]

For now I can't reproduce this issue due to the problem with workspace invitations described here: https://expensify.slack.com/archives/C049HHMV9SM/p1695627542846449 - I need to wait until it's resolved.

There is also an issue created already: #28130

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[jasperhuangg]

@dylanexpensify
I think we can pay everyone out as normal. There was no way they could have known that we didn't need to solve this.

@burczu @zukilover moving forward, let's be sure we have full context on a feature before we decide to fix it. Here, we could have used the response from the back-end to see that workspace rooms weren't being shared with everyone by default on creation anymore.

[francoisl]

Hi everyone, the QA team reported that the issue is still happening on Android and iOS - can someone double-check if there's still something to fix here please?

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.86-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• webfix/27090 In Header Workspace, members are not shown. #29420

If no regressions arise, payment will be issued on 2023-10-25. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @zukilover requires payment
• @burczu does not require payment (Contractor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@burczu] The PR that introduced the bug has been identified. Link to the PR:
• [@burczu] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@burczu] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@burczu] Determine if we should create a regression test for this bug.
• [@burczu] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[dylanexpensify]

payment tomorrow!

[dylanexpensify]

Payment Summary:

• Contributor: @zukilover $500

Please apply!

[dylanexpensify]

Before payment, @zukilover @burczu can you confirm if this is true?

[zukilover]

Hi @dylanexpensify, the PR has been reverted in 351c98a, so the 'Not Fixed' comment should be irrelevant now.

Also, the job in Upwork is no longer available, please advise on how to proceed with the application.

[mallenexpensify]

@dylanexpensify can you address @zukilover 's comment above plz, thx

[melvin-bot]

@zukilover, @deetergp, @burczu, @dylanexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[dylanexpensify]

Sorry team, was OOO sick last week! @zukilover can you confirm then if the PR caused a regression? Seems so given we had to revert?

[zukilover]

@dylanexpensify The reversal was not due to a regression but a decision to not include the PR at all as it was not actually required. This is a per: #27090 (comment)

[dylanexpensify]

Got it - @zukilover what's your name for Upwork invite

[zukilover]

Here is my Upwork profile.

Thanks @dylanexpensify

[dylanexpensify]

invited!

[dylanexpensify]

Done