[HOLD for payment 2023-09-27] mWeb/safari- Transition is not smooth when search page opened

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #24316

Action Performed:

1. Launch the Url and login
2. Open the search panel

Expected Result:

The transition is smooth

Actual Result:

Transition is not smooth when search page opened

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.70-2

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6200598_Search_.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @amyevans (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[amyevans]

Hmm things seem pretty snappy on dev on a sim:

Screen.Recording.2023-09-14.at.12.53.36.PM.mov

I'll try to reproduce on staging

[amyevans]

Looks good to me there too:

RPReplay_Final1694714330.MP4

@lanitochka17 is this reproducible for you in any account or only a specific one?

[lanitochka17]

@amyevans This happens only in expensifail account

[amyevans]

Okay thanks! I can reproduce with Expensifail

[amyevans]

Looks like we refactored the Search Page in #23076 which just deployed to staging so that seems like a possible cause (original GH for it: #16251). Mind taking a closer look @Piotrfj?

[francoisl]

Here's a side-by-side comparison between the current main and with #23076 reverted. It looks a little smoother indeed after reverting.

On `main`	With PR 23076 reverted
main.mov	revert-23076.mov

[amyevans]

Thanks! We're going to just revert: #27476

[amyevans]

Revert PR is being cherry picked, so closing this out.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.71-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Revert "Convert SearchPage to functional component" #27476

If no regressions arise, payment will be issued on 2023-09-27. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty