[HOLD for payment 2023-10-05] [$500] Dev: Web - Trailing Newlines are not trimmed on the My Note page.

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the App and Create a workspace. If not created
2. Go to #admins
3. Click on header > Private notes > My note
4. Press on Notes
5. Add 3-4 newlines before the actual message; Press Save

Expected Result:

Trailing Newlines should be trimmed on the My Note page.

Actual Result:

Trailing Newlines are not trimmed on the My Note page, and it shows the empty lines on it.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: Dev 1.3.70.5
Reproducible in staging?: n
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

empty-newlines.mov

Expensify/Expensify Issue URL:
Issue reported by: @jayeshmangwani
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694787278356809

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a1c9388800197ffc
• Upwork Job ID: 1703123699888500736
• Last Price Increase: 2023-09-16
• Automatic offers:
• jayeshmangwani | Contributor | 26743629
• jayeshmangwani | Reporter | 26743630

[ahmedGaber93]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Dev - Trailing Newlines are not trimmed on the My Note page.

What is the root cause of that problem?

we trim the privateNote only on amount in useState defaul value

App/src/pages/PrivateNotes/PrivateNotesEditPage.js

Line 63 in 76c1559

const [privateNote, setPrivateNote] = useState(parser.htmlToMarkdown(lodashGet(report, ['privateNotes', route.params.accountID, 'note'], '')).trim());

and not trim it when save

App/src/pages/PrivateNotes/PrivateNotesEditPage.js

Lines 69 to 76 in 76c1559

	const savePrivateNote = () => {
	const editedNote = parser.replace(privateNote);
	Report.updatePrivateNotes(report.reportID, route.params.accountID, editedNote);
	Keyboard.dismiss();
	// Take user back to the PrivateNotesView page
	Navigation.goBack();
	};

What changes do you think we should make in order to solve the problem?

we need to trim the privateNote before saving

const editedNote = parser.replace(privateNote.trim()); 

App/src/pages/PrivateNotes/PrivateNotesEditPage.js

Lines 69 to 76 in 76c1559

	const savePrivateNote = () => {
	const editedNote = parser.replace(privateNote);
	Report.updatePrivateNotes(report.reportID, route.params.accountID, editedNote);
	Keyboard.dismiss();
	// Take user back to the PrivateNotesView page
	Navigation.goBack();
	};

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a1c9388800197ffc

[melvin-bot]

Triggered auto assignment to @garrettmknight (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @burczu (External)

[kbecciv]

Proposal by: @jayeshmangwani
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694787278356809

Proposal

Please re-state the problem that we are trying to solve in this issue.

Trailing Newlines are not trimmed on the My Note page.

What is the root cause of that problem?

We are not trimming Private Note Value on Private Notes page, before passing the privateNote value to the API

What changes do you think we should make in order to solve the problem?

We should trim the privateNote Value here before passing to the API

App/src/pages/PrivateNotes/PrivateNotesEditPage.js

Lines 69 to 70 in 76c1559

	const savePrivateNote = () => {
	const editedNote = parser.replace(privateNote);

    const editedNote = parser.replace(privateNote.trim());

What alternative solutions did you explore? (Optional)

none

[jayeshmangwani]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Trailing Newlines are not trimmed on the My Note page.

What is the root cause of that problem?

We are not trimming Private Note Value on Private Notes page, before passing the privateNote value to the API

What changes do you think we should make in order to solve the problem?

We should trim the privateNote Value here before passing to the API

App/src/pages/PrivateNotes/PrivateNotesEditPage.js

Lines 69 to 70 in 76c1559

	const savePrivateNote = () => {
	const editedNote = parser.replace(privateNote);

const editedNote = parser.replace(privateNote.trim());

Note This was my proposal that I had added on Slack, so I am commenting on GH, too.

What alternative solutions did you explore? (Optional)

none

[burczu]

I've just reviewed all the proposals - they are all the same (and correct), but in fact the one from @jayeshmangwani was the first (he posted in the slack thread first, then @kbecciv posted it for him here, and then he posted it here himself), so we should proceed with it.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @MariaHCD, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @jayeshmangwani 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @jayeshmangwani 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[jayeshmangwani]

PR is ready for review
cc: @burczu

[melvin-bot]

📣 @iamjey6! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[jayeshmangwani]

@burczu friendly bump for review

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @jayeshmangwani got assigned: 2023-09-19 01:14:44 Z
• when the PR got merged: 2023-09-25 01:38:50 UTC
• days elapsed: 4

On to the next one 🚀

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.74-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Trim privateNote value before API call #27747

If no regressions arise, payment will be issued on 2023-10-05. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @burczu does not require payment (Contractor)
• @jayeshmangwani requires payment offer (Contributor)
• @jayeshmangwani requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[jayeshmangwani]

@garrettmknight today payment will released so I want to ask if the urgency bonus be considered ?, though PR merged on 4th day but PR was raised after few hours I've assigned but C+ reviewed on 4th day, TIA

Assigned 6:44 AM

PR raised 11:32 AM , Same day

[melvin-bot]

@garrettmknight, @burczu, @MariaHCD, @jayeshmangwani Whoops! This issue is 2 days overdue. Let's get this updated quick!

[garrettmknight]

@jayeshmangwani the urgency bonus is based on the PR getting merged so this one didn't make it.

Summary of payments:

• urgency bonus? no
• Reporter: @jayeshmangwani $50 paid via Upwork
• Contributor: @jayeshmangwani $500 paid via Upwork
• Contributor+: N/A

Upwork job: https://www.upwork.com/jobs/~01a1c9388800197ffc

[kbecciv]

Issue is reproducible on build 1.3.84.0

Recording.4987.mp4

[jayeshmangwani]

@kbecciv Video you have attached is an expected behavior; we do not trim new lines between the notes. We trim if the note message has new lines at the start or end of the message

[namhihi237]

@jayeshmangwani This attached is different a bit with this issue when we click edit again it is still not trimmed, I think it's another issue and caused by another PR

[namhihi237]

Can see details here

Screen.Recording.2023-10-14.at.21.21.07.mov

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

@garrettmknight, @burczu, @MariaHCD, @jayeshmangwani Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[jayeshmangwani]

@namhihi237 is right here; this is another issue caused by another PR. It used to work during existng issue's PR merge, but resurfaced after this PR. It looks like this is a regression from this issue.

cc: @burczu @MariaHCD

[MariaHCD]

Okay, I don't have the most context on if that other issue caused this issue so I've asked here: #28599 (comment)

[MariaHCD]

Looks like it is indeed a regression from the other issue: #28599 (comment)

I think we can close this one out.