[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] mWeb- Chat - Android chrome crashes on opening password protected PDF #28179

izarutskaya · 2023-09-25T17:19:29Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Open the app
Open any report with password protected PDF sent to it
Open the password protected PDF
Observe that app crashes

Expected Result:

App should not crash on opening password protected PDF

Actual Result:

App crashes on opening password protected PDF on android chrome

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.74-0

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: @dhanashree-sawant

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695401444195489

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~016f798c5b0834a975
Upwork Job ID: 1706357780647206912
Last Price Increase: 2023-10-02
Automatic offers:

Ollyws | Reviewer | 27099989
ZhenjaHorbach | Contributor | 27099993
dhanashree-sawant | Reporter | 27099994

melvin-bot · 2023-09-25T17:19:34Z

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-09-25T17:19:34Z

Job added to Upwork: https://www.upwork.com/jobs/~016f798c5b0834a975

melvin-bot · 2023-09-25T17:19:36Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

melvin-bot · 2023-09-25T17:19:40Z

Triggered auto assignment to @abekkala (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

melvin-bot · 2023-09-25T17:19:47Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

joh42 · 2023-09-25T18:17:11Z

Hmm, works for me on my phone running Chrome 117

ZhenjaHorbach · 2023-09-25T19:52:55Z

Proposal

Please re-state the problem that we are trying to solve in this issue

Browser crashes after opening protected PDF screen

What is the root cause of that problem?

The crash was caused by canvas-size library and the problem is related to rendering large canvas elements
jhildenbiddle/canvas-size#13

What changes do you think we should make in order to solve the problem?

The topic I found completely describes our problem
And took the advice and tested the site
I came to the conclusion that this fix will suit us too

We need to update this function

App/src/libs/actions/CanvasSize.js

Lines 8 to 14 in f5409e7

    
           function retrieveMaxCanvasArea() { 
        
               canvasSize.maxArea({ 
        
                   onSuccess: (width, height) => { 
        
                       Onyx.merge(ONYXKEYS.MAX_CANVAS_AREA, width * height); 
        
                   }, 
        
               }); 
        
           }

Like

function retrieveMaxCanvasArea() {
    canvasSize
        .maxArea({
            max: Browser.isMobile() ? 8192 : null,
            usePromise: true,
            useWorker: false,
        })
        .then(() => ({
            onSuccess: (width, height) => {
                Onyx.merge(ONYXKEYS.MAX_CANVAS_AREA, width * height);
            },
        }));
}

What alternative solutions did you explore? (Optional)

NA

melvin-bot · 2023-09-29T10:56:15Z

@Ollyws, @sonialiap Whoops! This issue is 2 days overdue. Let's get this updated quick!

Ollyws · 2023-10-01T18:26:23Z

@ZhenjaHorbach Thanks for the proposal, looks good to me but can you confirm that 8192 is the optimal max value we should be using here?

ZhenjaHorbach · 2023-10-01T18:32:57Z

@Ollyws
Hello )
I used the value suggested by the topic I found
But I think we can test and see if we can use bigger values
But I don't think it makes sense
Since with increase, the load on weak devices will increase

melvin-bot · 2023-10-02T16:00:33Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Ollyws · 2023-10-03T09:00:26Z

Ok sounds good.
@ZhenjaHorbach's proposal looks good to me.
🎀👀🎀 C+ reviewed

melvin-bot · 2023-10-03T09:00:31Z

Triggered auto assignment to @youssef-lr, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

melvin-bot · 2023-10-06T11:22:05Z

@youssef-lr, @Ollyws, @sonialiap Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot · 2023-10-09T11:24:37Z

@youssef-lr @Ollyws @sonialiap this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot · 2023-10-16T21:16:43Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Android chrome crashes on opening password protected PDF #29103

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@Ollyws requires payment offer (Reviewer)
@ZhenjaHorbach requires payment offer (Contributor)
@dhanashree-sawant requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-16T21:16:45Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
[@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@Ollyws] Determine if we should create a regression test for this bug.
[@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot · 2023-10-16T21:42:22Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Android chrome crashes on opening password protected PDF #29103

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@Ollyws requires payment offer (Reviewer)
@ZhenjaHorbach requires payment offer (Contributor)
@dhanashree-sawant requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-16T21:42:24Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
[@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@Ollyws] Determine if we should create a regression test for this bug.
[@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot · 2023-10-17T14:08:26Z

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

sonialiap · 2023-10-17T14:08:46Z

I'm OOO Oct 16-23. Adding leave buddy

Status: waiting to issue payment #28179 (comment)

Ollyws · 2023-10-23T08:58:50Z

BugZero Checklist:

The PR that introduced the bug has been identified. Link to the PR:

This wasn't caused by any PR, it was an issue present in the canvas-size package: jhildenbiddle/canvas-size#13

The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

N/A

A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

N/A

Determine if we should create a regression test for this bug.

A regression test would be helpful to make sure PDFs are loading correctly as it effects this entire feature and is easy to test for.

Ollyws · 2023-10-23T09:04:01Z

Regression Test Proposal

1. Attach a password protected PDF to a report
2. Open the password protected PDF
3. Verify the PDF opens without crashing

Do we agree 👍 or 👎

sonialiap · 2023-10-23T17:24:17Z

@Ollyws review + bonus = $750 - paid ✔️
@ZhenjaHorbach fix + bonus = $750 - paid ✔️
@dhanashree-sawant report = $50 - paid ✔️

Ollyws · 2023-10-23T17:42:30Z

For some reason I was sent three offers for this, accepted one of them.

sonialiap · 2023-10-23T17:43:10Z

Haha oh no, let me go find the one you've accepted

sonialiap · 2023-10-23T17:45:07Z

Paid ✔️

izarutskaya added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 25, 2023

melvin-bot bot changed the title ~~mWeb- Chat - Android chrome crashes on opening password protected PDF~~ [$500] mWeb- Chat - Android chrome crashes on opening password protected PDF Sep 25, 2023

melvin-bot bot assigned sonialiap Sep 25, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 25, 2023

melvin-bot bot assigned abekkala Sep 25, 2023

melvin-bot bot assigned Ollyws Sep 25, 2023

abekkala removed their assignment Sep 25, 2023

melvin-bot bot added the Overdue label Sep 28, 2023

melvin-bot bot removed the Overdue label Oct 1, 2023

namhihi237 mentioned this issue Oct 3, 2023

remove validate when blur #28675

Merged

59 tasks

melvin-bot bot assigned youssef-lr Oct 3, 2023

melvin-bot bot added the Overdue label Oct 5, 2023

youssef-lr assigned ZhenjaHorbach Oct 9, 2023

melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 16, 2023

sonialiap added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Oct 17, 2023

melvin-bot bot assigned kevinksullivan Oct 17, 2023

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 17, 2023

melvin-bot bot added Daily KSv2 Overdue and removed Daily KSv2 labels Oct 20, 2023

melvin-bot bot removed the Overdue label Oct 23, 2023

sonialiap unassigned kevinksullivan Oct 23, 2023

Expensify deleted a comment from melvin-bot bot Oct 23, 2023

sonialiap closed this as completed Oct 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] mWeb- Chat - Android chrome crashes on opening password protected PDF #28179

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] mWeb- Chat - Android chrome crashes on opening password protected PDF #28179

izarutskaya commented Sep 25, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Sep 25, 2023

melvin-bot bot commented Sep 25, 2023

melvin-bot bot commented Sep 25, 2023

melvin-bot bot commented Sep 25, 2023

melvin-bot bot commented Sep 25, 2023

joh42 commented Sep 25, 2023

ZhenjaHorbach commented Sep 25, 2023 •

edited

Loading

melvin-bot bot commented Sep 29, 2023

Ollyws commented Oct 1, 2023 •

edited

Loading

ZhenjaHorbach commented Oct 1, 2023 •

edited

Loading

melvin-bot bot commented Oct 2, 2023

Ollyws commented Oct 3, 2023

melvin-bot bot commented Oct 3, 2023

melvin-bot bot commented Oct 6, 2023

melvin-bot bot commented Oct 9, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 17, 2023

sonialiap commented Oct 17, 2023

Ollyws commented Oct 23, 2023 •

edited

Loading

Ollyws commented Oct 23, 2023 •

edited

Loading

sonialiap commented Oct 23, 2023 •

edited

Loading

Ollyws commented Oct 23, 2023

sonialiap commented Oct 23, 2023

sonialiap commented Oct 23, 2023

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] mWeb- Chat - Android chrome crashes on opening password protected PDF #28179

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] mWeb- Chat - Android chrome crashes on opening password protected PDF #28179

Comments

izarutskaya commented Sep 25, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

melvin-bot bot commented Sep 25, 2023

melvin-bot bot commented Sep 25, 2023

melvin-bot bot commented Sep 25, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot bot commented Sep 25, 2023

melvin-bot bot commented Sep 25, 2023

joh42 commented Sep 25, 2023

ZhenjaHorbach commented Sep 25, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot bot commented Sep 29, 2023

Ollyws commented Oct 1, 2023 • edited Loading

ZhenjaHorbach commented Oct 1, 2023 • edited Loading

melvin-bot bot commented Oct 2, 2023

Ollyws commented Oct 3, 2023

melvin-bot bot commented Oct 3, 2023

melvin-bot bot commented Oct 6, 2023

melvin-bot bot commented Oct 9, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 17, 2023

sonialiap commented Oct 17, 2023

Ollyws commented Oct 23, 2023 • edited Loading

Ollyws commented Oct 23, 2023 • edited Loading

sonialiap commented Oct 23, 2023 • edited Loading

Ollyws commented Oct 23, 2023

sonialiap commented Oct 23, 2023

sonialiap commented Oct 23, 2023

izarutskaya commented Sep 25, 2023 •

edited by melvin-bot bot

Loading

ZhenjaHorbach commented Sep 25, 2023 •

edited

Loading

Ollyws commented Oct 1, 2023 •

edited

Loading

ZhenjaHorbach commented Oct 1, 2023 •

edited

Loading

Ollyws commented Oct 23, 2023 •

edited

Loading

Ollyws commented Oct 23, 2023 •

edited

Loading

sonialiap commented Oct 23, 2023 •

edited

Loading