[$500] Request Money - Category edit page shown for normal money request (betweem 2 users) #28192

kbecciv · 2023-09-25T20:05:49Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Create a money request with user (no workspace)
Go to that money request page
Append /edit/category to url
Category is visible

Expected Result:

Category shouldn't be shown for 1:1 money request, user should see page is not found with appropriate message

Actual Result:

Category edit page shown for normal money request (between 2 users)

Workaround

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.74.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-24.at.10.14.28.AM.mov

Recording.4767.mp4

Expensify/Expensify Issue URL:
Issue reported by: @BhuvaneshPatil
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695530860289029

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01445341bcc011416f
Upwork Job ID: 1706399640115785728
Last Price Increase: 2023-10-02

The text was updated successfully, but these errors were encountered:

melvin-bot · 2023-09-25T20:05:54Z

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-09-25T20:05:54Z

Job added to Upwork: https://www.upwork.com/jobs/~01445341bcc011416f

melvin-bot · 2023-09-25T20:05:56Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

melvin-bot · 2023-09-25T20:05:59Z

Triggered auto assignment to @dylanexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

melvin-bot · 2023-09-25T20:06:05Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

RichardPickman · 2023-09-25T21:20:58Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Category modal opens in one-to-one money request when redirecting to /edit/category.

What is the root cause of that problem?

Modal opens whenever path satisfies mask /edit/category

What changes do you think we should make in order to solve the problem?

Add additional check on request type to open category list.

App/src/pages/EditRequestPage.js

Line 182 in 4ea4a55

if (fieldToEdit === CONST.EDIT_REQUEST_FIELD.CATEGORY) {

What alternative solutions did you explore? (Optional)

Remove either Category modal block or CATEGORY constant from request due to unnecessary categories field inside of a one-to-one money request

neonbhai · 2023-09-25T21:29:05Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Catergory page editable for dms

What is the root cause of that problem?

We have not checked if the category is editable in EditRequestCategoryPage

What changes do you think we should make in order to solve the problem?

We should wrap the EditRequestCategoryPage here with FullPageNotFoundView like we do in other places in the app.

What alternative solutions did you explore? (Optional)

xx

RichardPickman · 2023-09-25T21:33:54Z

Proposal

[Updated]link to proposal

BhuvaneshPatil · 2023-09-26T03:01:54Z

@kbecciv Can you please add the proposal from slack here.

kbecciv · 2023-09-26T14:40:36Z

Proposal by: @BhuvaneshPatil
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695530860289029

Proposal

Please re-state the problem that we are trying to solve in this issue.

We can access edit category page using link for 1:1 request, but the category feature is only for workspace money requests
https://expensify.slack.com/archives/C01GTK53T8Q/p1695530938132669

What is the root cause of that problem?

We don't have any check in EditRequestCategoryPage for allowing that page to be shown for 1:1 money requests.

What changes do you think we should make in order to solve the problem?

we check for showing category in MoneyRequestView

App/src/components/ReportActionItem/MoneyRequestView.js

Line 93 in 4ea4a55

    
           const shouldShowCategory = isPolicyExpenseChat && Permissions.canUseCategories(betas) && (transactionCategory || OptionsListUtils.hasEnabledOptions(lodashValues(policyCategories)));

We shall have same check for EditRequestCategoryPage.
We shall wrap above component using FullPageNotFoundView and use same logic as we are using in MoneyRequestView.
To access all this information we need to add some props and pass few from parent component.

What alternative solutions did you explore? (Optional)

We can also add FullPageNotFoundView in

App/src/pages/EditRequestPage.js

Lines 182 to 197 in 4ea4a55

    
           if (fieldToEdit === CONST.EDIT_REQUEST_FIELD.CATEGORY) { 
        
               return ( 
        
                   <EditRequestCategoryPage 
        
                       defaultCategory={transactionCategory} 
        
                       policyID={lodashGet(report, 'policyID', '')} 
        
                       onSubmit={(transactionChanges) => { 
        
                           let updatedCategory = transactionChanges.category; 
        
                           // In case the same category has been selected, do reset of the category. 
        
                           if (transactionCategory === updatedCategory) { 
        
                               updatedCategory = ''; 
        
                           } 
        
                           editMoneyRequest({category: updatedCategory}); 
        
                       }} 
        
                   /> 
        
               ); 
        
           }

The advantage of this is that some information is already available and we don't need to add props for them.

RichardPickman · 2023-09-26T22:12:03Z

Proposal

[UPDATE] #28192 (comment) , Added permalink by rushatgabhane suggestion.

Ollyws · 2023-10-02T09:15:08Z

The first proposal from slack by @BhuvaneshPatil looks good to me.
🎀👀🎀 C+ reviewed
Edit: Already being fixed by #28165

melvin-bot · 2023-10-02T09:15:15Z

Triggered auto assignment to @cead22, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

BhuvaneshPatil · 2023-10-02T09:27:38Z

cool, thanks @Ollyws

Ollyws · 2023-10-02T10:09:15Z

Actually, this one seems to be being fixed by #28165 cc: @cead22

melvin-bot · 2023-10-02T16:00:21Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Ollyws · 2023-10-02T20:32:38Z

This is now fixed on staging, we're good to close this issue.

kbecciv added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 25, 2023

melvin-bot bot assigned CortneyOfstad Sep 25, 2023

melvin-bot bot changed the title ~~Request Money - Category edit page shown for normal money request (betweem 2 users)~~ [$500] Request Money - Category edit page shown for normal money request (betweem 2 users) Sep 25, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 25, 2023

melvin-bot bot assigned dylanexpensify Sep 25, 2023

melvin-bot bot assigned Ollyws Sep 25, 2023

melvin-bot bot added the Overdue label Sep 28, 2023

dylanexpensify removed their assignment Sep 28, 2023

melvin-bot bot added Overdue and removed Overdue labels Sep 28, 2023

melvin-bot bot removed the Overdue label Oct 2, 2023

melvin-bot bot assigned cead22 Oct 2, 2023

CortneyOfstad closed this as completed Oct 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[$500] Request Money - Category edit page shown for normal money request (betweem 2 users) #28192

[$500] Request Money - Category edit page shown for normal money request (betweem 2 users) #28192

kbecciv commented Sep 25, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Sep 25, 2023

melvin-bot bot commented Sep 25, 2023

melvin-bot bot commented Sep 25, 2023

melvin-bot bot commented Sep 25, 2023

melvin-bot bot commented Sep 25, 2023

RichardPickman commented Sep 25, 2023 •

edited

Loading

neonbhai commented Sep 25, 2023 •

edited

Loading

RichardPickman commented Sep 25, 2023 •

edited

Loading

BhuvaneshPatil commented Sep 26, 2023

kbecciv commented Sep 26, 2023

RichardPickman commented Sep 26, 2023

Ollyws commented Oct 2, 2023 •

edited

Loading

melvin-bot bot commented Oct 2, 2023

BhuvaneshPatil commented Oct 2, 2023 •

edited

Loading

Ollyws commented Oct 2, 2023

melvin-bot bot commented Oct 2, 2023

Ollyws commented Oct 2, 2023

[$500] Request Money - Category edit page shown for normal money request (betweem 2 users) #28192

[$500] Request Money - Category edit page shown for normal money request (betweem 2 users) #28192

Comments

kbecciv commented Sep 25, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround

Platforms:

melvin-bot bot commented Sep 25, 2023

melvin-bot bot commented Sep 25, 2023

melvin-bot bot commented Sep 25, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot bot commented Sep 25, 2023

melvin-bot bot commented Sep 25, 2023

RichardPickman commented Sep 25, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

neonbhai commented Sep 25, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

RichardPickman commented Sep 25, 2023 • edited Loading

Proposal

BhuvaneshPatil commented Sep 26, 2023

kbecciv commented Sep 26, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

RichardPickman commented Sep 26, 2023

Proposal

Ollyws commented Oct 2, 2023 • edited Loading

melvin-bot bot commented Oct 2, 2023

BhuvaneshPatil commented Oct 2, 2023 • edited Loading

Ollyws commented Oct 2, 2023

melvin-bot bot commented Oct 2, 2023

Ollyws commented Oct 2, 2023

kbecciv commented Sep 25, 2023 •

edited by melvin-bot bot

Loading

RichardPickman commented Sep 25, 2023 •

edited

Loading

neonbhai commented Sep 25, 2023 •

edited

Loading

RichardPickman commented Sep 25, 2023 •

edited

Loading

Ollyws commented Oct 2, 2023 •

edited

Loading

BhuvaneshPatil commented Oct 2, 2023 •

edited

Loading