Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-11-09] [HOLD for payment 2023-10-27] [TRACKING] HelpDot tidying + updates #28497

Closed
6 of 18 tasks
maddylewis opened this issue Sep 29, 2023 · 26 comments
Closed
6 of 18 tasks
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Reviewing Has a PR in review Task Weekly KSv2

Comments

@maddylewis
Copy link
Contributor

maddylewis commented Sep 29, 2023

General Updates

image

Category-specific Updates

  • Create hub Expensify Partner Program (design team request for icon here)
  • Move Expensify Card hub and nest it under Bank Accounts & Credit Cards
  • Update Exports to Insights & Custom Reporting
  • Update Policy & Domain Settings to Workspace & Domain Settings

Subcategory-specific Updates

  • Delete the `Business Bank Accounts AUD file (the resource was incorrectly published under a newly created file (Add a Business Bank Account AUD)
  • Update file name of Add-a-Business-Bank-Account-(AUD).md to Business-Bank-Account-AUD.md
  • Update file of Deposit-Accounts-AUS.md to Deposit-Accounts-AUD
  • Delete the Your Expensify Account Manager file (that resource is merged into a general "support" article)
  • Update Personal Credit Cards to Personal Cards

Articles to write (non-technical)

  • How employees get the Expensify Card
  • How employees use the Expensify Card
  • Report Details (under Expense and Report Features)

Minor fixes to published resources (Maddy can submit a PR for these)

  • Change list in SS to bulleted list

Bugs / Fixes

  • Tables in articles have a cluttered styling
  • Redirect old article links to new articles links
  • Typing the name of an article in the search bar isn't pulling up the resource (example - Scheduled Submit)
image

Ideas for Improving Visual Design

image
@maddylewis
Copy link
Contributor Author

this is a WIP -- im adding to the OP throughout the day as i come across things!

@maddylewis maddylewis added Weekly KSv2 and removed Daily KSv2 labels Sep 29, 2023
@rushatgabhane
Copy link
Member

rushatgabhane commented Oct 1, 2023

@maddylewis please add this item to the list too - Redirect old article links to new articles links

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Oct 1, 2023
@rushatgabhane
Copy link
Member

Typing the name of an article in the search bar isn't pulling up the resource

@maddylewis google serach results need to be re-indexed (refreshed).

@joaniew will help us with that (slack 🧵)

@Talha345
Copy link
Contributor

Talha345 commented Oct 2, 2023

@maddylewis @rushatgabhane Hi, I found some bugs in the HD on production. Since you guys are still working on it, can I already report the bugs as well as the solutions?

I have fixed quite some issues on HD in the past, so if you need additional manpower, i would be happy to help!

@rushatgabhane
Copy link
Member

rushatgabhane commented Oct 2, 2023

there is a know bug about back button after deeplinking.

@Talha345 other than that yes please, could you please let us know the bugs

@Talha345
Copy link
Contributor

Talha345 commented Oct 2, 2023

there is a know bug about back button after deeplinking.

@Talha345 other than that yes please, could you please let us know the bugs

@rushatgabhane Sure, should i report here or in slack?

@rushatgabhane
Copy link
Member

rushatgabhane commented Oct 2, 2023

here is good for visibility 👍

@Talha345
Copy link
Contributor

Talha345 commented Oct 2, 2023

@rushatgabhane Sure. Hope I will be compensated for valid bugs.

Steps to Reproduce:

  1. Go to https://help.expensify.com/articles/new-expensify/getting-started/chat/Expensify-Chat-For-Conference-Attendees#gsc.tab=0
  2. Click on any of the 3 links under Getting Started section.
  3. Invalid redirect happens and 404 page is shown.

Video:

Screen.Recording.2023-10-02.at.18.15.57.mov

@rushatgabhane
Copy link
Member

Thanks @Talha345

@roryabraham looks like our PR to redirect isn't working when deployed to github pages. investigating..

@rushatgabhane
Copy link
Member

@roryabraham for context looks like it's a know issue jekyll/jekyll-redirect-from#253 (comment)

It's fixed by specifying protocol https for url in _config

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 2, 2023
@rushatgabhane
Copy link
Member

rushatgabhane commented Oct 2, 2023

Tables in articles have a cluttered styling. @maddylewis could you please add this to the list too

#28576 (comment)

image

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 3, 2023
@melvin-bot melvin-bot bot changed the title [TRACKING] HelpDot tidying + updates [HOLD for payment 2023-10-10] [TRACKING] HelpDot tidying + updates Oct 3, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 3, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 20, 2023
@melvin-bot melvin-bot bot changed the title [TRACKING] HelpDot tidying + updates [HOLD for payment 2023-10-27] [TRACKING] HelpDot tidying + updates Oct 20, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 20, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 20, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Oct 20, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.87-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-10-27. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

  • @rushatgabhane does not require payment (Eligible for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@rushatgabhane
Copy link
Member

rushatgabhane commented Oct 25, 2023

Remaining items

  • Tables in articles have a cluttered styling
  • Replace with " in all articles (notice the slant)

@maddylewis
Copy link
Contributor Author

maddylewis commented Oct 27, 2023

Payments

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Oct 27, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Nov 2, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-10-27] [TRACKING] HelpDot tidying + updates [HOLD for payment 2023-11-09] [HOLD for payment 2023-10-27] [TRACKING] HelpDot tidying + updates Nov 2, 2023
Copy link

melvin-bot bot commented Nov 2, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 2, 2023
Copy link

melvin-bot bot commented Nov 2, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.94-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-11-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

  • @rushatgabhane does not require payment (Eligible for Manual Requests)

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Nov 2, 2023
@maddylewis
Copy link
Contributor Author

this is live - closing!

@JmillsExpensify
Copy link

$500 payment approved for @rushatgabhane based on this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Reviewing Has a PR in review Task Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants