-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$500] Android - User land to LHN instead of last chat conversation after close the app #28844
Comments
Job added to Upwork: https://www.upwork.com/jobs/~01e651f821abc26b7e |
Triggered auto assignment to @flaviadefaria ( |
Bug0 Triage Checklist (Main S/O)
|
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr ( |
Dear Expensify Team, I am thrilled to have the opportunity to submit a proposal for the migration-related issue outlined in GitHub issue #28844. As an experienced React Native developer, I am confident that I can contribute to the unification of your front-end across platforms and solve the problems you are facing. Proposal: Review and Acceptance: Code Submission: Contributor Guidelines: Payment Timelines: Thank you for considering my proposal. I am excited about the opportunity to contribute to Expensify's success and help in unifying your front-end across platforms. Should you have any questions or require further clarification, please do not hesitate to reach out. Best regards, |
📣 @LovelyXinf! 📣
|
Dear Expensify Team, I am thrilled to have the opportunity to submit a proposal for the migration-related issue outlined in GitHub issue #28844. As an experienced React Native developer, I am confident that I can contribute to the unification of your front-end across platforms and solve the problems you are facing. Proposal: Review and Acceptance: Code Submission: Contributor Guidelines: Payment Timelines: Thank you for considering my proposal. I am excited about the opportunity to contribute to Expensify's success and help in unifying your front-end across platforms. Should you have any questions or require further clarification, please do not hesitate to reach out. Best regards, |
Hi, I have a suggestion to fix this issue, we can save the last state of the app in the Shared Preferences e.g the last screen open when user click on the notification. After user kill the app and reopen it, we will get the saved state of app and then we will add check on it at the splash screen and will jump on the specific screen accordingly. This is the suggested solution that you have posted on upwork in Android Application |
📣 @zahid0162! 📣
|
Contributor details |
✅ Contributor details stored successfully. Thank you for contributing to Expensify! |
ProposalPlease re-state the problem that we are trying to solve in this issue.User land to LHN instead of last chat conversation after close the app What is the root cause of that problem?We're not navigating to report screen (if report screen was the last screen opened) in small screen devices. In large screen device, the There's also an issue where sometimes when opening the app again in wide screen, we're not going back to the last viewed report, which is being addressed separately in this issue. What changes do you think we should make in order to solve the problem?We should store a new local Onyx key like We'll set it to true when the In here, we should check
We should also check that the user is on the home route before this navigation, to avoid navigating user when they intend to deep link to another route. Once we navigate to ReportScreen (without What alternative solutions did you explore? (Optional)NA |
ProposalPlease re-state the problem that we are trying to solve in this issueUser land to LHN instead of last chat conversation after close the app What is the root cause of that problem?navigation to last opened report screen feature is missing What changes do you think we should make in order to solve the problem?
like above proposal What alternative solutions did you explore? (Optional)NA |
### Proposal Data to store:
###Storage:
Place to store:
Place to check:
Contributor details |
📣 @KarthickCk! 📣
|
Contributor details |
✅ Contributor details stored successfully. Thank you for contributing to Expensify! |
@LovelyXinf @zahid0162 @KarthickCk Thank you for your interest in solving this issue. Please review our CONTRIBUTING.md to understand the process better here. Keep in mind that you ALWAYS post a proposal with the PROPOSAL_TEMPLATE.md to get your proposal reviewed. |
This comment was marked as off-topic.
This comment was marked as off-topic.
ProposalPlease re-state the problem that we are trying to solve in this issueUser land to LHN instead of last chat conversation after close the app What is the root cause of that problem?We are missing the state of the chat screen, as android kills the process and opens with the launcher activity again. What changes do you think we should make in order to solve the problem?Data to store - Chat id Storage - we can use shared preference or encrypted shared preference to encrypt the chat id
What alternative solutions did you explore? (Optional)NA |
Contributor details |
|
@dukenv0307 Why do we need an early return here? And what is the reason we navigate the user on
@maxconnectAbhi Please post a different proposal from the others. |
@mollfpr The issue is resolved by the PR, but it still has a bug that might affect the redirection when the user opens the app(Please note that the bug is not coming from my code changes ) Screen.Recording.2023-10-20.at.18.04.38.mp4I think we could put it on hold since we also have a pending comment here |
@rushatgabhane You made me compare the behavior with WhatsApp 😄. WhatsApp doesn't show the latest opened chat after you killed the app. I tried to find the reason but couldn't find the Slack thread for this reported issue.
Yes, this is a feature request. Do you mean without a proposal? cc @mountiny
@dukenv0307 Is this affecting the result of the PR? |
Yes, I agree.
…On Fri, Oct 20, 2023 at 9:15 AM Luthfi ***@***.***> wrote:
@mountiny <https://github.com/mountiny> @mollfpr
<https://github.com/mollfpr> on native, why should the app open the most
recent chat?
@rushatgabhane <https://github.com/rushatgabhane> You made me compare the
behavior with WhatsApp 😄. WhatsApp doesn't show the latest opened chat
after you killed the app.
I tried to find the reason but couldn't find the Slack thread for this
reported issue.
This is a feature request. I don't think we should proceed without a
problem solution statement.
What do you think?
Yes, this is a feature request. Do you mean without a proposal?
cc @mountiny <https://github.com/mountiny>
------------------------------
The issue is resolved by the PR, but it still has a bug that might affect
the redirection when the user opens the app(Please note that the bug is not
coming from my code changes )
@dukenv0307 <https://github.com/dukenv0307> Is this affecting the result
of the PR?
—
Reply to this email directly, view it on GitHub
<#28844 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BC4YPZ4NA5UBCNGV54VM2ZLYAKPSRAVCNFSM6AAAAAA5S6YCYCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZTGAZDINRUGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I am not an android user myself so yeah I agree on getting agreement on the behaviour. From ios perspective it seems life to me to open LHN after closing the App. Could you make a post in open source channel please to discuss |
Sure, no problem.
…On Fri, Oct 20, 2023 at 9:55 AM Vit Horacek ***@***.***> wrote:
I am not an android user myself so yeah I agree on getting agreement on
the behaviour. From ios perspective it seems life to me to open LHN after
closing the App.
Could you make a post in open source channel please to discuss
—
Reply to this email directly, view it on GitHub
<#28844 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BC4YPZYCZYW2JCCO7NTATNDYAKUJ7AVCNFSM6AAAAAA5S6YCYCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZTGA3TQMBXGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
cc @Julesssss could you please help, I am thinking of closeing this issue as I thin it makes sense the app opens in LHN after closing it |
Yeah no worries, I put this at the top of my list to triage tomorrow. |
That would be great, thanks!
…On Mon, Oct 23, 2023 at 8:52 AM Jules ***@***.***> wrote:
Yeah no worries, I put this at the top of my list to triage tomorrow.
—
Reply to this email directly, view it on GitHub
<#28844 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BC4YPZYEYLRBZLTJBVHP4FLYA2HEFAVCNFSM6AAAAAA5S6YCYCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZVGUYDMOBUGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Yeah, this is the same for Android. If the user or OS kills the app we should land on the top level page again (LHN). |
@mountiny @Christinadobrzyn Are this issue will be compensated? Since we already assigned the contributor and @dukenv0307 is ready for the PR. |
Ok this was a mistaek on our behalf and we should have caught it before, lets pay 25% so $125 to @mollfpr and @dukenv0307 for their efforts here but no reporting bonus as its not a valid bug |
@mountiny I believe this should be similar to previous precedents like this or this where the compensation should be 100%. Everything is pretty much done from our ends with lots of effort put into this, the PR is up as well. |
Alright @Christinadobrzyn could you process this payment as full payment and no bonus hence $500 |
Sure, no problem.
…On Sat, Oct 28, 2023 at 6:27 AM Vit Horacek ***@***.***> wrote:
Alright @Christinadobrzyn <https://github.com/Christinadobrzyn> could you
process this payment as full payment and no bonus hence $500
—
Reply to this email directly, view it on GitHub
<#28844 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BC4YPZ3PHV3AJLPLG4P7GFTYBUB2NAVCNFSM6AAAAAA5S6YCYCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBTHAYDSOJTGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Okay, can you double-check this payment structure is correct @mountiny @mollfpr Payouts due: Issue Reporter: NA Eligible for 50% #urgency bonus? N - based on #28844 (comment) Upwork job is here. |
@Christinadobrzyn I'll do manual request in NewDot, thank you! |
sounds good to me |
Thanks, paid this out based on this payment structure - #28844 (comment) Closing this as complete, please feel free to reach out with any questions |
$500 payment approved for @mollfpr based on this summary. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
User should land to the last open chat conversation instead of LHN
Actual Result:
User land to LHN instead of last chat conversation after close the app
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.77.5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Screen_Recording_20231004_130731_New.Expensify.mp4
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696266288909289
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: