Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[$500] [Form Provider Refactor] AddressPage #28872

Closed
luacmartins opened this issue Oct 4, 2023 · 51 comments
Closed

[$500] [Form Provider Refactor] AddressPage #28872

luacmartins opened this issue Oct 4, 2023 · 51 comments
Assignees
@alexpensify @luacmartins @thesahindia @kowczarz
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Oct 4, 2023 •
edited by alexpensify
Loading

Coming from #25397 (comment), we created a new Form provider that works with functional components and we need to refactor all usages of the old Form component.

This issue is specific to refactoring src/pages/settings/Profile/PersonalDetails/AddressPage.js

cc @kowczarz

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~012aba0c7431d96aff
  • Upwork Job ID: 1709704418695823360
  • Last Price Increase: 2023-10-05
Issue OwnerCurrent Issue Owner: @kowczarz
@luacmartins luacmartins added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff labels Oct 4, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 4, 2023

Job added to Upwork: https://www.upwork.com/jobs/~012aba0c7431d96aff

@melvin-bot
Copy link

melvin-bot bot commented Oct 4, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @thesahindia (Internal)

@luacmartins luacmartins self-assigned this Oct 4, 2023
@luacmartins luacmartins added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 4, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 4, 2023

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Oct 4, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@kowczarz
Copy link
Contributor

kowczarz commented Oct 5, 2023

Hello! I'm Kamil Owczarz from Software Mansion, the expert agency and I would like to work on this task.

@luacmartins luacmartins added External Added to denote the issue can be worked on by a contributor and removed Internal Requires API changes or must be handled by Expensify staff labels Oct 5, 2023
@melvin-bot melvin-bot bot changed the title [Form Provider Refactor] AddressPage [$500] [Form Provider Refactor] AddressPage Oct 5, 2023
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 5, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 5, 2023

Current assignee @thesahindia is eligible for the External assigner, not assigning anyone new.

@luacmartins luacmartins removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 5, 2023
@melvin-bot melvin-bot bot added the Overdue label Oct 9, 2023
@alexpensify
Copy link
Contributor

@kowczarz -- any update on the proposal for this GitHub?

@melvin-bot melvin-bot bot removed the Overdue label Oct 9, 2023
@luacmartins
Copy link
Contributor Author

Similar to the hook refactor, I don't think we need a proposal for this one since the refactors are straightforward and follow the same pattern. @kowczarz authored the original refactor PR, so I think they are best suited to work on this as well :)

@alexpensify
Copy link
Contributor

Thanks @luacmartins, sounds like a plan!

@alexpensify
Copy link
Contributor

Update: Waiting for the PR to fix this issue

@melvin-bot melvin-bot bot added the Overdue label Oct 16, 2023
@luacmartins
Copy link
Contributor Author

We're still working on other forms. Will get to this one soon!

@melvin-bot melvin-bot bot removed the Overdue label Oct 16, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 18, 2023

@alexpensify @luacmartins @thesahindia @kowczarz this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@kowczarz
Copy link
Contributor

Still working on other forms.

@kowczarz
Copy link
Contributor

kowczarz commented Oct 20, 2023 •
edited
Loading

#29983 is a blocker here, as soon as it will be merged I will start working on this issue.

@alexpensify
Copy link
Contributor

@cdOut and @kowczarz - any update here?

@cdOut
Copy link
Contributor

cdOut commented Nov 30, 2023

There was a little bit of confusion due to multiple pages being named similarly. This issue will be done alongside this one, since they both address the same component, AddressForm: #32064. After that one is merged, this one will also be refactored.

@cdOut cdOut mentioned this issue Nov 30, 2023
Merged
47 tasks
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Nov 30, 2023
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Nov 30, 2023

This issue has not been updated in over 14 days. @alexpensify, @luacmartins, @thesahindia, @kowczarz eroding to Weekly issue.

@alexpensify
Copy link
Contributor

Thank you @cdOut for the update!

@alexpensify
Copy link
Contributor

Daily Update: The PR is in draft mode.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Dec 7, 2023
@alexpensify
Copy link
Contributor

Daily Update: The PR is ready for review!

@alexpensify
Copy link
Contributor

Ok, now we will need to wait for automation here.

@alexpensify
Copy link
Contributor

@luacmartins and @thesahindia it looks like automation didn't kick in here. Is this one complete? If yes, I'll need to start the manual payment process. Thanks!

@cdOut
Copy link
Contributor

cdOut commented Dec 21, 2023

It is merged and completed.

@alexpensify
Copy link
Contributor

alexpensify commented Dec 23, 2023 •
edited
Loading

Thank you @cdOut for the update!

Here is the payment summary:

  • External issue reporter - N/A
  • Contributor that fixed the issue - @cdOut Software Mansion
  • Contributor+ that helped on the issue and/or PR - @thesahindia $500

Upwork Job: N/A

Heads up, I will be offline from Friday, December 22, to Thursday, January 4, 2024. I will not be actively watching over this GitHub during that period. If anything urgent is needed here, please ask for help in the #expensify-open-source Slack Room-- thanks!

@alexpensify
Copy link
Contributor

alexpensify commented Dec 29, 2023 •
edited
Loading

No update, waiting for confirmation that @thesahindia has submitted a payment request in Chat before I close this one.

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Jan 1, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jan 1, 2024

This issue has not been updated in over 15 days. @alexpensify, @luacmartins, @thesahindia, @kowczarz eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@alexpensify
Copy link
Contributor

@thesahindia can you please confirm if you submitted a payment request? After, I can close this GH - thanks!

@thesahindia
Copy link
Member

Sorry for the delay. I have submitted the payment request. We can close this.

@alexpensify
Copy link
Contributor

Awesome, thank you for the update!

@JmillsExpensify
Copy link

$500 payment approved for @thesahindia based on this comment.

@blazejkustra blazejkustra mentioned this issue Jan 18, 2024
Merged
49 tasks
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Monthly KSv2 labels Jan 18, 2024
@blazejkustra blazejkustra mentioned this issue Feb 7, 2024
Merged
50 tasks
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexpensify alexpensify

@luacmartins luacmartins

@thesahindia thesahindia

@kowczarz kowczarz

Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@JmillsExpensify @alexpensify @luacmartins @thesahindia @cdOut @kowczarz