[HOLD for payment 2023-11-02] [$500] Chat - On revisiting from room to chat, the cursor focus is lost in chat section.

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #28646

Action Performed:

1. Launch app
2. Tap fab
3. Tap send message
4. Note the cursor focus is present in chat section
5. Tap Room and note the cursor focus is present
6. Again tap chat and note the cursor focus is lost
7. Tap Room and note the cursor focus is present
8. Tap chat and note the cursor focus

Expected Result:

On revisiting chat section from chat to room and room to chat, the cursor focus must not be lost in chat section

Actual Result:

On revisiting chat section from chat to room and room to chat, the cursor focus is lost in chat section

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.79-3

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6227517_1696599963246.an28646.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a29e7d185118a120
• Upwork Job ID: 1711319864114917376
• Last Price Increase: 2023-10-09
• Automatic offers:
• shubham1206agra | Contributor | 27326383

Issue Owner

Current Issue Owner: @allroundexperts

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a29e7d185118a120

[laurenreidexpensify]

Not overdue Melv

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[shubham1206agra]

Proposal

Please re-state the problem that we are trying to solve in this issue

Chat - On revisiting from room to chat, the cursor focus is lost in chat section

What is the root cause of that problem?

This is due to missing useDelayedInputFocus(roomNameInputRef, 600); in NewChatPage.js, which is present in WorkspaceNewRoomPage.js, which delays the focus to 600ms.

What changes do you think we should make in order to solve the problem?

Add useDelayedInputFocus(optionSelectorRef, 600); to the NewChatPage component so that it can refocus after 600 ms.

What alternative solutions did you explore? (Optional)

[shubham1206agra]

Result

Screen.Recording.2023-10-09.at.5.23.01.PM.mov

[melvin-bot]

@allroundexperts, @laurenreidexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[laurenreidexpensify]

@allroundexperts bump ^^

[allroundexperts]

@shubham1206agra's proposal looks good to me.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @grgia, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[laurenreidexpensify]

@grgia bump for assignment ^^

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[shubham1206agra]

This is still reproducible

[laurenreidexpensify]

@allroundexperts can you try reproduce and confirm? thanks

[melvin-bot]

📣 @allroundexperts Please request via NewDot manual requests for the Reviewer role ($500)

[melvin-bot]

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[grgia]

All yours @shubham1206agra !

[melvin-bot]

🎯 ⚡️ Woah @allroundexperts / @shubham1206agra / @shubham1206agra, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @shubham1206agra got assigned: 2023-10-23 10:10:17 Z
• when the PR got merged: 2023-10-24 11:18:58 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.91-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix focus in tab in newchat #30172

If no regressions arise, payment will be issued on 2023-11-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @allroundexperts does not require payment (Eligible for Manual Requests)
• @shubham1206agra requires payment offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts / @shubham1206agra] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts / @shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts / @shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts / @shubham1206agra] Determine if we should create a regression test for this bug.
• [@allroundexperts / @shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[laurenreidexpensify]

Payment Summary -

1. External issue reporter - Applause N/A
2. Contributor that fixed the issue - @shubham1206agra $500 + $250 - payment issued in Upwork
3. Contributor+ that helped on the issue and/or PR - @allroundexperts $500 + $250 - please send a manual request in Newdot

[laurenreidexpensify]

waiting on @allroundexperts to complete check list and then we can close

[melvin-bot]

@allroundexperts, @grgia, @shubham1206agra, @laurenreidexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[grgia]

bump on check list @allroundexperts

[allroundexperts]

Checklist

1. I was not able to pinpoint the exact PR which caused this. I think we created a new hook and forgot to add it to this specific component.
2. N/A
3. N/A
4. A regression test would be a good to have.

Regression test

1. Launch app -> click on fab -> select send message.
2. Click on 'Room' and then click on 'Chat' tab again.
3. Verify that the cursor focus is present on the search input.

Do we 👍 or 👎 ?

[JmillsExpensify]

$750 payment approved for @allroundexperts based on this summary.