-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-12-07] [$125] IOU Receipt - Attachment thumbnail appears when returning online after removing receipt offline #29462
Comments
Triggered auto assignment to @Christinadobrzyn ( |
Bug0 Triage Checklist (Main S/O)
|
cc @luacmartins |
Job added to Upwork: https://www.upwork.com/jobs/~0190ee90fc1a86933e |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif ( |
Upwork job price has been updated to $125 |
@lanitochka17 I don't see a "Delete receipt" button anywhere in the App, and the screen recording doesn't align with the reproduction steps. Can you confirm? |
Reproduction steps aren't clear, I'm going to remove the |
Adding the label back, the instructions were clarified here |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Triggered auto assignment to @arosiclair ( |
I don't think we need to be blocking deploy on this, in an actual use case if the user is offline the entire time then there's no way their UI would update to include the "Delete Receipt" option in the 3 dots menu. |
Triggered auto assignment to @anmurali ( |
This comment was marked as off-topic.
This comment was marked as off-topic.
We still haven't found the root cause here. I'll put a PR to start sending the correct Onyx update from the API, but that hasn't solved the issue for me locally. We can investigate further once the API changes are live. |
@anmurali, @luacmartins, @Christinadobrzyn, @aimane-chnaif Whoops! This issue is 2 days overdue. Let's get this updated quick! |
back from ooo - taking this back from Anu. Looks like we're working on the PR |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.5-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-12-07. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Prepping for payment Payouts due: Issue Reporter: NA Eligible for 50% #urgency bonus? N Upwork job is here. @aimane-chnaif do we need a regression test? |
No need regression test as this was caught by QA team |
Awesome! Paid you in Upwork based on this payment structure #29462 (comment) |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.3.83-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Note that after a while, the attachment thumbnail returns and it loads infinitely when clicking on it
Expected Result:
There will be no receipt in the money request since the receipt is removed
Actual Result:
Attachment thumbnail appears in the money request a while after going online. When tapping on it, it loads infinitely
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Bug6234608_1697122870552.20231012_215607.mp4
MacOS: Desktop
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: