[HOLD for payment 2023-12-07] [$125] IOU Receipt - Attachment thumbnail appears when returning online after removing receipt offline

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.83-1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go offline
3. Go to + > Request money > Scan > Upload a receipt > Create the request
4. Open the Scan request in details page
5. Manually enter the amount and merchant
6. Click on the receipt > three-dot menu > Delete receipt > Delete
7. Return online
   Note that after a while, the attachment thumbnail returns and it loads infinitely when clicking on it

Expected Result:

There will be no receipt in the money request since the receipt is removed

Actual Result:

Attachment thumbnail appears in the money request a while after going online. When tapping on it, it loads infinitely

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Bug6234608_1697122870552.20231012_215607.mp4

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0190ee90fc1a86933e
• Upwork Job ID: 1712522397261840384
• Last Price Increase: 2023-11-08

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[mountiny]

cc @luacmartins

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0190ee90fc1a86933e

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[melvin-bot]

Upwork job price has been updated to $125

[jasperhuangg]

Click on the receipt > three-dot menu > Delete receipt > Delete

@lanitochka17 I don't see a "Delete receipt" button anywhere in the App, and the screen recording doesn't align with the reproduction steps. Can you confirm?

[jasperhuangg]

Reproduction steps aren't clear, I'm going to remove the Deploy Blocker label for now.

[jasperhuangg]

Adding the label back, the instructions were clarified here

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @arosiclair (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[jasperhuangg]

I don't think we need to be blocking deploy on this, in an actual use case if the user is offline the entire time then there's no way their UI would update to include the "Delete Receipt" option in the 3 dots menu.

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[luacmartins]

We still haven't found the root cause here. I'll put a PR to start sending the correct Onyx update from the API, but that hasn't solved the issue for me locally. We can investigate further once the API changes are live.

[melvin-bot]

@anmurali, @luacmartins, @Christinadobrzyn, @aimane-chnaif Whoops! This issue is 2 days overdue. Let's get this updated quick!

[Christinadobrzyn]

back from ooo - taking this back from Anu. Looks like we're working on the PR

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.5-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Update transaction data type #31850

If no regressions arise, payment will be issued on 2023-12-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @aimane-chnaif requires payment

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
• [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@aimane-chnaif] Determine if we should create a regression test for this bug.
• [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[Christinadobrzyn]

Prepping for payment

Payouts due:

Issue Reporter: NA
Contributor: NA
Contributor+: $125 @aimane-chnaif (in Upwork)

Eligible for 50% #urgency bonus? N

Upwork job is here.

@aimane-chnaif do we need a regression test?

[aimane-chnaif]

No need regression test as this was caught by QA team

[Christinadobrzyn]

Awesome! Paid you in Upwork based on this payment structure #29462 (comment)