[HOLD for payment 2023-10-25] [$500] Distance - Map initially starts from "San Francisco" even if waypoints are available

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.3.81-6
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @Krishna2323
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697039744048349

Action Performed:

1. Request money > Select distance tab
2. Select "Dhaka, Bangladesh" as start point
3. Select "Bangalore, Karnataka, India" as finish point
4. Press next & select any workspace
5. Observe map loads from "Dhaka"
6. Select "Distance" tab
7. Observe map initially loads from "San Francisco"

Expected Result:

The available waypoint should be the initial location if available.

Actual Result:

The initial location is always "San Francisco"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

Recording.4966.mp4

MacOS: Desktop

desktop_app.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d6e45942a56ff196
• Upwork Job ID: 1712520876286824448
• Last Price Increase: 2023-10-12
• Automatic offers:
• s77rt | Reviewer | 27225793
• Krishna2323 | Contributor | 27225797
• krishna2323 | Reporter | 27225800

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d6e45942a56ff196

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[kbecciv]

Proposal by: @Krishna2323
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697039744048349

Proposal

Please re-state the problem that we are trying to solve in this issue.

Map initially starts from "San Francisco" even if waypoints are available

What is the root cause of that problem?

The initial location is always set to location: CONST.MAPBOX.DEFAULT_COORDINATE in DistanceRequestFooter.

What changes do you think we should make in order to solve the problem?

We should use lodashGet to get the location of waypoints if they are in state.

location: lodashGet(waypointMarkers, [0, 'coordinate'], CONST.MAPBOX.DEFAULT_COORDINATE)

Result

[s77rt]

@Krishna2323 Thanks for the proposal. Your RCA is correct. The solution looks good to me 👍. Please comment and tag me again so you can be assigned.

[Krishna2323]

@s77rt, thanks.

[s77rt]

#29471 (comment)

🎀 👀 🎀 C+ reviewed
Link to proposal

[melvin-bot]

Triggered auto assignment to @jasperhuangg, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

@s77rt, @mallenexpensify, @jasperhuangg Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[s77rt]

@jasperhuangg #29471 (comment)

[melvin-bot]

📣 @s77rt 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[Krishna2323]

@s77rt, PR ready for review.

[melvin-bot]

🎯 ⚡️ Woah @s77rt / @Krishna2323, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @Krishna2323 got assigned: 2023-10-16 18:06:39 Z
• when the PR got merged: 2023-10-17 20:58:09 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.86-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Map initially starts from 'San Francisco' even if waypoints are available. #29724

If no regressions arise, payment will be issued on 2023-10-25. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment offer (Reviewer)
• @Krishna2323 requires payment offer (Contributor)
• @Krishna2323 requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s77rt] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[s77rt]

• The PR that introduced the bug has been identified: Display single waypoint #25161
• The offending PR has been commented on: Display single waypoint #25161 (comment)
• A discussion in #expensify-bugs has been started: I don't think this is needed for this case
• Determine if we should create a regression test for this bug: Yes

---

Regression Test Proposal

1. Request money > Select distance tab
2. Select "Dhaka, Bangladesh" as start point
3. Select "Bangalore, Karnataka, India" as finish point
4. Press next & select any workspace
5. Verify map loads starting from "Dhaka, Bangladesh"
6. Select "Distance" tab
7. Verify map loads starting from "Dhaka, Bangladesh"

[mallenexpensify]

Issue reporter: @Krishna2323 paid $50 via Upwork
Contributor: @Krishna2323 paid $750 via Upwork, inc. urgency bonus
Contributor+: @s77rt via Upwork, inc. urgency bonus

Regression Test - https://github.com/Expensify/Expensify/issues/330239

Thanks y'all!