[HOLD for payment 2023-11-13] [$125] Android - Distance - Amount in the Distance e-receipt is cut off when device font size is minimum

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.84-0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

Precondition: Device font size is set to minimum (on Samsung)

1. Launch New Expensify app
2. Open a Distance expense page
3. Tap on the receipt

Expected Result:

The amount in the Distance e-receipt is not cut off

Actual Result:

The amount in the Distance e-receipt is cut off

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Bug6236869_1697278586999.Screen_Recording_20231014_110210_New_Expensify__1_.mp4

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01705b24e4119f4226
• Upwork Job ID: 1713629774323441664
• Last Price Increase: 2023-10-22
• Automatic offers:
• fedirjh | Reviewer | 27362909
• ZhenjaHorbach | Contributor | 27362910

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @deetergp (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[ZhenjaHorbach]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Amount in the Distance e-receipt is cut off when device font size is minimum

What is the root cause of that problem?

The main problem is that we have a fixed font size and dynamic lineHeight which we use for eReceiptAmount
And as a result, we encounter a case where the lineheight is less than the fontsize

App/src/styles/variables.ts

Line 57 in fe282b4

fontSizeXXXLarge: 32,

App/src/styles/variables.ts

Line 100 in fe282b4

lineHeightXXXLarge: getValueUsingPixelRatio(32, 37),

What changes do you think we should make in order to solve the problem?

To fix this bug we can update fontSizeXXXLarge(or create new fontSize for eReceiptAmout) like

getValueUsingPixelRatio(32, 37)

So that when the font size changes, the line height matches the size

What alternative solutions did you explore? (Optional)

Or use a style where lineHeight equal 32 or more static value

Before

After

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01705b24e4119f4226

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[mountiny]

I dont think this is a blocker, but we should fix it cc @neil-marcellini

[melvin-bot]

Upwork job price has been updated to $125

[mountiny]

Setting the price to $125 because this is super specific design issue with most likely easy fix

[deetergp]

Still waiting on more proposals?

[fedirjh]

Ok, let's proceed and remove it.

@deetergp let's hire @ZhenjaHorbach to do the job. The root cause looks correct, and the best solution is to remove the lineHeight.

[melvin-bot]

📣 @fedirjh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @ZhenjaHorbach 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[ZhenjaHorbach]

📣 @ZhenjaHorbach 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

PR will be ready today

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.95-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Amount in the Distance e-receipt is cut off when device font size is minimum #30401

If no regressions arise, payment will be issued on 2023-11-13. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @fedirjh requires payment offer (Reviewer)
• @ZhenjaHorbach requires payment offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
• [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@fedirjh] Determine if we should create a regression test for this bug.
• [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[bfitzexpensify]

Payments finalised, please complete the BZ checklist when you get a chance @fedirjh

[fedirjh]

The PR that introduced the bug has been identified. Link to the PR:

• Show eReceipts for distance requests #27204

The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

• Show eReceipts for distance requests #27204 (comment)

A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

• N/A , this is an edge case bug , nothing to add to checklist.

Determine if we should create a regression test for this bug.

• This is an edge case , no need for regression test.

[bfitzexpensify]

Great, thanks @fedirjh. We're all done here, closing this one out.