[$500] Split - Contact method of the participants is shown in Merchant instead of display name #29858

izarutskaya · 2023-10-18T11:39:40Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Issue found when executing PR: #29449

Version Number: v1.3.86-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

Go to staging.new.expensify.com
Go to + > Request money > Manual.
Select Split with a few participants with display name.
Create the bill split.
Click on the bill split preview > Show more.

Expected Result:

Display name of the participants will be displayed in the Merchant.

Actual Result:

Contact method of the participants is displayed in the Merchant.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Bug6241512_1697620965636.20231018_111025.mp4

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~018d28ed12ed77a99a
Upwork Job ID: 1714607183948734464
Last Price Increase: 2023-11-01

melvin-bot · 2023-10-18T11:39:45Z

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-10-18T11:39:46Z

Job added to Upwork: https://www.upwork.com/jobs/~018d28ed12ed77a99a

melvin-bot · 2023-10-18T11:39:47Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

melvin-bot · 2023-10-18T11:39:51Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

shubham1206agra · 2023-10-18T12:24:31Z

Proposal

Please re-state the problem that we are trying to solve in this issue

Split - Contact method of the participants is shown in Merchant instead of display name

What is the root cause of that problem?

In

App/src/libs/actions/IOU.js

Lines 910 to 912 in a24e6a0

    
           const formattedParticipants = isOwnPolicyExpenseChat 
        
               ? [currentUserLogin, ReportUtils.getReportName(splitChatReport)] 
        
               : Localize.arrayToString([currentUserLogin, ..._.map(participants, (participant) => participant.login || '')]);

We are using participant.login instead of participant.text, which is displaying contact method.

What changes do you think we should make in order to solve the problem?

Use participant.text instead of participant.text in the given line.
And maybe somehow use current user display name instead of currentUserLogin.

What alternative solutions did you explore? (Optional)

ayazalavi · 2023-10-18T12:42:41Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

When adding a money request manually and selecting participants, the report details show the participants' email addresses in the merchant field.

What is the root cause of that problem?

Root cause is that when adding transaction for split bill then following line of code uses user's login for generating Bill Split with string.

App/src/libs/actions/IOU.js

Lines 910 to 912 in a24e6a0

    
           const formattedParticipants = isOwnPolicyExpenseChat 
        
               ? [currentUserLogin, ReportUtils.getReportName(splitChatReport)] 
        
               : Localize.arrayToString([currentUserLogin, ..._.map(participants, (participant) => participant.login || '')]);

What changes do you think we should make in order to solve the problem?

Use getDisplayName

so instead of currentUserLogin we need to use getDisplayName(currentUserLogin, currentUserPersonalDetails)

and instead of participant.login we need to use getDisplayName(participant.login, participant)

    const formattedParticipants = isOwnPolicyExpenseChat
        ? [currentUserLogin, ReportUtils.getReportName(splitChatReport)]
        : Localize.arrayToString([getDisplayName(currentUserLogin, currentUserPersonalDetails), ..._.map(participants, (participant) => getDisplayName(participant.login, participant) || '')]);

What alternative solutions did you explore? (Optional)

We also need to ensure that if a user updates their display name from their profile, the transaction gets updated with the new display name. To achieve this, we should generate the formatted string as mentioned above before displaying the data OR update transactions merchant field as soon as user updates his or her profile, other than storing it in Onyx as follows:

App/src/libs/actions/IOU.js

Lines 914 to 927 in a24e6a0

    
           const splitTransaction = TransactionUtils.buildOptimisticTransaction( 
        
               amount, 
        
               currency, 
        
               CONST.REPORT.SPLIT_REPORTID, 
        
               comment, 
        
               '', 
        
               '', 
        
               '', 
        
               `${Localize.translateLocal('iou.splitBill')} ${Localize.translateLocal('common.with')} ${formattedParticipants} [${DateUtils.getDBTime().slice(0, 10)}]`, 
        
               undefined, 
        
               undefined, 
        
               undefined, 
        
               category, 
        
           );

zanyrenney · 2023-10-20T10:30:41Z

Nope, this is not reproducible, I suspect it has been fixed elsewhere or is an older bug:

shubham1206agra · 2023-10-20T12:39:58Z

@zanyrenney This is still reproducible
You have to complete the split request first
Then we have to check in preview

lanitochka17 · 2023-10-21T16:51:10Z

Issue is still reproducible on build 1.3.88-3

Screen_Recording_20231021_235952_Chrome.mp4

zanyrenney · 2023-10-24T13:20:36Z

Thanks for the additional step @shubham1206agra

zanyrenney · 2023-10-24T13:21:00Z

@ntdiary please can you review the initial proposals we have received?

ntdiary · 2023-10-24T15:20:19Z

Hey, @zanyrenney, sorry for the delay, there are two other issues I need to handle. I estimate I'll have time to review this issue in 24 hours, so If it's urgent, please feel free to reassign another C+. 😂

ntdiary · 2023-10-25T06:19:40Z

under review

ntdiary · 2023-10-25T07:07:03Z

@zanyrenney, I feel the expected behavior in the OP may not be what we want. In my testing, I saw different behavior: when I reopen the split report and detail page, the Merchant field always shows Request, even if I enter demo when creating it. So this feature may still be unstable, it would be better to confirm the expected behavior with our internal engineers first.

demo.mp4

melvin-bot · 2023-10-25T16:00:29Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

zanyrenney · 2023-10-27T13:15:05Z

Thanks @ntdiary I will ask for a second opinion here!

zanyrenney · 2023-10-30T18:51:57Z

Checking here - https://expensify.slack.com/archives/C01GTK53T8Q/p1698691907199119

situchan · 2023-10-30T19:18:26Z

We had same discussion - #25885 (comment)
Maybe related to https://github.com/Expensify/Expensify/issues/301281

DylanDylann · 2023-10-31T05:17:52Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

There are 3 issues that I found related to this split bill:

Issue 1: The behavior that is mentioned by @ntdiary above:

when I reopen the split report and detail page, the Merchant field always shows Request, even if I enter demo when creating it.

Issue 2: The displayed merchant data and the actual merchant data sent are different, that can make user confuse.
Issue 3: It is the issue that mentioned in this thread: Split - Contact method of the participants is shown in Merchant instead of display name.

What is the root cause of that problem?

Issue 1:When calling API 'SplitBill', we are just creating the optimisticData.merchant, but does not pass this merchant data to API.

Issue 2: Suppose the 1st issue is fixed (just to reduce the complexity): When going to MoneyRequestConfirmPage, we are always displaying the merchant field as "Request", but then the user clicks on the submit button, the actual data is passed to API 'SplitBill' is :

App/src/libs/actions/IOU.js

Line 927 in 5b5d465

    
           `${Localize.translateLocal('iou.splitBill')} ${Localize.translateLocal('common.with')} ${formattedParticipants} [${DateUtils.getDBTime().slice(0, 10)}]`,

Issue 3: We are using the below logic to generate merchant with string, that uses participant.login:

App/src/libs/actions/IOU.js

Lines 915 to 917 in 5b5d465

    
           const formattedParticipants = isOwnPolicyExpenseChat 
        
               ? [currentUserLogin, ReportUtils.getReportName(splitChatReport)] 
        
               : Localize.arrayToString([currentUserLogin, ..._.map(participants, (participant) => participant.login || '')]);

What changes do you think we should make in order to solve the problem?

Issue 1: We should pass the merchant data to 'SplitBill' API, this one is straightforward to implement.

Issue 2: When clicking on "Add to split" button to navigate to MoneyRequestConfirmPage, we need to update the iou data by updating the below logic:

App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsPage.js

Lines 77 to 80 in 5b5d465

    
           const navigateToConfirmationStep = (moneyRequestType) => { 
        
               IOU.setMoneyRequestId(moneyRequestType); 
        
               Navigation.navigate(ROUTES.MONEY_REQUEST_CONFIRMATION.getRoute(moneyRequestType, reportID)); 
        
           };

to

   const navigateToConfirmationStep = (moneyRequestType) => {
        IOU.setMoneyRequestMerchant(getSplitBillMerchant(props.iou.participants))
        ...
    };

getSplitBillMerchant is util function that we use to get the merchant and based on what we did to get the LHNRow and Report`s header in case of group chat. It can be something like:

  const getSplitBillMerchant = (participants, currentUserLogin, isOwnPolicyExpenseChat) => {
        if (isOwnPolicyExpenseChat) return [currentUserLogin, ReportUtils.getReportName(splitChatReport)];
        const participantPersonalDetails = OptionsListUtils.getPersonalDetailsForAccountIDs(participants, allPersonalDetails);
        const displayNamesWithTooltips = getDisplayNamesWithTooltips(participantPersonalDetails, true);
        return getDisplayNamesStringFromTooltips(displayNamesWithTooltips);
    };

And also we need to update:

App/src/libs/actions/IOU.js

Line 927 in 5b5d465

    
           `${Localize.translateLocal('iou.splitBill')} ${Localize.translateLocal('common.with')} ${formattedParticipants} [${DateUtils.getDBTime().slice(0, 10)}]`,

to
merchant with merchant is from iou rather than using the default merchant data.

Issue 3: Using the above getSplitBillMerchant fixed this issue as well

What alternative solutions did you explore? (Optional)

NA

aimane-chnaif · 2023-10-31T13:24:01Z

Dupe of #29691

shubham1206agra · 2023-10-31T13:33:56Z

@aimane-chnaif I just checked
This is not a dupe

DylanDylann · 2023-10-31T13:41:04Z

@aimane-chnaif My proposal mention 3 related issue #29858 (comment) So should we need to fix each issue in separate PR or wrap these into one?

melvin-bot · 2023-11-01T13:20:44Z

@ntdiary @zanyrenney this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot · 2023-11-01T16:00:49Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

zanyrenney · 2023-11-02T14:41:33Z

Hmm, I think this is a dupe of #29691

I see the comment above, but closing on these grounds.

DylanDylann · 2023-11-02T14:46:03Z

@zanyrenney it's not a dupe. Please help check my proposal for more detail.

The [HOLD for payment 2024-01-03] [$125] Split Bill - Merchant must have the same value after creating the split bill #29691 is: When calling API 'SplitBill', we are just creating the optimisticData.merchant, but does not pass this merchant data to API.
The [$500] Split - Contact method of the participants is shown in Merchant instead of display name #29858 is: Split - Contact method of the participants is shown in Merchant instead of display name

@ntdiary Can you help confirm.

situchan · 2023-11-02T14:47:03Z

@DylanDylann please check #29858 (comment).
This will be handled internally.
cc: @youssef-lr

DylanDylann · 2023-11-02T14:50:14Z

@situchan My proposal mentioned 3 related issues. What issue that you mentioned in "This will be handled internally"?

situchan · 2023-11-02T14:51:27Z

@youssef-lr will decide as he's leading split bill project. Please hold on and wait for update.

DylanDylann · 2023-11-02T14:53:59Z

@situchan Yeah. Many thanks. But I have a minor question, In the link you mentioned, I just can access the #25885, and the issue mentioned in that does not appear anymore and does not relate to this issue.

youssef-lr · 2023-11-03T00:49:39Z

@DylanDylann this is getting fixed here #30721

ntdiary · 2023-11-03T01:07:06Z

Expected Result:

Display name of the participants will be displayed in the Merchant.

I feel the expected behavior in the OP may not be what we want.

As I mentioned before, this is not so much a bug but rather a feature request, and likely one that would not get approved. 😂
So it's fine to just fix the merchant field saving problem.

ayazalavi · 2023-11-03T02:57:16Z

@ntdiary My proposal also mentioned an issue that if user updates his account details then merchant field does not gets updated with his new email address or display name what ever we need to show there.

izarutskaya added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 18, 2023

melvin-bot bot assigned zanyrenney Oct 18, 2023

melvin-bot bot changed the title ~~Split - Contact method of the participants is shown in Merchant instead of display name~~ [$500] Split - Contact method of the participants is shown in Merchant instead of display name Oct 18, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 18, 2023

melvin-bot bot assigned ntdiary Oct 18, 2023

zanyrenney closed this as completed Oct 20, 2023

lanitochka17 reopened this Oct 21, 2023

melvin-bot bot added the Overdue label Oct 24, 2023

melvin-bot bot removed the Overdue label Oct 24, 2023

melvin-bot bot added the Overdue label Oct 27, 2023

melvin-bot bot added Overdue and removed Overdue labels Oct 27, 2023

melvin-bot bot removed the Overdue label Oct 30, 2023

melvin-bot bot added the Overdue label Nov 2, 2023

zanyrenney closed this as completed Nov 2, 2023

melvin-bot bot removed the Overdue label Nov 2, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[$500] Split - Contact method of the participants is shown in Merchant instead of display name #29858

[$500] Split - Contact method of the participants is shown in Merchant instead of display name #29858

izarutskaya commented Oct 18, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Oct 18, 2023

melvin-bot bot commented Oct 18, 2023

melvin-bot bot commented Oct 18, 2023

melvin-bot bot commented Oct 18, 2023

shubham1206agra commented Oct 18, 2023

ayazalavi commented Oct 18, 2023 •

edited

Loading

zanyrenney commented Oct 20, 2023

shubham1206agra commented Oct 20, 2023

lanitochka17 commented Oct 21, 2023

zanyrenney commented Oct 24, 2023

zanyrenney commented Oct 24, 2023

ntdiary commented Oct 24, 2023

ntdiary commented Oct 25, 2023

ntdiary commented Oct 25, 2023 •

edited

Loading

melvin-bot bot commented Oct 25, 2023

zanyrenney commented Oct 27, 2023

zanyrenney commented Oct 30, 2023

situchan commented Oct 30, 2023

DylanDylann commented Oct 31, 2023 •

edited

Loading

aimane-chnaif commented Oct 31, 2023

shubham1206agra commented Oct 31, 2023

DylanDylann commented Oct 31, 2023

melvin-bot bot commented Nov 1, 2023

melvin-bot bot commented Nov 1, 2023

zanyrenney commented Nov 2, 2023

DylanDylann commented Nov 2, 2023 •

edited

Loading

situchan commented Nov 2, 2023

DylanDylann commented Nov 2, 2023

situchan commented Nov 2, 2023

DylanDylann commented Nov 2, 2023 •

edited

Loading

youssef-lr commented Nov 3, 2023

ntdiary commented Nov 3, 2023

Expected Result:

ayazalavi commented Nov 3, 2023

[$500] Split - Contact method of the participants is shown in Merchant instead of display name #29858

[$500] Split - Contact method of the participants is shown in Merchant instead of display name #29858

Comments

izarutskaya commented Oct 18, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Oct 18, 2023

melvin-bot bot commented Oct 18, 2023

melvin-bot bot commented Oct 18, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot bot commented Oct 18, 2023

shubham1206agra commented Oct 18, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

ayazalavi commented Oct 18, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

zanyrenney commented Oct 20, 2023

shubham1206agra commented Oct 20, 2023

lanitochka17 commented Oct 21, 2023

zanyrenney commented Oct 24, 2023

zanyrenney commented Oct 24, 2023

ntdiary commented Oct 24, 2023

ntdiary commented Oct 25, 2023

ntdiary commented Oct 25, 2023 • edited Loading

melvin-bot bot commented Oct 25, 2023

zanyrenney commented Oct 27, 2023

zanyrenney commented Oct 30, 2023

situchan commented Oct 30, 2023

DylanDylann commented Oct 31, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

aimane-chnaif commented Oct 31, 2023

shubham1206agra commented Oct 31, 2023

DylanDylann commented Oct 31, 2023

melvin-bot bot commented Nov 1, 2023

melvin-bot bot commented Nov 1, 2023

zanyrenney commented Nov 2, 2023

DylanDylann commented Nov 2, 2023 • edited Loading

situchan commented Nov 2, 2023

DylanDylann commented Nov 2, 2023

situchan commented Nov 2, 2023

DylanDylann commented Nov 2, 2023 • edited Loading

youssef-lr commented Nov 3, 2023

ntdiary commented Nov 3, 2023

Expected Result:

ayazalavi commented Nov 3, 2023

izarutskaya commented Oct 18, 2023 •

edited by melvin-bot bot

Loading

ayazalavi commented Oct 18, 2023 •

edited

Loading

ntdiary commented Oct 25, 2023 •

edited

Loading

DylanDylann commented Oct 31, 2023 •

edited

Loading

DylanDylann commented Nov 2, 2023 •

edited

Loading

DylanDylann commented Nov 2, 2023 •

edited

Loading