Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-10-18 #29926

Closed
64 tasks done
OSBotify opened this issue Oct 18, 2023 · 14 comments
Closed
64 tasks done

Deploy Checklist: New Expensify 2023-10-18 #29926

OSBotify opened this issue Oct 18, 2023 · 14 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Oct 18, 2023

Release Version: 1.3.87-12
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@kavimuru kavimuru added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Oct 19, 2023
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.87-0 🚀

@francoisl
Copy link
Contributor

@kavimuru - Heads up that the iOS build has been failing twice in a row so far. We're looking into, but the new iOS build 1.3.87-1 is not available yet.
I'll post a message when that's resolved, in the meantime feel free to start testing on other platforms.

@cristipaval
Copy link
Contributor

Checking off #29967, asked for a CP request here

@kavimuru
Copy link

Regression is 28% progress
#29903 failing with #29971
#29797 failing with #29995
#29665 failing with #29972 (Reproducible in production, ok to check it off?)

@francoisl
Copy link
Contributor

We discussed #29978 and decided not to block on it, checking it off.

@jasperhuangg
Copy link
Contributor

Checking off #29976

@francoisl
Copy link
Contributor

francoisl commented Oct 19, 2023

Working on the remaining blockers, I'll update the list below gradually as we fix them:

@kavimuru
Copy link

kavimuru commented Oct 19, 2023

Regression is down to 20%
#29903 failing with #29917
#29797 failing with #29995
#29741 failing with #28078 (Reproducible in Desktop)
#29655 failing with #29972 (Reproducible in production, ok to check it off?)
#29738 failing with #27992 failing in android

@mvtglobally
Copy link

Regression is down to 13%
#29573 - CP Validations pending
#29738 failing with #27992 failing in android
#29741 failing with #28078 (Reproducible in Desktop)
#29797 failing with #29995. Repro in PROD. checking off
#29903 failing with #29971
#29915 - CP Validations pending
#30017 - CP Validations pending

@francoisl
Copy link
Contributor

@mvtglobally
Copy link

Regression is completed

Open Blockers
#30020
#30064
#30078

Unchecked PR
#29573 - failing with #30069

@francoisl
Copy link
Contributor

francoisl commented Oct 20, 2023

@francoisl
Copy link
Contributor

A fix for the last blocker is in review 🥵. We'll test it internally when it's CP'ed (ETA ~1h) then we should be good to go 🤞

@francoisl
Copy link
Contributor

:shipit:

@francoisl francoisl self-assigned this Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

7 participants