[CP Staging] added component #30081

ayazalavi · 2023-10-20T13:26:23Z

Details

When selecting an emoji in a chat, the AM/PM from the previous line is also selected. This bug occurs because the browser calculates emojis as multi-byte characters. When an emoji appears as the first character in a chat, the browser has no reference point to determine the starting byte of the emoji. As a result, the browser selects the previous word as the starting point for the emoji bytes.

Fixed Issues

$ #29021
$ #30064
PROPOSAL: #29021 (comment)

Tests

Open the app
Open any report
Send any emoji or emoji plus text (ensure emoji is first)
Double click on left half of emoji and observe that it select emoji plus AM/PM of above time
App should not select AM/PM from time above on double click selection of emoji

Verify that no errors appear in the JS console

Offline tests

same as above

QA Steps

same as above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

f7040aac-f06a-4b3b-aeb2-9367d6b7a9de.mp4

Android: mWeb Chrome

f7040aac-f06a-4b3b-aeb2-9367d6b7a9de.mp4

iOS: Native

e255a560-f5ec-4a59-a262-17c25cf2060e.mp4

iOS: mWeb Safari

e255a560-f5ec-4a59-a262-17c25cf2060e.mp4

MacOS: Chrome / Safari

523f20f8-e1b0-4027-b731-96d215883016.mp4

MacOS: Desktop

af74c7ed-b2d9-4903-a629-09301062b43d.mp4

Signed-off-by: Ayaz Alavi <ayaz.alavi@gmail.com>

melvin-bot · 2023-10-20T13:26:29Z

@narefyev91 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

narefyev91 · 2023-10-20T13:40:01Z

src/pages/home/report/ReportActionItemFragment.js

@@ -139,7 +121,10 @@ function ReportActionItemFragment(props) {

            return (
                <Text style={[containsOnlyEmojis ? styles.onlyEmojisText : undefined, styles.ltr, ...props.style]}>
-                    {checkForEmojiForSelection(text, props.displayAsGroup)}
+                    <ZeroWidthComponent


this is breaking web

narefyev91 · 2023-10-20T13:45:20Z

src/components/ZeroWidthComponent/index.js

+const checkForEmojiForSelection = ({text, displayAsGroup}) => {
+    const firstLetterIsEmoji = EmojiUtils.isFirstLetterEmoji(text);
+    if (firstLetterIsEmoji && !displayAsGroup && !Browser.isMobile()) {
+        return <Text>&#x200b;</Text>;


i do not see import for Text tag

narefyev91 · 2023-10-20T13:47:27Z

src/components/ZeroWidthComponent/index.js

+ * @returns {ReactNode | null} Text component with zero width character
+ */
+
+const checkForEmojiForSelection = ({text, displayAsGroup}) => {


if you exporting this as a React component name should be ZeroWidthComponent - with default props, default displayName and default propTypes defined

Sorry forgot to add those earlier. Please check now.

Signed-off-by: Ayaz Alavi <ayaz.alavi@gmail.com>

src/components/ZeroWidthComponent/index.native.js

Signed-off-by: Ayaz Alavi <ayaz.alavi@gmail.com>

narefyev91 · 2023-10-20T14:12:10Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web1.mov

Mobile Web - Chrome

android-web1.mov

Mobile Web - Safari

ios-web1.mov

Desktop

desktop1.mov

iOS

ios1.mov

Android

android1.mov

narefyev91 · 2023-10-20T14:14:58Z

src/components/ZeroWidthView/index.native.js

@@ -0,0 +1,5 @@
+function ZeroWidthView() {


last note - please add comments why we return null for native - just to not forget the reason @ayazalavi

narefyev91

LGTM! Needs to add notes for native.js file - overall issue is resolved
🎀 👀 🎀 C+ reviewed

mountiny

@ayazalavi Please address this in some of your next PRs https://github.com/Expensify/App/pull/30081/files#r1367034384

OSBotify · 2023-10-20T15:28:17Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…n_bug [CP Staging] added component (cherry picked from commit 115974e)

OSBotify · 2023-10-20T16:25:49Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.3.87-9 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-10-20T21:06:43Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.87-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

added component

0c18129

Signed-off-by: Ayaz Alavi <ayaz.alavi@gmail.com>

ayazalavi requested a review from a team as a code owner October 20, 2023 13:26

melvin-bot bot requested review from narefyev91 and removed request for a team October 20, 2023 13:26

ayazalavi mentioned this pull request Oct 20, 2023

[HOLD for payment 2023-10-27] [$500] Chat - Emoji are cut off at the top if message contains only emoji and is located under avatar #30064

Closed

6 tasks

narefyev91 reviewed Oct 20, 2023

View reviewed changes

mountiny changed the title ~~added component~~ [CP Staging] added component Oct 20, 2023

narefyev91 reviewed Oct 20, 2023

View reviewed changes

added default props

f96c3c5

Signed-off-by: Ayaz Alavi <ayaz.alavi@gmail.com>

narefyev91 reviewed Oct 20, 2023

View reviewed changes

src/components/ZeroWidthComponent/index.native.js Outdated Show resolved Hide resolved

mountiny assigned ayazalavi Oct 20, 2023

ayazalavi added 2 commits October 20, 2023 19:03

added name change

33e4444

Signed-off-by: Ayaz Alavi <ayaz.alavi@gmail.com>

changed component name

b4fb81a

Signed-off-by: Ayaz Alavi <ayaz.alavi@gmail.com>

narefyev91 reviewed Oct 20, 2023

View reviewed changes

narefyev91 approved these changes Oct 20, 2023

View reviewed changes

melvin-bot bot requested a review from Li357 October 20, 2023 14:15

mountiny approved these changes Oct 20, 2023

View reviewed changes

mountiny merged commit 115974e into Expensify:main Oct 20, 2023
13 of 14 checks passed

OSBotify pushed a commit that referenced this pull request Oct 20, 2023

Merge pull request #30081 from ayazalavi/ayaz/GH-29021_am_pm_selectio…

c6cd1f1

…n_bug [CP Staging] added component (cherry picked from commit 115974e)

OSBotify mentioned this pull request Oct 20, 2023

Deploy Checklist: New Expensify 2023-10-18 #29926

Closed

64 tasks

melvin-bot bot mentioned this pull request Oct 20, 2023

[HOLD for payment 2023-10-27] [$500] Double tap on emoji selects am/pm of the time of the message #29021

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CP Staging] added component #30081

[CP Staging] added component #30081

ayazalavi commented Oct 20, 2023 •

edited by mountiny

Loading

melvin-bot bot commented Oct 20, 2023

narefyev91 Oct 20, 2023

narefyev91 Oct 20, 2023

narefyev91 Oct 20, 2023

narefyev91 Oct 20, 2023

ayazalavi Oct 20, 2023

narefyev91 commented Oct 20, 2023

narefyev91 Oct 20, 2023

narefyev91 left a comment

mountiny left a comment

OSBotify commented Oct 20, 2023

OSBotify commented Oct 20, 2023

OSBotify commented Oct 20, 2023

[CP Staging] added component #30081

[CP Staging] added component #30081

Conversation

ayazalavi commented Oct 20, 2023 • edited by mountiny Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 20, 2023

narefyev91 Oct 20, 2023

Choose a reason for hiding this comment

narefyev91 Oct 20, 2023

Choose a reason for hiding this comment

narefyev91 Oct 20, 2023

Choose a reason for hiding this comment

narefyev91 Oct 20, 2023

Choose a reason for hiding this comment

ayazalavi Oct 20, 2023

Choose a reason for hiding this comment

narefyev91 commented Oct 20, 2023

Reviewer Checklist

Screenshots/Videos

narefyev91 Oct 20, 2023

Choose a reason for hiding this comment

narefyev91 left a comment

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Oct 20, 2023

OSBotify commented Oct 20, 2023

OSBotify commented Oct 20, 2023

ayazalavi commented Oct 20, 2023 •

edited by mountiny

Loading