Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Chat - No gradient between the solid color and the image in the background #30499

Closed
4 of 6 tasks
izarutskaya opened this issue Oct 27, 2023 · 16 comments
Closed
4 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Reviewing Has a PR in review Weekly KSv2

Comments

@izarutskaya
Copy link

izarutskaya commented Oct 27, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.3.92-0

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation: @

Action Performed:

  1. Go to staging.new.expensify.com
  2. Open any new chat.

Expected Result:

There is color gradient between the solid color and the image in the background.

Actual Result:

There is no gradient between the solid color and the image in the background.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Bug6252996_1698394601345!Screenshot_2023-10-27_at_14 22 20

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f667fedc8bac5732
  • Upwork Job ID: 1717871053320433664
  • Last Price Increase: 2023-10-27
Issue OwnerCurrent Issue Owner: @justinpersaud
@izarutskaya izarutskaya added DeployBlockerCash This issue or pull request should block deployment External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 27, 2023
@melvin-bot melvin-bot bot changed the title Chat - No gradient between the solid color and the image in the background [$500] Chat - No gradient between the solid color and the image in the background Oct 27, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 27, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01f667fedc8bac5732

@melvin-bot
Copy link

melvin-bot bot commented Oct 27, 2023

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 27, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 27, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot
Copy link

melvin-bot bot commented Oct 27, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @burczu (External)

@izarutskaya
Copy link
Author

izarutskaya commented Oct 27, 2023

Not reproducible in production

Screenshot 2023-10-27 at 14 23 47

@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Oct 27, 2023

Triggered auto assignment to @cristipaval (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@jayeshmangwani
Copy link
Contributor

jayeshmangwani commented Oct 27, 2023

It seems like a regression from the ImgBot github action, if we manually use this original image then it works fine but when we using optimised image then it will remove the fade effect,
cc: @roryabraham @justinpersaud

@justinpersaud
Copy link
Contributor

Yeah I see the same issue. It's from this PR the bot made.

#30383

It's supposed to compress with lossless compression, so I wonder why it affects colour gradients.

@justinpersaud
Copy link
Contributor

Submitted the fix #30512

@cristipaval cristipaval removed their assignment Oct 27, 2023
@cristipaval
Copy link
Contributor

Thanks for jumping into this one @justinpersaud !

@Julesssss Julesssss removed the DeployBlockerCash This issue or pull request should block deployment label Oct 27, 2023
@Julesssss
Copy link
Contributor

Removing the blocker label, it's now Cpd and on the checklist

@justinpersaud
Copy link
Contributor

Closing this of then as resolved

@kbecciv
Copy link

kbecciv commented Dec 2, 2023

Issue is reproduced on build 1.4.7.0, re-opening
bandicam 2023-12-02 12-09-57-433

@kbecciv kbecciv reopened this Dec 2, 2023
@Julesssss
Copy link
Contributor

Hi @kbecciv can you please open this as a new regression? Thanks

@kbecciv
Copy link

kbecciv commented Dec 4, 2023

New ticket created #32441

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

9 participants