Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-10-26 #30469

Closed
64 tasks done
OSBotify opened this issue Oct 26, 2023 · 10 comments
Closed
64 tasks done

Deploy Checklist: New Expensify 2023-10-26 #30469

OSBotify opened this issue Oct 26, 2023 · 10 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Oct 26, 2023

Release Version: 1.3.92-4
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@kavimuru kavimuru added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Oct 26, 2023
@marcaaron marcaaron self-assigned this Oct 26, 2023
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.92-0 🚀

@kavimuru
Copy link

Regression is at 70%
#27429 failing with #26990 (not fixed)
#30243 failing with #30012 (not fixed in android and iOS)

@Julesssss
Copy link
Contributor

Checked off #30499 as it was resolved by this PR that was CPd

@kavimuru
Copy link

Regression we are down to 4%

@marcaaron
Copy link
Contributor

We fixed #30394 yesterday so going to check it off.

@luacmartins
Copy link
Contributor

Checking off #30510 since we're CPing a fix

@kavimuru
Copy link

Regression completed

@Beamanator Beamanator self-assigned this Oct 30, 2023
@Beamanator
Copy link
Contributor

Note: There was 1 new Firebase crash (discussed in slack here) - I don't feel we need to spend too much time diagnosing right now since it only happened to 1 person, so I'm saying let's ship this

@Beamanator
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

7 participants