[C+ Checklist Needs Completion] [$500] Web - The app is freezing after switching tabs, and the performance of the tab navigator seems to be quite poor

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.98.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @situchan
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1699629011502749?thread_ts=1699456424.016869&cid=C01GTK53T8Q

Action Performed:

1. Go to staging.new.expensify.com
2. Tab on Fab menu
3. Select Request Money
4. Navigate through the tabs

Expected Result:

The app is not freezing after switching tabs, and the performance of the tab navigator should be good

Actual Result:

The app is freezing after switching tabs, and the performance of the tab navigator seems to be quite poor

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

performance.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c6d30dd934f349b1
• Upwork Job ID: 1723032823278329856
• Last Price Increase: 2023-11-10

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @stitesExpensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[kbecciv]

Removing Deploy blocker per the comment https://expensify.slack.com/archives/C01GTK53T8Q/p1699637937484459?thread_ts=1699456424.016869&cid=C01GTK53T8Q

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c6d30dd934f349b1

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[greg-schroeder]

Awaiting proposals

[davidnormo]

Proposal

Please re-state the problem that we are trying to solve in this issue.

A performance issue (FAB -> Request Money) when switching tabs, glitching occurs in the browser but not on native devices.

What is the root cause of that problem?

There's lots of layers of abstraction being used because of react-native-web. These all compile down nicely when run on device but in the browser there's too much happening on the main thread, work isn't being completed within the 16ms needed for a smooth 60fps animation.

The above is a chrome dev tools performance capture while running locally. Each of the "Animation Frame Fired" tasks are taking too long. The animations are being run by @react-navigation/material-top-tabs which uses react-native's animated library. I can't find any extra state that is changing that is causing additional work. It just appears that the application is too "heavy" for this animation on web.

What changes do you think we should make in order to solve the problem?

I suggest we use a custom implementation for web i.e. TabNavigator.web.js that focuses on being lightweight. The ios/android versions can use the native implementation which doesn't seem to be glitchy.

What alternative solutions did you explore? (Optional)

None.

[melvin-bot]

📣 @davidnormo! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[davidnormo]

Contributor details
Your Expensify account email: david.normo@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~0108d5ebd2889d3ebf

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[davidnormo]

@mananjadhav @greg-schroeder @stitesExpensify what do you guys think?

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.24-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix OnyxTab Navigator performance issues on web #33841

If no regressions arise, payment will be issued on 2024-01-22. 🎊

For reference, here are some details about the assignees on this issue:

• @mananjadhav requires payment through NewDot Manual Requests
• @shubham1206agra requires payment (Needs manual offer from BZ)
• @kacper-mikolajczak does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav / @shubham1206agra] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav / @shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav / @shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav / @shubham1206agra] Determine if we should create a regression test for this bug.
• [@mananjadhav / @shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[greg-schroeder]

Okay so there was another deploy blocker related to this? Seems #34377 is still open...

[mananjadhav]

@greg-schroeder I wouldn't call it a deploy blocker because we intentionally disabled animations.

wdyt @mountiny @stitesExpensify ?

Also this is ready for payout.

[greg-schroeder]

Ah, okay, I understand. So there was one initial performance regression leading to a revert and new PR, but the second linked deploy blocker is not grounds for a second reduction as disabled animations was intended behavior.

In that case @mananjadhav you can make a manual request for $250 for the C+ role for this issue.

Seems @shubham1206agra was listed by the automation but I see Manan did the review on both PRs, so I'm not sure what's up there. 🤔

——————

Last step would be to complete the checklist @mananjadhav then we can close this out!

[shubham1206agra]

@greg-schroeder I think I am up for partial compensation.

@mountiny can verify this.

[mananjadhav]

@greg-schroeder I think I am up for partial compensation.

@mountiny can verify this.

Agreed with @shubham1206agra here.

I don't think we have any offending PR as this was a performance issue, and we disable the animation as a solution. Neither do I think we need a regression test for this one.

[mountiny]

@mananjadhav @shubham1206agra I can see you both have reviewed the PR. I agree there was no regression, but I feel like you should divide the reward of $500 in this case, its not clear to me now why both c+ were needed

[mananjadhav]

@mountiny More info here on why @shubham1206agra got involved and where we committed for the partial payout.

I think $250 each is fine for me.

[mountiny]

Thank you for the link, I agree $250 each sounds fair!

[mananjadhav]

@greg-schroeder Can you add a payment summary comment for us to raise a request?

[JmillsExpensify]

$250 payment approved based on this comment. That is sufficient.

[greg-schroeder]

Sorry, yeah okay so the final breakdown was:

@mananjadhav $250
@shubham1206agra $250

[shubham1206agra]

@greg-schroeder I didn't received any payment for the same.

[greg-schroeder]

Sorry, this was confusing @shubham1206agra - paying you here: #35793

[shubham1206agra]

@greg-schroeder Accepted offer.