-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-11-29] [$125] Desktop - Avatars in split preview card too close to right edge #31394
Comments
Triggered auto assignment to @puneetlath ( |
Job added to Upwork: https://www.upwork.com/jobs/~014ce3040ec2425cf6 |
Bug0 Triage Checklist (Main S/O)
|
Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat ( |
Upwork job price has been updated to $125 |
I'm going to try and fix this in an ongoing PR. If not we can let this be external. |
ProposalPlease re-state the problem that we are trying to solve in this issue.The avatars are incorrectly placed What is the root cause of that problem?The avatars use the negative margin here, which was added in 2021 (#2112), but now seems like a redundant code: Lines 2661 to 2664 in e953a65
What changes do you think we should make in order to solve the problem?We actually can remove the special style here:
And the What alternative solutions did you explore? (Optional) |
ProposalPlease re-state the problem that we are trying to solve in this issue.The avatars are incorrectly placed # What is the root cause of that problem?The avatars margin is -10 .. and in the left we have 16 px so the padding on the right and left are not the same Lines 2666 to 2668 in 91979f9
Line 2682 in 91979f9
What changes do you think we should make in order to solve the problem?we have 16 px in the front padding so we need to make the avatar padding
|
ProposalPlease re-state the problem that we are trying to solve in this issue.The avatars are incorrectly placed What is the root cause of that problem?We have incorrect marginRight in What changes do you think we should make in order to solve the problem?We need to remove marginRight or smaller than now. Line 2683 in cc5a272
What alternative solutions did you explore? (Optional) |
@paultsimura 's proposal looks good to me. 🎀 👀 🎀 C+ reviewed |
Current assignee @puneetlath is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new. |
ProposalPlease re-state the problem that we are trying to solve in this issue.The Avatar stack has a hard-coded margin which makes the margin to go beyond the parent container's width. What is the root cause of that problem?The Avatar stack has a What changes do you think we should make in order to solve the problem?It seems like the row with the amount and avatar has We should adjust this to the What alternative solutions did you explore? (Optional)We should remove margin from |
📣 @parasharrajat Please request via NewDot manual requests for the Reviewer role ($125) |
📣 @paultsimura 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
Thanks. The PR is ready: #31430 |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.1-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-11-29. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Payment summary:
Closing. Thanks everyone! |
Payment requested as per #31394 (comment) |
$125 payment approved for @parasharrajat based on comment above. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.3.99.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1700000146978699
Action Performed:
Expected Result:
Avatar stacak should be 20px (or is it 16px?) away from the right edge of the card, it should match the same padding as left side
Actual Result:
Avatar stack is too close to right edge
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
2023-11-15.1.10.24.PM.mov
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: