[Payment due 2023-12-21] [$500] Chat - Text in the composer loses the hightlight as soon as the cursor reaches the LHN

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.1.4
Reproducible in staging?: Y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Navigate to https://staging.new.expensify.com/
2. Open any 1:1 chat
3. Click inside the composer
4. Type in any text
5. Click on the empty space after your text (still inside the composer)
6. Slowly start moving your mouse to the LNH while holding the mouse button

Expected Result:

The text should be highlighted even when the cursor reaches the LNH

Actual Result:

The text in the composer loses the hightlight as soon as the cursor reaches the LNH

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6284256_1700505162669.bandicam_2023-11-20_18-35-47-842.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010f7879c01d6e7f2b
• Upwork Job ID: 1726671955755700224
• Last Price Increase: 2023-12-04
• Automatic offers:
• bernhardoj | Contributor | 28012611

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010f7879c01d6e7f2b

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[witehound]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Text in the composer loses the hightlight as soon as the cursor reaches the LNH

What is the root cause of that problem?

Here

App/src/pages/home/sidebar/SidebarScreen/BaseSidebarScreen.js

Line 31 in 84811dc

style={[styles.sidebar, Browser.isMobile() ? styles.userSelectNone : {}]}

styles.userSelectNone is being used in this component.

What changes do you think we should make in order to solve the problem?

App/src/pages/home/sidebar/SidebarScreen/BaseSidebarScreen.js

Line 31 in 84811dc

style={[styles.sidebar, Browser.isMobile() ? styles.userSelectNone : {}]}

styles.userSelectNone should not be used, as it uses Browser.isMobile() condition which is always false.

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

📣 @witehound! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[witehound]

Contributor details
Your Expensify account email: netvid00@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~011e0ee171549014ff

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[ZhenjaHorbach]

@witehound
Can you give more explanation?)

The video is not a mobile browser
And therefore styles.userSelectNone is not used in this case )

[parasharrajat]

@witehound Thanks for the proposal. I noticed that when we move the cursor on the items rendered above the FAB menu the highlight is not removed. only when the cursor is moved inline to FAB buttons, it hides. So I am not sure how your proposal solves the issue.

Can you please explain the root cause on how it is really the root cause?

[witehound]

@parasharrajat , @ZhenjaHorbach so i think this proposal might be redundant! this is my first time looking at the code base and i figured removing the userSelectNone might fix the bug!

[shahinyan11]

@parasharrajat I think It is not a bug. It is standard behavior . It related mouse position. Even here if you try to highlight any text from right to left and move mouse to down the highlight will disappear .
Or you can move FAB button to top (e.g. 100px ) and try to test again. You will see that the highlight will not disappear.

[codecreator28]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Text in the composer loses the hightlight as soon as the cursor reaches the LNH

What is the root cause of that problem?

The expected behavior is that the text selection state should continue even if the mouse cursor moves outside of the input field.
When the mouse cursor moves outside of the input field, it is no longer affected by the user-select property, and the browser's default behavior of deselecting the text takes effect.

What changes do you think we should make in order to solve the problem?

To achieve the expected behavior, you need to apply the user-select CSS property to the body element of the input field. This will ensure that the text selection state is preserved even if the mouse cursor moves outside of the input field.

Please add following code to onFocus and onBlur function in /src/pages/home/report/ReportActionCompose/ReportActionCompose.js

onFocus function:
document.body.style.userSelect = 'all';

onBlur function:
document.body.style.userSelect = 'none';

What alternative solutions did you explore? (Optional)

---Safari---
document.body.style.webkitUserSelect

[s-alves10]

This issue is not reproducible in the latest main

[parasharrajat]

I can reproduce... Let's wait for some decent proposals. Otherwise, it is not a big deal.

[laurenreidexpensify]

Let's see if we get any more proposals by EOW and take it from there

[s-alves10]

@parasharrajat

Can you please tell me if you're able to reproduce the issue in the latest main?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[parasharrajat]

Yes, I can reproduce this on the latest main.

Screen.Recording.2023-11-30.at.2.07.53.PM.mov

[parasharrajat]

Still no response on the original PR. IMO, we should be good to use margin instead of transform as we are not changing it dynamically so their overall impact on rendering should be the same as transform. The only difference is that currently it is rendered via GPU and the margin will force it to use CPU.

@bernhardoj can you please do some testing around it and confirm that the margin does not change anything? If that is the case, we can go with your proposal.

[codecreator28]

Hi, @parasharrajat
Could you please check my updated comment

[parasharrajat]

I have seen it @sukach318 but I don't think it is a good solution because it does not target the root cause. We have disabled the selection on the sidebar intentionally and we don't want to change that. The problem here is to prevent selection from getting hidden from the composer.

[bernhardoj]

@parasharrajat So far I found no issue. The visual is still the same and the sidebar is still interactable.

[parasharrajat]

Let's roll then.... @bernhardoj suggestion looks good to me. @bernhardoj Please convert that post to a proposal.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @francoisl, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[codecreator28]

@parasharrajat The same phenomenon occurs not only when you move the mouse sideways but also when you move it down or to the up while selected.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The composer input text selection is lost as soon as we move our mouse while dragging the selection to the FAB.

What is the root cause of that problem?

I did play around with the layout and it looks like the issue is with how we style the layout.

The sidebar screen has a translateX of -375px to shift it to the left.

App/src/libs/Navigation/AppNavigator/getRootNavigatorScreenOptions.js

Lines 37 to 44 in 9dbf39d

	cardStyle: {
	...getNavigationModalCardStyle(),
	width: isSmallScreenWidth ? '100%' : variables.sideBarWidth,
	// We need to translate the sidebar to not be covered by the StackNavigator so it can be clickable.
	transform: [{translateX: isSmallScreenWidth ? 0 : -variables.sideBarWidth}],
	...(isSmallScreenWidth ? {} : styles.borderRight),
	},

The current behavior is, that the selection is lost when it touches the FAB (the OP video).

What changes do you think we should make in order to solve the problem?

Replacing translateX with marginLeft: -375 seems to fix the selection issue (sidebar is still clickable).

Screen.Recording.2023-12-04.at.16.17.21.mov

[melvin-bot]

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[bernhardoj]

PR is ready

cc: @parasharrajat

[laurenreidexpensify]

Heh - this should be paid on 21 Dec, looks like it was on prod from 14 Dec #32772 (comment)

[melvin-bot]

@francoisl, @parasharrajat, @bernhardoj, @laurenreidexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[laurenreidexpensify]

Payment Summary:

Contributor: @bernhardoj $500 paid in Upwork
C+ review: @parasharrajat $500 please request payment in NewDot

Outstanding steps: @parasharrajat please complete a checklist and confirm if we need a regression test thanks

[parasharrajat]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: [navigation-refactor] Style based approach for the three pane layout #22437
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/22437/files#r1438144247
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not needed
• [@parasharrajat] Determine if we should create a regression test for this bug. Yes
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps

Web/Desktop

1. Open any chat
2. Type anything in the composer
3. Drag a text selection from the end of the text in the composer towards the FAB in the sidebar/LHN
4. Verify the text selection persist

Do you agree 👍 or 👎 ?

[parasharrajat]

@laurenreidexpensify Done. Please close the issue if nothing is left here. I will request the payment later and track it myself. Thanks.

[parasharrajat]

Payment requested as per #31573 (comment)

[JmillsExpensify]

$500 approved for @parasharrajat