[HOLD for payment 2023-12-12] [$500] IOU - Unable to create IOU with "Hidden" users

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.3.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Create group conversation with users you have not existing conversation before
3. Click on "+" button from chat composer> Split Bill
4. Add amount and click Next button

Expected Result:

User should be able to create Split bill with "Hidden" users, Split button should be active

Actual Result:

User is not able to create IOU with "Hidden" users, Split button is grayed out

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6288856_1700766588471.Recording__1401.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b1b3071c11ee0d1c
• Upwork Job ID: 1727789932415844352
• Last Price Increase: 2023-11-23
• Automatic offers:
• s77rt | Reviewer | 27867123
• dukenv0307 | Contributor | 27867124

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

📣 @github-actions[bot]! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot]

Triggered auto assignment to @luacmartins (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[luacmartins]

Investigating. Might be intended.

[luacmartins]

Ok, I don't think this is intended because we can still split bill with anon users from the global create

[luacmartins]

This issue also happens in prod. Not a blocker. I think this PR introduced the issue because we filter participants without a login here so the participant list is empty

[luacmartins]

Reproducible on production:

prod.mov

[luacmartins]

cc @lukemorawski @puneetlath @allroundexperts

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b1b3071c11ee0d1c

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

User is not able to create IOU with "Hidden" users, Split button is grayed out

What is the root cause of that problem?

In here, we're filtering participant without login or text from the IOU confirmation list.

What changes do you think we should make in order to solve the problem?

Remove that condition. I think there's no need for it because as long as the participants have accountId, we can split bill with them.

Or can update to

.filter((participant) => !!participant.accountID || !!participant.text)

to check for accountID instead of login

What alternative solutions did you explore? (Optional)

If we don't want to allow splitting bill with Hidden users, we should hide the Split bill option in a group where aside from current user, all other users are Hidden users

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Unable to create IOU with "Hidden" users

What is the root cause of that problem?

We don't allow users to create requests or split bills with hidden user. Note that, when clicking request money in FAB and going to the participant page, we also don't display hidden user in the suggestion list

What changes do you think we should make in order to solve the problem?

I think in DM chat with hidden user or in group chat with hidden users, we should hide the request/send/split bill button when clicking + button.
In here

App/src/libs/ReportUtils.js

Lines 3868 to 3879 in a2fc32b

	if ((isChatRoom(report) && otherParticipants.length > 0) || (isDM(report) && hasMultipleOtherParticipants) || (isPolicyExpenseChat(report) && report.isOwnPolicyExpenseChat)) {
	options = [CONST.IOU.TYPE.SPLIT];
	}
	if (canRequestMoney(report, otherParticipants)) {
	options = [...options, CONST.IOU.TYPE.REQUEST];
	}
	// Send money option should be visible only in 1:1 DMs
	if (isDM(report) && hasSingleOtherParticipantInReport) {
	options = [...options, CONST.IOU.TYPE.SEND];
	}

We should get the personal details of all otherParticipants and add conditions to make sure that we only show request/send/split bill button if personal detail of all otherParticipants include a login field (It mean that this user is not hidden user)

What alternative solutions did you explore? (Optional)

[s77rt]

@DylanDylann Thanks for the proposal. I think in the FAB flow those hidden users are not something that you'd be usually looking for thus not in the list (it's actually a feature since those users are hidden you should not be able to search for them). But for the DM I'd expect the functionality to work as I don't see a reason to disable it.

[s77rt]

Not overdue. Still waiting for a clarification on #27547 (comment)

[s77rt]

Got a clarification on the above ^ We can remove the filter as it was only done to avoid a bug that no longer exists.

🎀 👀 🎀 C+ reviewed
Link to proposal

[melvin-bot]

Current assignee @luacmartins is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

📣 @s77rt 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[luacmartins]

Proposal looks good. Let's get this fixed!

[melvin-bot]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[dukenv0307]

@s77rt The PR is ready for review.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.7-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Allow split bill for hidden user #32166

If no regressions arise, payment will be issued on 2023-12-12. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment offer (Reviewer)
• @dukenv0307 requires payment offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s77rt] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[s77rt]

• The PR that introduced the bug has been identified: Update LHN/chat header to handle displayName not being set #27547
• The offending PR has been commented on: Update LHN/chat header to handle displayName not being set #27547 (comment)
• A discussion in #expensify-bugs has been started: Not needed
• Determine if we should create a regression test for this bug: Yes

---

Regression Test Proposal

1. Start a chat with a user you have not chatted with before
2. Verify the user's display name is "Hidden"
3. Start money request flow (press the + grey button)
4. Verify you were able to complete the money request

[zanyrenney]

payment summary

no bug finder - applause
@s77rt requires payment offer (Reviewer) - paid $500
@dukenv0307 requires payment offer (Contributor) - paid $500

[zanyrenney]

regression test can be worked on separately, all payments complete - closing!