[HOLD for payment 2024-04-05] [$250] [TS migration] Migrate 'MiddlewareTest.js' test to TypeScript

[melvin-bot]

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path	Dependencies
tests/unit/MiddlewareTest.js	9

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01367c2848f1bd0806
• Upwork Job ID: 1767570779078500352
• Last Price Increase: 2024-04-05

[melvin-bot]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[ruben-rebelo]

I am Ruben Rebelo from Callstack - expert contributor group. I’d like to work on this job.

[melvin-bot]

Triggered auto assignment to @nkuoch, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01367c2848f1bd0806

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

[ghost]

Dibs

[aneequeahmad]

I have no TS issue assigned i can take this up

[serhii1030]

I hope to work on this issue.

[melvin-bot]

📣 @KMichel1030! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[holmesjr]

Contributor details
Your Expensify account email: james@bifrost.com.au
Upwork Profile Link: https://www.upwork.com/freelancers/~017244e35ab7ee3276

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[holmesjr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The test in question needs to be migrated to TS.

What is the root cause of that problem?

It was written in JS

What changes do you think we should make in order to solve the problem?

Add any necessary types and ensure the test follows the TS style-guide.

What alternative solutions did you explore? (Optional)

There isn't much else to this.

[melvin-bot]

@nkuoch, @ntdiary, @ruben-rebelo Whoops! This issue is 2 days overdue. Let's get this updated quick!

[ntdiary]

@nkuoch, @ntdiary, @ruben-rebelo Whoops! This issue is 2 days overdue. Let's get this updated quick!

We already have a nearly completed PR. :)

[holmesjr]

So all this "add a proposal" stuff is a lie?

[melvin-bot]

Triggered auto assignment to @slafortune (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA][TS migration] Migrate multiple unit and Performance test to Typescript #37685

If no regressions arise, payment will be issued on 2024-04-05. 🎊

For reference, here are some details about the assignees on this issue:

• @ntdiary requires payment (Needs manual offer from BZ)
• @ruben-rebelo does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ntdiary] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[ntdiary]

• @ntdiary requires payment (Needs manual offer from BZ)
• @ruben-rebelo does not require payment (Contractor)

Note: no need to pay me here, as I didn't review the PR.

So all this "add a proposal" stuff is a lie?

For this TS migration issue, the author of that PR is the first person to leave a comment, and they come from our expert contribution group. :)

[hungvu193]

I'm the C+ of that PR, so I think I'm eligible for payment here.

[slafortune]

@hungvu193 offer sent here - https://www.upwork.com/nx/wm/offer/101748110

[hungvu193]

@hungvu193 offer sent here - https://www.upwork.com/nx/wm/offer/101748110

Thank you. I've accepted, I saw the offer is 500$, it should be 250$

[slafortune]

Ah! I meant to update that - thanks for calling it out!

[slafortune]

Paid

[melvin-bot]

Upwork job price has been updated to $250