[HOLD for payment 2024-02-05] [$500] Workspace avatar not reverted to default when deleting workspace offline

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.5-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Open the app
2. Disable internet connection
3. Create a workspace
4. Upload an avatar for workspace
5. Navigate to #admins room
6. Tap the header > workspace header
7. Delete the workspace
8. Navigate to #admins room

Expected Result:

Admin room avatar is reverted to the default one

Actual Result:

Admin room avatar is not reverted to default, it is still a custom one

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6294748_1701272122743.video_2023-11-29_09-52-45.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0194502a9c1a9e4e7e
• Upwork Job ID: 1729899324299497472
• Last Price Increase: 2023-11-29
• Automatic offers:
• getusha | Reviewer | 27987317
• FitseTLT | Contributor | 27987320

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0194502a9c1a9e4e7e

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace avatar not reverted to default when deleting workspace offline

What is the root cause of that problem?

We are not resetting the workspace avatar in onyx optimisticData here

App/src/libs/actions/Policy.js

Lines 146 to 156 in 70813db

	function deleteWorkspace(policyID, reports, policyName) {
	const filteredPolicies = filter(allPolicies, (policy) => policy.id !== policyID);
	const optimisticData = [
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
	value: {
	pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE,
	errors: null,
	},
	},

What changes do you think we should make in order to solve the problem?

We need to reset the workspace avatar in optimisticData here

App/src/libs/actions/Policy.js

Lines 146 to 156 in 70813db

	function deleteWorkspace(policyID, reports, policyName) {
	const filteredPolicies = filter(allPolicies, (policy) => policy.id !== policyID);
	const optimisticData = [
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
	value: {
	pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE,
	errors: null,
	},
	},

change it to

function deleteWorkspace(policyID, reports, policyName) {
    const filteredPolicies = filter(allPolicies, (policy) => policy.id !== policyID);
    const optimisticData = [
        {
            onyxMethod: Onyx.METHOD.MERGE,
            key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
            value: {
                pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE,
                avatar: '',
                errors: null,
            },
        },

What alternative solutions did you explore? (Optional)

[yh-0218]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace avatar not reverted to default when deleting workspace offline

What is the root cause of that problem?

When we get workspace avatar, we didn't consider pendingAction here.

App/src/libs/ReportUtils.ts

Line 1213 in 61ed900

const policyExpenseChatAvatarSource = allPolicies?.[`${ONYXKEYS.COLLECTION.POLICY}${report?.policyID}`]?.avatar

What changes do you think we should make in order to solve the problem?

We need to consider pendingAction to get workspace avatar.

const policyExpenseChatAvatarSource = allPolicies?.[`${ONYXKEYS.COLLECTION.POLICY}${report?.policyID}`]?.avatar &&
    allPolicies?.[`${ONYXKEYS.COLLECTION.POLICY}${report?.policyID}`]?.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE
        ? allPolicies?.[`${ONYXKEYS.COLLECTION.POLICY}${report?.policyID}`]?.avatar
        : getDefaultWorkspaceAvatar(workspaceName);

What alternative solutions did you explore? (Optional)

[getusha]

@FitseTLT why do we need to remove other values from

App/src/libs/actions/Policy.js

Lines 209 to 214 in 70813db

	value: {
	stateNum,
	statusNum,
	hasDraft,
	oldPolicyName,
	},

and replace it with only avatar value? are you referring to adding the avatar or replacing the previous value with it.

[FitseTLT]

I am not replacing I am using onyx merge on policy to reset only `avatar` of the policy.

…

On Sun, 3 Dec 2023, 15:29 Getabalew Tesfaye, ***@***.***> wrote: @FitseTLT <https://github.com/FitseTLT> why do we need to remove other values from https://github.com/Expensify/App/blob/70813dbf3e2f73a73e52f880312bc198b39f4dec/src/libs/actions/Policy.js#L209-L214 and replace it with only avatar value? are you referring to adding the avatar or replacing the previous value with it. — Reply to this email directly, view it on GitHub <#32195 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJG4AZN5XNTAZPDEHEHC67TYHRWBNAVCNFSM6AAAAAA77YBMMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZXGQ3DMMRXGQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[FitseTLT]

@FitseTLT why do we need to remove other values from

App/src/libs/actions/Policy.js

Lines 209 to 214 in 70813db

	value: {
	stateNum,
	statusNum,
	hasDraft,
	oldPolicyName,
	},

and replace it with only avatar value? are you referring to adding the avatar or replacing the previous value with it.

@getusha I am using Onyx.METHOD.MERGE not Onyx.METHOD.SET so I am replacing only the value of the avatar (resetting it to '') of the policy 👍

[getusha]

Thanks for the proposal, @FitseTLT. I agree that we should reset the optimistic data. The proposal from @FitseTLT looks good to me and works well.

🎀 👀 🎀 C+ reviewed!

[melvin-bot]

Triggered auto assignment to @madmax330, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @getusha 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @FitseTLT 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[getusha]

@FitseTLT any update on the PR?

[FitseTLT]

Will make PR ready tomorrow.

[melvin-bot]

This issue has not been updated in over 15 days. @madmax330, @FitseTLT, @muttmuure, @getusha eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[getusha]

@madmax330 could you please check this? #32986 (comment)

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.32-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix workspace avatar issue on deletion #32986

If no regressions arise, payment will be issued on 2024-02-05. 🎊

For reference, here are some details about the assignees on this issue:

• @FitseTLT requires payment automatic offer (Contributor)
• @getusha requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@getusha] The PR that introduced the bug has been identified. Link to the PR:
• [@getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@getusha] Determine if we should create a regression test for this bug.
• [@getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@muttmuure] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[getusha]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@getusha] The PR that introduced the bug has been identified. Link to the PR: it is an edge case left unhandled.
[@getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/a
[@getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/a
[@getusha] Determine if we should create a regression test for this bug. a minor issue, i don't think it is worth including it in test rail.
[@getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

[muttmuure]

Thanks @getusha - handling

[muttmuure]

$500 - @getusha
$500 - @FitseTLT

[FitseTLT]

The previous Upwork offer is still open. @muttmuure Do you prefer me to accept the offer you sent me today?

[muttmuure]

Oh! For some reason I thought it was closed

[muttmuure]

Yep, seeing "this post is closed and is no longer accepting proposals."

[muttmuure]

Sorry it means I need to send out a new offer

[muttmuure]

Can you accept that one and I'll pay it?

[FitseTLT]

Accepted

[muttmuure]

I've been looking around and I can see that I could have paid you through the "All Contracts" page - I'll know for next time!

[muttmuure]

@getusha I've invited you to a payment issue

[getusha]

@muttmuure accepted.

[muttmuure]

OK offer sent

[getusha]

@muttmuure accented the offer.

[muttmuure]

Paid