-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-02-05] [$500] Workspace avatar not reverted to default when deleting workspace offline #32195
Comments
Triggered auto assignment to @muttmuure ( |
Job added to Upwork: https://www.upwork.com/jobs/~0194502a9c1a9e4e7e |
Bug0 Triage Checklist (Main S/O)
|
Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Workspace avatar not reverted to default when deleting workspace offline What is the root cause of that problem?We are not resetting the workspace avatar in onyx App/src/libs/actions/Policy.js Lines 146 to 156 in 70813db
What changes do you think we should make in order to solve the problem?We need to reset the workspace avatar in App/src/libs/actions/Policy.js Lines 146 to 156 in 70813db
change it to
What alternative solutions did you explore? (Optional) |
ProposalPlease re-state the problem that we are trying to solve in this issue.Workspace avatar not reverted to default when deleting workspace offline What is the root cause of that problem?When we get workspace avatar, we didn't consider Line 1213 in 61ed900
What changes do you think we should make in order to solve the problem?We need to consider
What alternative solutions did you explore? (Optional) |
@FitseTLT why do we need to remove other values from App/src/libs/actions/Policy.js Lines 209 to 214 in 70813db
and replace it with only avatar value? are you referring to adding the avatar or replacing the previous value with it. |
I am not replacing I am using onyx merge on policy to reset only `avatar`
of the policy.
…On Sun, 3 Dec 2023, 15:29 Getabalew Tesfaye, ***@***.***> wrote:
@FitseTLT <https://github.com/FitseTLT> why do we need to remove other
values from
https://github.com/Expensify/App/blob/70813dbf3e2f73a73e52f880312bc198b39f4dec/src/libs/actions/Policy.js#L209-L214
and replace it with only avatar value? are you referring to adding the
avatar or replacing the previous value with it.
—
Reply to this email directly, view it on GitHub
<#32195 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJG4AZN5XNTAZPDEHEHC67TYHRWBNAVCNFSM6AAAAAA77YBMMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZXGQ3DMMRXGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@getusha I am using |
Triggered auto assignment to @madmax330, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
📣 @getusha 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
📣 @FitseTLT 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
@FitseTLT any update on the PR? |
Will make PR ready tomorrow. |
This issue has not been updated in over 15 days. @madmax330, @FitseTLT, @muttmuure, @getusha eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
@madmax330 could you please check this? #32986 (comment) |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.32-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-02-05. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: [@getusha] The PR that introduced the bug has been identified. Link to the PR: it is an edge case left unhandled. |
Thanks @getusha - handling |
The previous Upwork offer is still open. @muttmuure Do you prefer me to accept the offer you sent me today? |
Oh! For some reason I thought it was closed |
Yep, seeing "this post is closed and is no longer accepting proposals." |
Sorry it means I need to send out a new offer |
Can you accept that one and I'll pay it? |
Accepted |
I've been looking around and I can see that I could have paid you through the "All Contracts" page - I'll know for next time! |
@getusha I've invited you to a payment issue |
@muttmuure accepted. |
OK offer sent |
@muttmuure accented the offer. |
Paid |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.5-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Expected Result:
Admin room avatar is reverted to the default one
Actual Result:
Admin room avatar is not reverted to default, it is still a custom one
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6294748_1701272122743.video_2023-11-29_09-52-45.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: