[$500] iOS - Profile - Photo upload options are missing

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.6.1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Navigate to https://staging.new.expensify.com/
2. Log in
3. Tap on your profile picture
4. Tap on your profile picture again
5. Tap on the "Upload photo" button

Expected Result:

"Browse" option should be added so I can choose a photo from iCloud drive or from the iPhone internal storage

Actual Result:

Profile photo upload options are missing. Currently I can take a photo or choose one from the gallery

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6296580_1701377818506.OTFS0573.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01cb01e156c8ab43dd
• Upwork Job ID: 1730337464884461568
• Last Price Increase: 2023-12-21
• Automatic offers:
• dukenv0307 | Contributor | 28118868
• DylanDylann | Contributor | 28128145

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01cb01e156c8ab43dd

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

iOS - Profile - Photo upload options are missing

What is the root cause of that problem?

We disable the chooseDocument option whenever the type passed to AttachmentPicker is an image.

What changes do you think we should make in order to solve the problem?

I think we can remove the prop type={CONST.ATTACHMENT_PICKER_TYPE.IMAGE} passed to AttachmentPicker since we validate the file type on upload.

Result

choose_document_option.mp4

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

iOS - Profile - Photo upload options are missing

What is the root cause of that problem?

This happens as we remove the browse option when we are choosing an image in [AttachmentPicker/index.native.js]:

App/src/components/AttachmentPicker/index.native.js

Lines 184 to 188 in 4fc20d3

	type !== CONST.ATTACHMENT_PICKER_TYPE.IMAGE && {
	icon: Expensicons.Paperclip,
	textTranslationKey: 'attachmentPicker.chooseDocument',
	pickAttachment: showDocumentPicker,
	},

What changes do you think we should make in order to solve the problem?

We should remove this check from the code. This allows the user to choose an image from a path they remember in the interal storage or iCloud drive.

Result

Screen.Recording.2023-12-01.at.3.16.30.AM.mov

What alternative solutions did you explore? (Optional)

We can rename the option to Choose File as this better align the purpose of this option.

This involves adding a translation key here:

App/src/languages/en.ts

Line 287 in 4fc20d3

attachmentPicker: {

        chooseFile: 'Choose file',

Result

Screen.Recording.2023-12-01.at.3.16.30.AM.mov

[neonbhai]

Proposal

Updated

Added detailed links to where the problem is. With Alternative step to rename the option. Screencast showing how alt step will look like.

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Profile photo upload options are missing. Currently I can take a photo or choose one from the gallery

What is the root cause of that problem?

In here, we allow the "Choose document" options only if the picker type is not CONST.ATTACHMENT_PICKER_TYPE.IMAGE. This is not correct because it's normal that the user can select images from file, just that we should restrict the type of files they can pick instead of allowing all by the RNDocumentPicker.types.allFiles option here.

What changes do you think we should make in order to solve the problem?

1. Make this a getDocumentPickerOptions which will accept the picker type, if the picker type is IMAGE, we should only allow the type RNDocumentPicker.types.images, otherwise allow type RNDocumentPicker.types.allFiles.
2. In here, use getDocumentPickerOptions(type) to get the correct document picker options based on the picker type
3. Remove the condition type !== CONST.ATTACHMENT_PICKER_TYPE.IMAGE here since we should allow the Choose from file option, we already restrict the file type in the steps above
4. We can consider rename the copy of the button from "Choose document" to something like "Choose from files" since it "document" is a bit vague and can mislead the user.

What alternative solutions did you explore? (Optional)

NA

[Santhosh-Sellavel]

@alexpensify This is a improvement not a bug, Can you confirm this internally, whether this is something we should fix or not, thanks!

[alexpensify]

Thanks! I'll start a discussion on Monday.

[alexpensify]

I've asked here:

https://expensify.slack.com/archives/C01GTK53T8Q/p1701726386650909

[alexpensify]

I've bumped the 🧵 and there is feedback that it might be a dupe.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[alexpensify]

I've asked for some more feedback in another Slack channel.

[alexpensify]

Still waiting for more feedback

[alexpensify]

No update, I've asked again for more feedback.

[melvin-bot]

@alexpensify @Santhosh-Sellavel this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

Current assignee @alexpensify is eligible for the Bug assigner, not assigning anyone new.

[melvin-bot]

Current assignee @Santhosh-Sellavel is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[alexpensify]

Awesome, we are moving forward here.

[Santhosh-Sellavel]

@alexpensify
PR is ready for review

I'm unavailable next week, so unassigning here please assign a new C+ here to move this forward

[DylanDylann]

I can review PR as C+

[srikarparsi]

Sounds good, assigning you to this and the PR @DylanDylann

[DylanDylann]

@srikarparsi Could you help to assign me to this issue again ?

[melvin-bot]

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[alexpensify]

@dukenv0307 any update to address the PR feedback? Thanks!

[alexpensify]

PR is moving forward but looks like there is an inquiry that needs to be addressed.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[parasharrajat]

FYI, there was a regression from this issue's PR #37240

[alexpensify]

Thanks for flagging, it looks like the PR was handled in the other GH.

[alexpensify]

Automation didn't kick in here, I think the 7-day mark is tomorrow.

[alexpensify]

Here is the payment summary:

• External issue reporter - n/a
• Contributor that fixed the issue - @dukenv0307 $500
• Contributor+ that helped on the issue and/or PR - @DylanDylann - $250

Upwork Job: https://www.upwork.com/jobs/~01cb01e156c8ab43dd

Extra Notes regarding payment: @DylanDylann - there is regression here but I mixed up the payments. I still input the $500 amount, instead of $250. This was my mistake and we will leave the amount paid as is.

Everyone has been paid via Upwork, so I'm closing.