Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[payment due 2023-12-13] [$500] Remove sideloading of Onyx data for avatar with display name #32309

Closed
Tracked by #27262
tgolen opened this issue Nov 30, 2023 · 16 comments
Closed
Tracked by #27262

[payment due 2023-12-13] [$500] Remove sideloading of Onyx data for avatar with display name #32309

tgolen opened this issue Nov 30, 2023 · 16 comments
Assignees
@tgolen @cubuspl42 @joekaufmanexpensify
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2

Comments

@tgolen
Copy link
Contributor

tgolen commented Nov 30, 2023 •
edited by melvin-bot bot
Loading

Coming from #27262

Problem

These methods are anti-patterns because they are most always used for loading data into a component without using withOnyx(). This breaks the data flow of a react application. (data is coming from somewhere that is not props or state and cannot be debugged in react dev tools).

Solution

Switch all references to properly use withOnyx() for components and connect() for libs.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c108d0b3568a69c3
  • Upwork Job ID: 1730343269382967296
  • Last Price Increase: 2023-11-30
@tgolen tgolen mentioned this issue Nov 30, 2023
Closed
25 tasks
@tgolen tgolen changed the title AvatarWithDisplayName @tgolen Remove sideloading of Onyx data for avatar with display name Nov 30, 2023
@tgolen tgolen mentioned this issue Nov 30, 2023
Merged
47 tasks
@tgolen tgolen self-assigned this Nov 30, 2023
@tgolen tgolen added Engineering Bug Something is broken. Auto assigns a BugZero manager. labels Nov 30, 2023
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Nov 30, 2023

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label Nov 30, 2023
@melvin-bot Melvin Bot

This comment was marked as off-topic.

Sign in to view
@tgolen tgolen added the External Added to denote the issue can be worked on by a contributor label Nov 30, 2023
@melvin-bot melvin-bot bot changed the title Remove sideloading of Onyx data for avatar with display name [$500] Remove sideloading of Onyx data for avatar with display name Nov 30, 2023
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Nov 30, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01c108d0b3568a69c3

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 30, 2023
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Nov 30, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

@tgolen tgolen removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 30, 2023
@tgolen
Copy link
Contributor Author

tgolen commented Nov 30, 2023

@cubuspl42 Could you please review the PR I wrote for this? #32304

@joekaufmanexpensify I will only need your help with payment once this is deployed.

@joekaufmanexpensify
Copy link
Contributor

Sounds good!

@joekaufmanexpensify
Copy link
Contributor

PR is in review.

@joekaufmanexpensify joekaufmanexpensify added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Dec 1, 2023
@cubuspl42
Copy link
Contributor

PR merged

@joekaufmanexpensify
Copy link
Contributor

Awesome. We'll issue payment 7 days after the PR reaches production (assuming no regressions)

@joekaufmanexpensify
Copy link
Contributor

PR went to prod on 2023-12-06, so payment due on 2023-12-13 (assuming no regressions)

@joekaufmanexpensify joekaufmanexpensify changed the title [$500] Remove sideloading of Onyx data for avatar with display name [payment due 2023-12-13] [$500] Remove sideloading of Onyx data for avatar with display name Dec 11, 2023
@joekaufmanexpensify
Copy link
Contributor

@cubuspl42 offer sent for $500!

@cubuspl42
Copy link
Contributor

@joekaufmanexpensify Thanks, accepted

@joekaufmanexpensify
Copy link
Contributor

All set to issue payment.

@joekaufmanexpensify
Copy link
Contributor

@cubuspl42 $500 sent and contract ended!

@joekaufmanexpensify
Copy link
Contributor

Upwork job closed.

@joekaufmanexpensify
Copy link
Contributor

Closing as this is all set!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tgolen tgolen

@cubuspl42 cubuspl42

@joekaufmanexpensify joekaufmanexpensify

Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tgolen @cubuspl42 @joekaufmanexpensify