Remove ReportActionsUtils.getParentReportAction(), ReportUtils.getParentReport(), TransactionUtils.getLinkedTransaction(), ReportUtils.getPolicy(), and TransactionUtils.getTransaction()

[tgolen]

Problem

These methods are anti-patterns because they are most always used for loading data into a component without using withOnyx(). This breaks the data flow of a react application. (data is coming from somewhere that is not props or state and cannot be debugged in react dev tools).

Solution

Switch all references to properly use withOnyx() for components and connect() for libs.

Components

• MoneyRequestHeader @tgolen Refactor how data is loaded into the edit request page #28645
• OptionRowLHNData @tgolen Refactor OptionRowLHNData to remove deprecated getLinkedTransaction() method #35975
• EditRequestPage @tgolen
• SplitBillDetailsPage
• extractAttachmentsFromReport @tgolen Remove sideloading of Onyx data for attachment modal #30866
• [payment due 2023-12-13] [$500] Remove sideloading of Onyx data for avatar with display name #32309
• [HOLD for payment 2023-12-18] Remove sideloading of Onyx data forMoneyRequestView.js #32443
• FlagCommentPage @tgolen Remove deprecated methods and refactor code to be a little cleaner #33676
• ReportScreen @tgolen Load parent report action from withOnyx in ReportScreen #33970
• ReportActionItem @tgolen Load parent report action from withOnyx in ReportActionItem #34057
• ReportActionList No longer references deprecated methods
• withReportAndReportActionOrNotFound @tgolen Load parent report action from withOnyx in report action HOC #34113
• ComposerWithSuggestions @tgolen already removed\
• MoneyRequestView @tgolen [NO QA] Remove use of deprecated function when showing violations on a transaction #37703
• HeaderView @tgolen Refactor HeaderView to access parentReportAction from props #37913
• ReportActionsListItemRenderer @tgolen Remove deprecated method and pass down parentReportAction #37449
• FlagCommentPage getParentReport() @tgolen Refactor FlagCommentPage to access parent report directly from Onyx #38356
• [PAID] [$500] Update getIOUReportActionDisplayMessage() to accept the transaction as a parameter #38355
• [PAY 29/04] [$250] Remove deprecated ReportActionUtils.getAllReportActions() method #39091
• [HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] [$500] Remove exported ReportUtils.getReport() #40316

Libs

• IOU already removed
• Task @tgolen Remove the side-loading of data in Task action from the ReportActionUtils #37340
• TransactionUtils @tgolen Remove deprecated methods from transaction utils that sideload data from Onyx #38258
• ReportUtils
• [HOLD for payment 2024-04-15] [$250] Remove deprecated ReportUtils.getPolicy() method #38959

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0156f7187832f56740
• Upwork Job ID: 1762552955483959296
• Last Price Increase: 2024-02-27

[techievivek]

Adding @aimane-chnaif to the GH as he helped review the PR: https://expensify.slack.com/archives/C02NK2DQWUX/p1694749699352029

[tgolen]

I'm slowly working my way through these, but I wasn't able to get to any of them this week.

[tgolen]

I wrote a new PR for the next one on the list today.

[tgolen]

I haven't had time to do any additional work on this.

[tgolen]

Weekly Update

• I've fixed a couple more this week
• I've found even more bad methods ReportUtils.getPolicy() which I've added to the list
• I'm going to try a slightly different strategy of getting contributors to fix these

Next Steps

• Start creating contributor issues to clean up the rest of this

ETA

• No change

[tgolen]

Weekly Update

• I have been created contributor issues to handle the remaining items and they are moving forward

Next Steps

• Do a final cleanup of ReportUtils once all the current issues are done

ETA

• All done by April 9

[tgolen]

Weekly Update

• There were three PRs created last week for most of the remaining items

Next Steps

• Once all PRs are merged, @tgolen take one last look at ReportUtils and make sure it is not exporting anything "bad", then this issue can be closed

ETA

• This is bleeding into next week due to slow PR reviews, so updated ETA is Wednesday, April 17.

[tgolen]

Weekly Update

• There is one final PR that is waiting to close out, then this can be closed.
• I haven't found any more bad instances

Next Steps

• Wait for this PR to be merged and then close this out

ETA

• It looks like it might be merged next week sometime.

[tgolen]

Weekly Update

• Same as last week

[tgolen]

Weekly Update

• I bumped the PR that is holding this up. The contributor hasn't updated it in a couple of weeks now.

[melvin-bot]

This issue has not been updated in over 15 days. @tgolen eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[tgolen]

ReportUtils is the only remaining item, but I took a look at it and I think it's mostly fine for now so I am going to close this out.