[HOLD for payment 2024-01-03] [$500] Distance - Save button is unresponsive when adding, saving, then removing new point offline

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.7-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Issue found when executing PR #31340

Action Performed:

1. Go to staging.new.expensify.com
2. Create a distance request
3. Open distance request details page
4. Click Distance
5. Go offline
6. Add a new stop and save it
7. Click Distance again
8. Remove the new stop added in Step 5
9. Click Save

Expected Result:

The new distance will be saved

Actual Result:

Nothing happens when clicking on Save button

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6298236_1701490520825.20231202_023135.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e1d8e03c3ce30d53
• Upwork Job ID: 1730948270789206016
• Last Price Increase: 2023-12-09
• Automatic offers:
• dukenv0307 | Contributor | 28064597

Issue Owner

Current Issue Owner: @robertKozik

[melvin-bot]

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e1d8e03c3ce30d53

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik (External)

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Save button is unresponsive when adding, saving, then removing new point offline

What is the root cause of that problem?

When we change the waypoint the first time, isLoading is set as true here.

App/src/libs/actions/IOU.js

Line 750 in 1682be4

isLoading: _.has(transactionChanges, 'waypoints'),

And we do nothing here if isLoading is true

App/src/components/DistanceRequest/index.js

Line 181 in 1682be4

if (_.size(validatedWaypoints) < 2 || hasRouteError || isLoadingRoute || isLoading) {

What changes do you think we should make in order to solve the problem?

We can allow saving waypoint if we are offline even isLoading is true

What alternative solutions did you explore? (Optional)

We can disable edit address and save waypoint if isLoading is true

[rakshitjain13]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance - Save button is unresponsive when adding, saving, then removing new point offline

What is the root cause of that problem?

On first request in offline mode like saving, deleting, or editing the request, we change isLoading to true here

App/src/libs/actions/IOU.js

Line 750 in 1682be4

isLoading: _.has(transactionChanges, 'waypoints'),

and on the next request

App/src/components/DistanceRequest/index.js

Line 181 in 1682be4

if (_.size(validatedWaypoints) < 2 || hasRouteError || isLoadingRoute || isLoading) {

we are unable to proceed because of above .

What changes do you think we should make in order to solve the problem?

We have to skip checking isLoading in offline mode

  if (_.size(validatedWaypoints) < 2 || hasRouteError || isLoadingRoute || (isLoading && !isOffline)) {
            setHasError(true);
            return;
        }

What alternative solutions did you explore? (Optional)

[melvin-bot]

📣 @VenusWhisperer! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance - Save button is unresponsive when adding, saving, then removing new point offline

What is the root cause of that problem?

When editing distance request the first time, isLoading field will be true
Let's see

App/src/components/DistanceRequest/index.js

Lines 179 to 186 in 1682be4

	const submitWaypoints = useCallback(() => {
	// If there is any error or loading state, don't let user go to next page.
	if (_.size(validatedWaypoints) < 2 || hasRouteError || isLoadingRoute || isLoading) {
	setHasError(true);
	return;
	}
	onSubmit(waypoints);
	}, [onSubmit, setHasError, hasRouteError, isLoadingRoute, isLoading, validatedWaypoints, waypoints]);

If isLoading is true we do nothing when clicking the save button.

What changes do you think we should make in order to solve the problem?

1. We should remove isLoading condition here
   

   App/src/components/DistanceRequest/index.js

   Line 181 in 1682be4

   if (_.size(validatedWaypoints) < 2 || hasRouteError || isLoadingRoute || isLoading) {

2. One more thing, if we don't allow the user clicking the save button we should disable it to avoid confusion to user
   We can create new variable

const isDisableButton = _.size(validatedWaypoints) < 2 || hasRouteError || isLoadingRoute

use it in here

App/src/components/DistanceRequest/index.js

Line 181 in 1682be4

if (_.size(validatedWaypoints) < 2 || hasRouteError || isLoadingRoute || isLoading) {

and add isDisabled props like this isDisabled={isDisableButton} in save button

What alternative solutions did you explore? (Optional)

[sophiepintoraetz]

Hey @robertKozik - are you able to review these proposals?

[melvin-bot]

@sophiepintoraetz, @robertKozik Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[sophiepintoraetz]

@allroundexperts is jumping in! 🙏

[allroundexperts]

Thanks for the proposals everyone. All the proposals have the same RCA.

@DylanDylann I think the idea was to never disable the save button in offline mode as can be seen clearly here.

I like the solution proposed by @dukenv0307 since it is inline with how we're handling the disabling of button here.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @flodnv, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[neil-marcellini]

Oh just seeing this now. I'll review today.

[melvin-bot]

@neil-marcellini @allroundexperts @sophiepintoraetz this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[neil-marcellini]

I like the solution proposed by @dukenv0307 since it is inline with how we're handling the disabling of button here.

🎀 👀 🎀 C+ reviewed

I agree, hiring!

[melvin-bot]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[dukenv0307]

@allroundexperts The PR is ready for review.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.17-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Accept save distance when editing in offline mode #33266

If no regressions arise, payment will be issued on 2024-01-03. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @allroundexperts requires payment through NewDot Manual Requests
• @dukenv0307 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sophiepintoraetz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sophiepintoraetz]

@dukenv0307 has been paid.
@allroundexperts - feel free to raise a request once you have filled out the checklist.

[allroundexperts]

Checklist

1. feat: enable next button #29125
2. https://github.com/Expensify/App/pull/29125/files#r1444065369
3. N/A
4. A regression test would be helpful here.

Regression Test

1. Open the App and request money using distance request
2. On distance request details page, click Distance and then go offline
3. Add a new stop and save it
4. Click Distance again
5. Remove the new stop added previously
6. Verify that clicking save leads to the new distance being saved

Do we 👍 or 👎 ?

[sophiepintoraetz]

Payment summary - $500 to @allroundexperts

[JmillsExpensify]

$500 approved for @allroundexperts based on comment above.