-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$500] Android - Distance - Tabs switch highlight between Manual and Distance when map is rendering #32554
Comments
Triggered auto assignment to @conorpendergrast ( |
Job added to Upwork: https://www.upwork.com/jobs/~015ce5c4e833c5e836 |
Bug0 Triage Checklist (Main S/O)
|
Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts ( |
ProposalPlease re-state the problem that we are trying to solve in this issueWhen opening Request Money on Distance tab, the tabs switch highlight between Distance and Manual while the map is rendering. What is the root cause of that problem?The cause of this issue is the fact that Because the same What changes do you think we should make in order to solve the problem?Wrap Changed code- export default TabSelector;
+ export default memo(TabSelector, (prevProps, nextProps) =>
+ _.isEqual(prevProps.state, nextProps.state),
+ ); VideosAndroid: NativeScreen.Recording.2023-12-06.at.19.04.22.mov |
I think @ikevin127 has the correct RCA and the solution proposed seems fine as well. As a suggestion, I think it would be better to memoize the Let's go with @ikevin127's proposal. 🎀 👀 🎀 C+ reviewed |
Triggered auto assignment to @Julesssss, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
Not able to reproduce after refactor |
Just pulled the latest code and retested. This seems to be fixed! Let's close this. |
I agree, the old code related to this issue was prone to future issues. The refactor did it justice! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v1.4.8-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @
Action Performed:
Precondition:
Expected Result:
Only the distance tab is highlighted.
Actual Result:
The tabs switch highlight from Manual to Distance when the map is rendering.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Bug6302707_1701837650563.Screen_Recording_20231206_034613_New_Expensify.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: