[$500] Web - Errors appear in the JS console when requesting money or assigning a task #32605

lanitochka17 · 2023-12-07T01:09:55Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.9-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #29157

Action Performed:

Navigate to staging.new.expensify.com and log in
Create a money request > check JS console
Create an assigned task > check JS console

Expected Result:

No errors appear in JS console

Actual Result:

Errors appear in JS console when requesting money or assigning a task

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~014f402f86bef1bf3e
Upwork Job ID: 1732568096774332416
Last Price Increase: 2024-03-16

melvin-bot · 2023-12-07T01:10:00Z

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-12-07T01:10:00Z

Job added to Upwork: https://www.upwork.com/jobs/~014f402f86bef1bf3e

melvin-bot · 2023-12-07T01:10:02Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

melvin-bot · 2023-12-07T01:10:05Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

situchan · 2023-12-07T01:16:09Z

@lanitochka17 can you please share console log?

OleksandrYakuba · 2023-12-07T01:23:49Z

Hello @lanitochka17
Sorry to hear that JS console errors appear.
May I see the console log?

melvin-bot · 2023-12-07T01:23:54Z

📣 @OleksandrYakuba! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Make sure you've read and understood the contributing guidelines.
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

OleksandrYakuba · 2023-12-07T01:32:32Z

Contributor details
Your Expensify account email: frank18gumbslb4@outlook.com
Upwork Profile Link: https://upwork.com/freelancers/~01f72d6e1a5222250a

melvin-bot · 2023-12-07T01:32:35Z

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

OleksandrYakuba · 2023-12-07T01:44:41Z

Contributor details
Your Expensify account email: frank18gumbslb4@outlook.com
Upwork Profile Link: https://upwork.com/freelancers/~01f72d6e1a5222250a

OleksandrYakuba · 2023-12-07T01:59:48Z

Make sure?

BhuvaneshPatil · 2023-12-07T02:30:27Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

For new task page
In dev I got this error (not sure if reporter is mentioning about the same)

App/src/pages/tasks/NewTaskPage.js

Line 198 in 3827a9c

    
           titleWithTooltips={!shareDestination.shouldUseFullTitleToDisplay && shareDestination.displayNamesWithTooltips}

if !shareDestination.shouldUseFullTitleToDisplay resolves to be false, we are passing false as prop.

I couldn't repro the error on Money request

What changes do you think we should make in order to solve the problem?

For new task page
change the line to -
titleWithTooltips={!shareDestination.shouldUseFullTitleToDisplay ? shareDestination.displayNamesWithTooltips : []},
hence we will be passing empty array, this respects the prop type.

What alternative solutions did you explore? (Optional)

OleksandrYakuba · 2023-12-07T03:01:22Z

@BhuvaneshPatil
I think your suggestion is correct.
Prop type of MenuItem is defined array[], so it is correct to pass empty array as titleWithTooltips.
I tested your suggestion with vanilla JS.

OleksandrYakuba · 2023-12-07T04:00:07Z

Otherwise, prop type of MenuItem's titleWithTooltips can be defined as following.

current:
titleWithTooltips : []

change:

titleWithTooltips : PropTypes.oneOfType([
    PropTypes.bool,
    PropTypes.array
]),

OleksandrYakuba · 2023-12-07T04:06:56Z

waiting for response

laurenreidexpensify · 2023-12-11T09:32:02Z

@situchan can you review? Thanks

situchan · 2023-12-11T10:59:52Z

@laurenreidexpensify I asked here but if no answer, I will go ahead with console error I measured

lanitochka17 · 2023-12-12T22:00:43Z

Sorry for delay

Bug6303814_1701907014279.JS_console_error_when_requesting_money_or_assign_task.mp4

logs.txt

OleksandrYakuba · 2023-12-12T23:01:00Z

This is CORS error.
To solve the problem, it is needs to add 'Access-Control-Allow-Origin: *' header to server response.

OleksandrYakuba · 2023-12-13T02:20:54Z

I recommend CORS package for it.

BhuvaneshPatil · 2024-03-04T15:40:32Z

I checked the git blame, and it takes back to more than a year back. It happened(in some cases) because of migration to PressableWithoutFeedback where the accessibility Roles were added.
Don't know how it went un-caught for this long.

laurenreidexpensify · 2024-03-05T04:57:54Z

@BhuvaneshPatil can you link the PR pls thanks

BhuvaneshPatil · 2024-03-05T07:52:33Z

Sure @laurenreidexpensify

for referral CTA - 20354 money request participants selector list refactoring #32692
for base list item (Split button) - 20354 money request participants selector list refactoring #32692

BhuvaneshPatil · 2024-03-07T18:25:06Z

@situchan I have added the PR that caused this issue

situchan · 2024-03-07T23:49:30Z

@BhuvaneshPatil I see this console error when open the app. Not only ReferralProgramCTA, BaseListItem

what do you think of this console error?

BhuvaneshPatil · 2024-03-08T01:37:18Z

That error is for Pay with Expensify button (first message in the image).
The reason is - #32605 (comment)

melvin-bot · 2024-03-09T16:00:16Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot · 2024-03-11T19:08:44Z

@laurenreidexpensify, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

BhuvaneshPatil · 2024-03-12T17:05:44Z

^^ @situchan

melvin-bot · 2024-03-13T19:10:56Z

@laurenreidexpensify, @situchan Eep! 4 days overdue now. Issues have feelings too...

situchan · 2024-03-13T19:39:31Z

Thanks. I will provide feedback soon

mvtglobally · 2024-03-14T15:40:54Z

Issue not reproducible during KI retests. (Second week)

situchan · 2024-03-15T20:58:52Z

This is still reproducible

melvin-bot · 2024-03-16T16:00:18Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

mvtglobally · 2024-03-20T03:40:27Z

Issue not reproducible during KI retests. (Third week)

wildan-m · 2024-03-20T04:18:56Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Errors appear in the JS console when requesting money or assigning a task

What is the root cause of that problem?

In the Report Preview, we define the role of 'PressableWithoutFeedback' as a 'button' that wraps other buttons. This can cause issues with the HTML, especially when navigating with the keyboard or using assistive technology.

What changes do you think we should make in order to solve the problem?

We can rearrange the internal buttons so they are not contained within the pressable component.

Here is a example of restructuring without altering the style. Restructure this code as follows:

        <OfflineWithFeedback
            pendingAction={iouReport?.pendingFields?.preview}
            shouldDisableOpacity={!!(action.pendingAction ?? action.isOptimisticAction)}
            needsOffscreenAlphaCompositing
        >
            <View style={[styles.chatItemMessage, containerStyles]}>
                <View style={[styles.flexRow, styles.justifyContentBetween, styles.reportPreviewBox]}>
                    <View style={[styles.reportPreviewBox, isHovered || isScanning || isWhisper ? styles.reportPreviewBoxHoverBorder : undefined]}>

                        <PressableWithoutFeedback
                            onPress={() => {
                                Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(iouReportID));
                            }}
                            onPressIn={() => DeviceCapabilities.canUseTouchScreen() && ControlSelection.block()}
                            onPressOut={() => ControlSelection.unblock()}
                            onLongPress={(event) => showContextMenuForReport(event, contextMenuAnchor, chatReportID, action, checkIfContextMenuActive)}
                            shouldUseHapticsOnLongPress
                            role="button"
                            accessibilityLabel={translate('iou.viewDetails')}
                        >
                            {hasReceipts && (
                                <ReportActionItemImages
                                    images={lastThreeReceipts}
                                    total={transactionsWithReceipts.length}
                                    size={CONST.RECEIPT.MAX_REPORT_PREVIEW_RECEIPTS}
                                />
                            )}
                            <View style={[styles.expenseAndReportPreviewBoxBody, hasReceipts ? styles.mtn1 : {}]}>
                                <View style={styles.expenseAndReportPreviewTextButtonContainer}>
                                    <View style={styles.expenseAndReportPreviewTextContainer}>
                                        <View style={styles.flexRow}>
                                            <View style={[styles.flex1, styles.flexRow, styles.alignItemsCenter]}>
                                                <Text style={[styles.textLabelSupporting, styles.lh16]}>{getPreviewMessage()}</Text>
                                            </View>
                                            {shouldShowRBR && (
                                                <Icon
                                                    src={Expensicons.DotIndicator}
                                                    fill={theme.danger}
                                                />
                                            )}

                                            {!shouldShowRBR && shouldPromptUserToAddBankAccount && (
                                                <Icon
                                                    src={Expensicons.DotIndicator}
                                                    fill={theme.success}
                                                />
                                            )}
                                        </View>
                                        <View style={styles.reportPreviewAmountSubtitleContainer}>
                                            <View style={styles.flexRow}>
                                                <View style={[styles.flex1, styles.flexRow, styles.alignItemsCenter]}>
                                                    <Text style={styles.textHeadlineH1}>{getDisplayAmount()}</Text>
                                                    {ReportUtils.isSettled(iouReportID) && (
                                                        <View style={styles.defaultCheckmarkWrapper}>
                                                            <Icon
                                                                src={Expensicons.Checkmark}
                                                                fill={theme.iconSuccessFill}
                                                            />
                                                        </View>
                                                    )}
                                                </View>
                                            </View>
                                            {shouldShowSubtitle && (
                                                <View style={styles.flexRow}>
                                                    <View style={[styles.flex1, styles.flexRow, styles.alignItemsCenter]}>
                                                        <Text style={[styles.textLabelSupporting, styles.textNormal, styles.lh20]}>{previewSubtitle || moneyRequestComment}</Text>
                                                    </View>
                                                </View>
                                            )}
                                        </View>
                                    </View>
                                </View>
                            </View>
                        </PressableWithoutFeedback>
                        {(shouldShowSettlementButton || shouldShowSubmitButton) && <View style={[styles.ph4, styles.pb4]}>
                            {shouldShowSettlementButton && (
                                <SettlementButton
                                    currency={iouReport?.currency}
                                    policyID={policyID}
                                    chatReportID={chatReportID}
                                    iouReport={iouReport}
                                    onPress={(paymentType?: PaymentMethodType) => chatReport && iouReport && paymentType && IOU.payMoneyRequest(paymentType, chatReport, iouReport)}
                                    enablePaymentsRoute={ROUTES.ENABLE_PAYMENTS}
                                    addBankAccountRoute={bankAccountRoute}
                                    shouldHidePaymentOptions={!shouldShowPayButton}
                                    shouldShowApproveButton={shouldShowApproveButton}
                                    kycWallAnchorAlignment={{
                                        horizontal: CONST.MODAL.ANCHOR_ORIGIN_HORIZONTAL.LEFT,
                                        vertical: CONST.MODAL.ANCHOR_ORIGIN_VERTICAL.BOTTOM,
                                    }}
                                    paymentMethodDropdownAnchorAlignment={{
                                        horizontal: CONST.MODAL.ANCHOR_ORIGIN_HORIZONTAL.RIGHT,
                                        vertical: CONST.MODAL.ANCHOR_ORIGIN_VERTICAL.BOTTOM,
                                    }}
                                    isDisabled={!canAllowSettlement}
                                />
                            )}
                            {shouldShowSubmitButton && (
                                <Button
                                    medium
                                    success={isWaitingForSubmissionFromCurrentUser}
                                    text={translate('common.submit')}
                                    onPress={() => iouReport && IOU.submitReport(iouReport)}
                                />
                            )}
                        </View>
                        }
                    </View>
                </View>
            </View>
        </OfflineWithFeedback>

What alternative solutions did you explore? (Optional)

Completely remove role='button' from the pressable

laurenreidexpensify · 2024-03-21T11:10:06Z

No longer reproducible

wildan-m · 2024-03-21T11:59:27Z

@laurenreidexpensify @situchan Actually, the issue persists with the latest main in development, which is not shown in staging. It appears that some logging is intentionally suppressed in staging?

BhuvaneshPatil · 2024-03-21T17:18:04Z

Reproducible for me as well, We need to have Pay with Expensify button in order to view the error

situchan · 2024-03-22T15:17:35Z

There's more case:

situchan · 2024-03-22T15:18:06Z

Btw, I think we can keep this closed for now as only dev console error, not impacting production users.
We can reopen after wave is gone.

P.S. #35633 is more annoying console error on iOS but we closed it.

lanitochka17 added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 7, 2023

melvin-bot bot assigned laurenreidexpensify Dec 7, 2023

melvin-bot bot changed the title ~~Web - Errors appear in the JS console when requesting money or assigning a task~~ [$500] Web - Errors appear in the JS console when requesting money or assigning a task Dec 7, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 7, 2023

melvin-bot bot assigned situchan Dec 7, 2023

kavimuru mentioned this issue Dec 7, 2023

Deploy Checklist: New Expensify 2023-12-06 #32589

Closed

74 tasks

melvin-bot bot added the Overdue label Dec 11, 2023

melvin-bot bot removed the Overdue label Dec 11, 2023

melvin-bot bot added the Overdue label Mar 7, 2024

melvin-bot bot removed the Overdue label Mar 7, 2024

melvin-bot bot added the Overdue label Mar 11, 2024

melvin-bot bot removed the Overdue label Mar 13, 2024

melvin-bot bot added the Overdue label Mar 15, 2024

melvin-bot bot removed the Overdue label Mar 15, 2024

melvin-bot bot added Overdue and removed Overdue labels Mar 18, 2024

laurenreidexpensify closed this as completed Mar 21, 2024

[$500] Web - Errors appear in the JS console when requesting money or assigning a task #32605

[$500] Web - Errors appear in the JS console when requesting money or assigning a task #32605

Comments

lanitochka17 commented Dec 7, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Dec 7, 2023

melvin-bot bot commented Dec 7, 2023

melvin-bot bot commented Dec 7, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot bot commented Dec 7, 2023

situchan commented Dec 7, 2023

OleksandrYakuba commented Dec 7, 2023

melvin-bot bot commented Dec 7, 2023

OleksandrYakuba commented Dec 7, 2023

melvin-bot bot commented Dec 7, 2023

OleksandrYakuba commented Dec 7, 2023

OleksandrYakuba commented Dec 7, 2023

BhuvaneshPatil commented Dec 7, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

OleksandrYakuba commented Dec 7, 2023

OleksandrYakuba commented Dec 7, 2023 • edited Loading

OleksandrYakuba commented Dec 7, 2023

laurenreidexpensify commented Dec 11, 2023

situchan commented Dec 11, 2023

lanitochka17 commented Dec 12, 2023

OleksandrYakuba commented Dec 12, 2023

OleksandrYakuba commented Dec 13, 2023

BhuvaneshPatil commented Mar 4, 2024 • edited Loading

laurenreidexpensify commented Mar 5, 2024

BhuvaneshPatil commented Mar 5, 2024

BhuvaneshPatil commented Mar 7, 2024

situchan commented Mar 7, 2024

BhuvaneshPatil commented Mar 8, 2024

melvin-bot bot commented Mar 9, 2024

melvin-bot bot commented Mar 11, 2024

BhuvaneshPatil commented Mar 12, 2024

melvin-bot bot commented Mar 13, 2024

situchan commented Mar 13, 2024

mvtglobally commented Mar 14, 2024

situchan commented Mar 15, 2024

melvin-bot bot commented Mar 16, 2024

mvtglobally commented Mar 20, 2024

wildan-m commented Mar 20, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

laurenreidexpensify commented Mar 21, 2024

wildan-m commented Mar 21, 2024

BhuvaneshPatil commented Mar 21, 2024

situchan commented Mar 22, 2024

situchan commented Mar 22, 2024 • edited Loading

lanitochka17 commented Dec 7, 2023 •

edited by melvin-bot bot

Loading

OleksandrYakuba commented Dec 7, 2023 •

edited

Loading

BhuvaneshPatil commented Mar 4, 2024 •

edited

Loading

wildan-m commented Mar 20, 2024 •

edited

Loading

situchan commented Mar 22, 2024 •

edited

Loading