[HOLD for payment 2023-12-29] [$500] Desktop - Chat - Infinite loading displayed on selected chat when navigate to RHP with deeplink

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.13-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

Precondition: user should be Signed Out on Desktop

1. Open http://staging.new.expensify.com/
   in Web and select any conversation in LHN
2. Navigate on http://staging.new.expensify.com/enable-payments
3. Click on "Allow" to open the Desktop app
4. Click outside of the RHP to close it

Expected Result:

Previously selected chat should be loaded and properly displayed

Actual Result:

Infinite loading displayed on selected conversation when navigate to RHP with deeplink

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6313239_1702568224062.Screen_Recording_2023-12-14_at_14.36.05.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ae306e7095356be1
• Upwork Job ID: 1735616582656286720
• Last Price Increase: 2023-12-15
• Automatic offers:
• ikevin127 | Contributor | 28064493

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ae306e7095356be1

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

[ikevin127]

Proposal

Please re-state the problem that we are trying to solve in this issue

Infinite loading displayed on selected conversation when navigate to RHP with deeplink to desktop app.

Note: The issue happens as long as any RHP is opened and transition to desktop app is performed, it doesn't have to be https://staging.new.expensify.com/enable-payments, it can be settings https://staging.new.expensify.com/settings on any other route that has the RHP open.

Besides the current issue, there's another issue:

• once navigated to the desktop app and the infinite loading is seen (current issue)
• close the RHP by clicking outside of it
• open settings RHP (click on profile pic) and Logout

MacOS: Desktop - Logout issue

Screen.Recording.2023-12-15.at.14.36.16.mov

What is the root cause of that problem?

The reason why we get the infinite loading spinner once transitioned to the desktop app is because the app is calling navigate with transition route when not necesarry. Because the route is not handled by the react navigator, this causes the infinite loading spinner and the logout issue mentioned above.

What changes do you think we should make in order to solve the problem?

App/src/libs/actions/Report.ts

Line 2031 in 173582f

Navigation.navigate(route as Route, CONST.NAVIGATION.ACTION_TYPE.PUSH);

We have to make sure that the transition route passed from the main electron process is NOT called by the navigator once we are transitioned into the desktop app, we check if the following conditions are true:

• the platform is desktop
• route is transition type

then we return meaning we don't call the react navigation with the transition route which would cause the infinite loading spinner.

...

                // If the platform is desktop and route is `transition` we don't want to call navigate
                // to the route because it will display the infinite loading indicator.
                // See issue: https://github.com/Expensify/App/issues/33149
+               if (getPlatform() === CONST.PLATFORM.DESKTOP && route.includes(ROUTES.TRANSITION_BETWEEN_APPS) {
+                   return;
+               }

             Navigation.navigate(route, CONST.NAVIGATION.TYPE.PUSH);

Videos

MacOS: Desktop

stg-fix.mov

[narefyev91]

Proposal from @ikevin127 looks good to me #33149 (comment)
🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @lakchote, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[lakchote]

Thanks @narefyev91 for your review.

@ikevin127's proposal LGTM 👍

[melvin-bot]

📣 @ikevin127 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[ikevin127]

@narefyev91 PR ready for review #33225 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.15-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Desktop - Chat - Infinite loading displayed on selected chat when navigate to RHP with deeplink #33225

If no regressions arise, payment will be issued on 2023-12-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @narefyev91 does not require payment (Contractor)
• @ikevin127 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@narefyev91] The PR that introduced the bug has been identified. Link to the PR:
• [@narefyev91] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@narefyev91] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@narefyev91] Determine if we should create a regression test for this bug.
• [@narefyev91] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @laurenreidexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot]

@lakchote, @narefyev91, @Christinadobrzyn, @ikevin127 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@lakchote, @narefyev91, @Christinadobrzyn, @ikevin127 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[Christinadobrzyn]

Payouts due:

Issue Reporter: NA
Contributor: NA- paid as external contributor through Callstack
Contributor+: $500 @ikevin127 (paid through Upwork)

Eligible for 50% #urgency bonus? N

Upwork job is here.

@narefyev91 can you let us know about a regression test?

[narefyev91]

• The PR that introduced the bug has been identified. Link to the PR - it was not a regression - just missing functionality
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment - N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion - N/A
• Determine if we should create a regression test for this bug - N/A

[Christinadobrzyn]

sounds good! I think we can close this!