-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PAID] [$500] Distance- Expense preview does not show the updated currency when distance currency is changed #34066
Comments
Job added to Upwork: https://www.upwork.com/jobs/~01f1b7774b1ba5d7d3 |
Triggered auto assignment to @strepanier03 ( |
Bug0 Triage Checklist (Main S/O)
|
Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.The currency for distance request preview doesn't update when we update the currency. What is the root cause of that problem?This only happens with distance request preview. If we look at the normal review, we get the currency from App/src/components/ReportActionItem/MoneyRequestPreview.js Lines 223 to 237 in f5a3c02
App/src/libs/TransactionUtils.ts Lines 287 to 293 in f5a3c02
What changes do you think we should make in order to solve the problem?Use |
Looks good, I'll work on tying this to a wave or VIP tomorrow. |
@bernhardoj's proposal LGTM, nice and simple! 🎀👀🎀 C+ reviewed |
Triggered auto assignment to @thienlnam, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
Thanks @jjcoffee, I'll add to the VIP/Wave when I get confirmation. |
📣 @jjcoffee 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
This looks like it might fit under wave-5 |
📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
PR is ready cc: @jjcoffee |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.25-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-01-24. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Regression Test Proposal
Do we agree 👍 or 👎 |
@strepanier03 Friendly bump for payment! |
Dang, another one where the automation didn't work to move this over to Daily. I'll work on this now. |
All paid up. Handling reg test and then closing. |
Thanks everyone 👋 |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.22-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Expected Result:
The distance preview will show the updated currency
Actual Result:
The distance preview does not show the updated currency
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6333495_1704486668560.20240105_054552.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: