Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS migration] Migrate ‘metrics’ catalog to Typescript (react-native-onyx) #34341

Closed
blazejkustra opened this issue Jan 11, 2024 · 15 comments
Assignees
Labels
Monthly KSv2 NewFeature Something to build that is a new item. Reviewing Has a PR in review Typescript Migration

Comments

@blazejkustra
Copy link
Contributor

Typescript migration (react-native-onyx)

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

lib/metrics
lib/MDTable.js

@blazejkustra blazejkustra added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Jan 11, 2024
Copy link

melvin-bot bot commented Jan 11, 2024

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@mountiny mountiny removed the Bug Something is broken. Auto assigns a BugZero manager. label Jan 11, 2024
@mountiny
Copy link
Contributor

Will be handled by agencies

@allgandalf
Copy link
Contributor

Hello, I'm interested in contributing to this issue, can I help in migrating it to typescript? @blazejkustra @mountiny :)

@melvin-bot melvin-bot bot added the Overdue label Jan 16, 2024
@blazejkustra
Copy link
Contributor Author

@RohanSasne This migration will be handled by agencies meaning Callstack or SWM, sorry!

@allgandalf
Copy link
Contributor

I see, no problem:) thanks for the info

Copy link

melvin-bot bot commented Jan 16, 2024

Eep! 4 days overdue now. Issues have feelings too...

Copy link

melvin-bot bot commented Jan 18, 2024

6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@blazejkustra
Copy link
Contributor Author

Let's make it weekly @mountiny (same here & here)

@mountiny mountiny added Weekly KSv2 and removed Daily KSv2 labels Jan 18, 2024
@melvin-bot melvin-bot bot removed the Overdue label Jan 18, 2024
@BartoszGrajdek
Copy link
Contributor

Hey! I'm Bartosz from Software Mansion and I would like to work on this task.

@melvin-bot melvin-bot bot added Overdue Monthly KSv2 and removed Weekly KSv2 labels Feb 11, 2024
Copy link

melvin-bot bot commented Feb 12, 2024

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot removed the Overdue label Feb 12, 2024
@mountiny mountiny added Typescript Migration Weekly KSv2 Monthly KSv2 NewFeature Something to build that is a new item. and removed Monthly KSv2 Weekly KSv2 labels Feb 14, 2024
Copy link

melvin-bot bot commented Feb 14, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Monthly KSv2 labels Feb 14, 2024
@adelekennedy adelekennedy added Monthly KSv2 and removed Weekly KSv2 labels Feb 20, 2024
@adelekennedy
Copy link

I think we're still paused on these from the last bz post

@BartoszGrajdek
Copy link
Contributor

Could you fill me in? What was the last bz post about? 😄 @adelekennedy

@hayata-suenaga
Copy link
Contributor

@adelekennedy are you referring to the merge freeze for the earnings call?

@hayata-suenaga
Copy link
Contributor

@BartoszGrajdek I think Adele was referring to the merge freeze that was in effect last week. We can move forward to the PR now that the freeze is over 👍

@pecanoro pecanoro self-assigned this Mar 1, 2024
@pecanoro pecanoro added the Reviewing Has a PR in review label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Monthly KSv2 NewFeature Something to build that is a new item. Reviewing Has a PR in review Typescript Migration
Projects
Development

No branches or pull requests

8 participants