Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS migration] Migrate Onyx.js to Typescript (react-native-onyx) #34344

Closed
blazejkustra opened this issue Jan 11, 2024 · 15 comments
Closed

[TS migration] Migrate Onyx.js to Typescript (react-native-onyx) #34344

blazejkustra opened this issue Jan 11, 2024 · 15 comments

Comments

@blazejkustra
Copy link
Contributor

Typescript migration (react-native-onyx)

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

lib/Onyx.js
lib/index.js

@blazejkustra blazejkustra added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Jan 11, 2024
Copy link

melvin-bot bot commented Jan 11, 2024

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@mountiny mountiny removed the Bug Something is broken. Auto assigns a BugZero manager. label Jan 11, 2024
@mountiny
Copy link
Contributor

Will be handled by agencies

@melvin-bot melvin-bot bot added the Overdue label Jan 13, 2024
Copy link

melvin-bot bot commented Jan 16, 2024

Huh... This is 4 days overdue. Who can take care of this?

@ghost
Copy link

ghost commented Jan 16, 2024

I have no TS migration issues assigned. Can I take it?

@fabioh8010
Copy link
Contributor

This issue is internal @AnshuAgarwal24

Copy link

melvin-bot bot commented Jan 18, 2024

6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@ghost
Copy link

ghost commented Jan 18, 2024

Okay thanks for informing @fabioh8010

@mountiny mountiny added Weekly KSv2 and removed Daily KSv2 labels Jan 18, 2024
@melvin-bot melvin-bot bot removed the Overdue label Jan 18, 2024
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Feb 12, 2024
Copy link

melvin-bot bot commented Feb 12, 2024

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@fabioh8010
Copy link
Contributor

We still have to migrate other files before starting this one

@blazejkustra
Copy link
Contributor Author

Hey! I’m Błażej Kustra from Software Mansion, an expert agency, and I'm brave enough to work on this issue!

@melvin-bot melvin-bot bot added the Overdue label Feb 26, 2024
@paultsimura
Copy link
Contributor

We may want to hold this for #37560 – it should add some changes to Onyx.js

@blazejkustra
Copy link
Contributor Author

blazejkustra commented Mar 4, 2024

Don't you worry I still have plenty of errors on my draft PR 🙈

@melvin-bot melvin-bot bot added the Monthly KSv2 label Mar 8, 2024
Copy link

melvin-bot bot commented Mar 8, 2024

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot removed the Overdue label Mar 8, 2024
@blazejkustra
Copy link
Contributor Author

Update: I discussed with Rory that it would be best to split this PR into multiple - I'm working on this

@blazejkustra
Copy link
Contributor Author

Update: A lot of PRs were merged, I'm preparing the last one to migrate remaining (private) methods from Onyx.js file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

5 participants