-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-01-31] [$500] LHN - Multiline text displayed after a second in the LHN when deleting the last message #34352
Comments
Job added to Upwork: https://www.upwork.com/jobs/~018098a3151fcad32f |
Triggered auto assignment to @trjExpensify ( |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Multiline text displayed after a second in the LHN when deleting the last message What is the root cause of that problem?When we delete a comment, last message text in optimistic data is updated wrong here. it get the first line
App/src/libs/ReportActionsUtils.ts Line 475 in 5901e1c
What changes do you think we should make in order to solve the problem?We should use the same way in Line 1237 in 5901e1c
App/src/libs/ReportActionsUtils.ts Line 475 in 5901e1c
What alternative solutions did you explore? (Optional)NA |
@dukenv0307's proposal looks good to me! 🎀 👀 🎀 C+ reviewed |
Triggered auto assignment to @AndrewGable, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
Over to you @AndrewGable for a secondary review! |
📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
@thesahindia The PR is ready for review. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.30-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-01-31. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
👋 checklist time, @thesahindia! |
Bump, @thesahindia! |
It looks like this was present from a long time. I couldn't find the PR that introduced it. Here are the steps if we wanna add a regression test case -
|
Payment summary as follows:
|
On the regression test we have this:
I've created an issue for Applause to discuss updating it. |
@dukenv0307 - paid Closing! |
$500 approved for @thesahindia |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.21-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Issue found when executing PR #19539
Action Performed:
Expected Result:
There should not be a delay in displaying the multiline text in LHN
Actual Result:
Multiline text displayed after a second in the LHN when deleting the last message
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6338883_1704980635224.2024-01-11_18-30-19.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: