[HOLD for payment 2024-01-30] [$500] IOU-Receipt missing data remains on employee workspace chat when admin pay expense

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.24-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Start the request money flow > "Scan" receipt
2. Upload a blurry receipt
3. Complete the money request flow
4. While the receipt is scanning - navigate to the request conversation
5. Manually edit the amount field
6. Verify the merchant field shows a error to "Enter a merchant"
7. As the admin - Mark the expense as paid
8. Navigate back to Employee account

Expected Result:

Receipt missing data should not be present

Actual Result:

Receipt missing data remains on employee workspace chat when admin pay expense

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6339913_1705051426576.az_recorder_20240111_215954.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019b87b4141331b3a5
• Upwork Job ID: 1745752013862113280
• Last Price Increase: 2024-01-12
• Automatic offers:
• bernhardoj | Contributor | 28102841

Issue Owner

Current Issue Owner: @garrettmknight

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019b87b4141331b3a5

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The Receipt missing data still shows after the request is paid.

What is the root cause of that problem?

The Receipt missing data will be shown when there is a missing required field of the request regardless of the settled status.

App/src/components/ReportActionItem/MoneyRequestPreview.js

Lines 232 to 235 in b6a18b1

	if (TransactionUtils.hasMissingSmartscanFields(props.transaction)) {
	return Localize.translateLocal('iou.receiptMissingDetails');
	}

What changes do you think we should make in order to solve the problem?

Add && !isSettled so it will show the amount if the request is paid/settled.

or just do nothing

[garrettmknight]

@thesahindia can you take a look at this proposal? Looks pretty straightforward.

[melvin-bot]

@garrettmknight, @thesahindia Whoops! This issue is 2 days overdue. Let's get this updated quick!

[thesahindia]

@bernhardoj's proposal looks good to me!

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @bondydaa, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[bernhardoj]

PR is ready

cc: @thesahindia

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.29-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix receipt missing details still shown after the request is paid #34557

If no regressions arise, payment will be issued on 2024-01-30. 🎊

For reference, here are some details about the assignees on this issue:

• @bernhardoj requires payment automatic offer (Contributor)
• @thesahindia requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@thesahindia] The PR that introduced the bug has been identified. Link to the PR:
• [@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@thesahindia] Determine if we should create a regression test for this bug.
• [@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

@garrettmknight, @bondydaa, @bernhardoj, @thesahindia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@garrettmknight, @bondydaa, @bernhardoj, @thesahindia 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[garrettmknight]

Payment Summary:

• Contributor: @bernhardoj $500 paid via Upwork
• Reviewer: @thesahindia $500

[garrettmknight]

Dropping to weekly to finish the checklist and request payment

[thesahindia]

Steps for test case -

1. Open your own policy expense chat
2. Create a new scan request
3. Open the request detail thread and set any amount
4. Go back to the expense report
5. Verify the request preview shows "Receipt missing details"
6. Pay the request
7. Verify the request preview changes to the request amount

[garrettmknight]

Test case added - @thesahindia request payment when you're ready.

[thesahindia]

Yeah I will send the request soon. You can close this.

[JmillsExpensify]

$500 approved for @thesahindia