[HOLD for payment 2024-02-14] Scan- Invalid file is downloaded when uploading invalid file and downloading from receipt view

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.34-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #34087

Action Performed:

1. Create a money request with receipt
2. Navigate to request details page
3. Click on the receipt > 3-dot menu > Replace
4. Upload a corrupted file
5. Click on the receipt preview > 3-dot menu > Download
6. Open the downloaded file

Expected Result:

The downloaded file will be the corrupted file

Actual Result:

The download receipt name belongs to the previous receipt (png format), but the downloaded file itself is invalid

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6362441_1706713172959.20240131_203208.mp4

Bug6362441_1706713172960!CORRUPT.pdf

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @luacmartins (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

We think that this bug might be related to #wave5.
CC @dylanexpensify

[luacmartins]

Looking at this now

[francoisl]

@luacmartins any luck with this one?

[luacmartins]

Demoting to NAB. Gonna leave a comment in the original PR so the contributor can look into it.

[luacmartins]

@tienifr could you look into this one? seems like a regression from #34087

[tienifr]

I'm doing

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.37-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Invalid file is downloaded when uploading invalid file and downloading from receipt view #35536

If no regressions arise, payment will be issued on 2024-02-14. 🎊

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[melvin-bot]

@luacmartins Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[luacmartins]

No payment needed here, this was a regression.