Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2024-01-31 #35448

Closed
54 tasks done
github-actions bot opened this issue Jan 31, 2024 · 9 comments
Closed
54 tasks done

Deploy Checklist: New Expensify 2024-01-31 #35448

github-actions bot opened this issue Jan 31, 2024 · 9 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2024

Release Version: 1.4.34-1
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@kavimuru kavimuru added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Jan 31, 2024
@OSBotify
Copy link
Contributor

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.34-0 🚀

@francoisl francoisl self-assigned this Jan 31, 2024
@francoisl
Copy link
Contributor

#34212 was reverted with #35447 before the deploy so I'm checking both off

@kbecciv
Copy link

kbecciv commented Jan 31, 2024

The TR is 50% completed!

#34087 is failing #34043 (comment) in Android app, repro in Prod, checking off
#34599 is failing #34414 - with original issue
#35097 - pending validation #35097 (comment)

Deploy Blockers:
#34043
#35468
#35475
#35477
#35479
#35481
#35482
#35487

@amyevans
Copy link
Contributor

Demoting #35477

@francoisl
Copy link
Contributor

francoisl commented Jan 31, 2024

#35487: Demoting
#34043: closing, context
#35475: backend bug
#35481: demoting and closing - similar known issue with a fix in review
#35519: happening on prod too :(
#34599: left a note in the PR to double-check if it fixes the parent issue, checking off

@dangrous
Copy link
Contributor

dangrous commented Jan 31, 2024

Demoting #35468

EDIT: Meant Demoting #35479

@blimpich
Copy link
Contributor

Demoting #35515

@luacmartins
Copy link
Contributor

luacmartins commented Jan 31, 2024

Checking off #35482. Demoted to NAB

@francoisl
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

9 participants