[HOLD for payment 2024-03-22] [$500] [Simplified Collect][Categories] CategorySettingsPage: rename category, delete category, onyx actions

[luacmartins]

Implement CategorySettingsPage: rename category, delete category, onyx actions from the CategorySettingsPage: page init, enable/disable categories, display name, onyx action for enabling/disabling category

Issue Owner

Current Issue Owner: @ArekChr

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019c879178a6d4badc
• Upwork Job ID: 1755658765113217024
• Last Price Increase: 2024-02-08

[melvin-bot]

Triggered auto assignment to @slafortune (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[luacmartins]

@ArekChr can you please comment here so I can assign you to the issue?

[ArekChr]

Sure, please assign me @luacmartins

[melvin-bot]

@slafortune, @luacmartins, @ArekChr Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019c879178a6d4badc

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

[jeremy-croff]

Hi I'm trying to review this issue but do not have access to the document in the OP.
@luacmartins

[melvin-bot]

@akinwale, @slafortune, @luacmartins, @ArekChr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[ArekChr]

Hey, the main category settings page is currently under review, which is needed for this feature. It will soon be merged, and then I'll create a draft PR

[slafortune]

Great! Thanks for the details!

[ArekChr]

Hey there, soon I will create draft PR

[luacmartins]

@ArekChr do you have a draft PR to link to this issue yet?

[ArekChr]

@luacmartins Linked draft PR

[luacmartins]

Thank you!

[ArekChr]

PR ready for review

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.52-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Feat/categories bulk actions #37734

If no regressions arise, payment will be issued on 2024-03-22. 🎊

For reference, here are some details about the assignees on this issue:

• @akinwale requires payment (Needs manual offer from BZ)
• @ArekChr does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@akinwale] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[slafortune]

@akinwale can you propose regression test steps to ensure the new feature will work correctly on production in further releases so I can get this paid today?

[akinwale]

• [@akinwale] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.

Regression Test Steps

• Launch Expensify
• Log in as an the admin of a paid policy (Collect or Control) and navigate to the Workspace Settings > Select a workspace > Categories.
• Choose some categories that are currently disabled.
• Click the options menu in the top right corner and select "Enable Categories".
• Verify that the selected categories are now enabled.
• Choose some categories that are currently enabled.
• Click the options menu in the top right corner again and select "Disable Categories".
• Verify that these categories are now disabled.
• Choose any categories you wish to delete.
• In the top right corner, click the options menu and choose "Delete Categories".
• Verify that the selected categories were removed.

Do we agree 👍 or 👎?

[akinwale]

@slafortune Done!

[slafortune]

Offer sent @akinwale https://www.upwork.com/nx/wm/offer/101522153

[akinwale]

Offer sent @akinwale https://www.upwork.com/nx/wm/offer/101522153

Accepted. Thanks!

[slafortune]

@akinwale - Paid $500 via Upworks
@ArekChr does not require payment (Contractor)