-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-03-22] [$500] [Simplified Collect][Categories] CategorySettingsPage: rename category, delete category, onyx actions #35709
Comments
Triggered auto assignment to @slafortune ( |
@ArekChr can you please comment here so I can assign you to the issue? |
Sure, please assign me @luacmartins |
@slafortune, @luacmartins, @ArekChr Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Job added to Upwork: https://www.upwork.com/jobs/~019c879178a6d4badc |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale ( |
Hi I'm trying to review this issue but do not have access to the document in the OP. |
@akinwale, @slafortune, @luacmartins, @ArekChr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Hey, the main category settings page is currently under review, which is needed for this feature. It will soon be merged, and then I'll create a draft PR |
Great! Thanks for the details! |
Hey there, soon I will create draft PR |
@ArekChr do you have a draft PR to link to this issue yet? |
@luacmartins Linked draft PR |
Thank you! |
PR ready for review |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.52-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-03-22. 🎊 For reference, here are some details about the assignees on this issue: |
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
@akinwale can you propose regression test steps to ensure the new feature will work correctly on production in further releases so I can get this paid today? |
Regression Test Steps
Do we agree 👍 or 👎? |
@slafortune Done! |
Accepted. Thanks! |
Implement
CategorySettingsPage: rename category, delete category, onyx actions
from the CategorySettingsPage: page init, enable/disable categories, display name, onyx action for enabling/disabling categoryIssue Owner
Current Issue Owner: @ArekChrUpwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: