[HOLD for payment 2024-04-05] [$250] [Categories] - Category row is not grayed out entirely when disabled offline

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.52-0
Reproducible in staging?: y
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

Precondition:

• User is an admin of Collect workspace.

1. Go to staging.new.expensify.com.
2. Go to Settings > Workspaces > Collect workspace.
3. Go to Categories.
4. Go offline.
5. Click on the checkbox of any category.
6. Click dropdown menu > Disable categories (or Enable if disabled).

Expected Result:

The entire category row will appear grayed out.

Actual Result:

Only the status column is grayed out.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6412862_1710369793014.bandicam_2024-03-14_04-34-17-866.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013df311dce09e48bb
• Upwork Job ID: 1768698540734349312
• Last Price Increase: 2024-03-15
• Automatic offers:
• cubuspl42 | Reviewer | 0
• Krishna2323 | Contributor | 0

Issue Owner

Current Issue Owner: @puneetlath

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Current assignee @puneetlath is eligible for the Engineering assigner, not assigning anyone new.

[akinwale]

I believe this behaviour is intentional since it's the state value (enabled / disabled) that's changing. @ArekChr can confirm.

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Categories - Category row is not grayed out entirely when disabled offline

What is the root cause of that problem?

Offending PR: #37734

We set pendingFields instead of pendingAction when enabling/disabling category

App/src/libs/actions/Policy.ts

Lines 2655 to 2657 in 13f8bc0

	pendingFields: {
	enabled: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
	},

What changes do you think we should make in order to solve the problem?

Instead of adding pendingFields we should add pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE when updating the category, just like we do when creating a category. Or just add pendingAction without removing pendingFields.

Result

enabled.disable_category_pendingAction.mp4

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Only the status column is grayed out.

What is the root cause of that problem?

When we disable the category, we update pendingFields of category and I think it's expected that we update the pendingField like this

App/src/libs/actions/Policy.ts

Lines 2654 to 2656 in b7a230e

	errors: null,
	pendingFields: {
	enabled: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,

but we don't get this as pendingAction here so the category row isn't grayed out

App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx

Line 84 in b7a230e

pendingAction: value.pendingAction,

What changes do you think we should make in order to solve the problem?

We should update the pendingAction here by fallback value.pendingFields.enable

pendingAction: value.pendingAction || value?.pendingFields?.enabled,

App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx

Line 84 in b7a230e

pendingAction: value.pendingAction,

OPTIONAL: In the feature we can have other pendingFields like name, ... We can create a utils like getCategoryPendingAction and use it in all places that we want to get the pendingAction of category. We can do the same for tag or other policy features

What alternative solutions did you explore? (Optional)

NA

[ikevin127]

ArekChr can confirm.

Offending PR #37734 - which is still within the regression period (deployed to staging 17h ago, see #37734 (comment)).

[mountiny]

This is not a blocker, new feature we work on in Simplified Collect, taking the issue on.

We are discussing the pending fields/ error handling on this table component

[luacmartins]

@mountiny do you have a link to the discussion?

[mountiny]

Sorry it was this one https://expensify.slack.com/archives/C036QM0SLJK/p1710425480916719 seems like this is already se up so we can proceed with implementation

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013df311dce09e48bb

[Krishna2323]

You mean deselecting all tags is expected behaviour like we do with categories, right?

App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx

Lines 141 to 144 in 065e52f

	const navigateToCategorySettings = (category: PolicyOption) => {
	setSelectedCategories({});
	Navigation.navigate(ROUTES.WORKSPACE_CATEGORY_SETTINGS.getRoute(route.params.policyID, category.keyForList));
	};

App/src/pages/workspace/tags/WorkspaceTagsPage.tsx

Lines 130 to 132 in 065e52f

	const navigateToTagSettings = (tag: PolicyOption) => {
	Navigation.navigate(ROUTES.WORKSPACE_TAG_SETTINGS.getRoute(route.params.policyID, tag.keyForList));
	};

[mountiny]

@Krishna2323 yes, tags should follow what categories do now

When you open RHP, all tags/ categories should de deselected.

[mountiny]

I found that when we update category in offline mode the row is disabled, do we need to do that for tags also? Haven't added recordings since we might want to fix this as well.

regarding this, we are still discussing internally, its not in scope of this PR

@Krishna2323 could you however align the tags behaviour with categories in your PR please? Thank you

[Krishna2323]

Will fix that also, thanks.

[trjExpensify]

Where we at with this? What's the ETA on the PR? Thanks!

[cubuspl42]

@trjExpensify

In review. ETA today/tomorrow. Do you know whether the category UI element should be completely disabled when grayed out? I.e. should I be able to click/tap it to display the details, or maybe change the category name?

[luacmartins]

I think users should be able to interact with it and update other values, unless the row is in a pending delete state, in which case it should be disabled

[trjExpensify]

Agree with what Carlos said!

[Krishna2323]

@luacmartins, are you sure we don't need to disabled the tags/categories when updated offline, I guess it was intentionally added in this #37734.

BTW we aren't making any changes related to disabling the tag/categories in this PR, the disabling only happens with categories which was added in the PR linked above. But still if we need to change that we can handle that in #38663

[cubuspl42]

I raised this topic, because it felt odd; in most cases, we can edit the thing that has pending offline actions. But we didn't change anything in this aspect in our PR, so maybe let's consider this out of scope?

[trjExpensify]

@luacmartins, are you sure we don't need to disabled the tags/categories when updated offline,

Are you specifically asking in the pending create state or the pending delete case? Because they are handled differently.

If you add a category offline, you can edit its settings as well. Generally the philosophy here is that we should let people "work" offline as much as possible. So blocking them from being able to edit the category they just added goes against that. It would be somewhat pointless to allow you to add categories when offline if we didn't.

If you delete a category offline, you can't edit its settings. It's treated as if you deleted it when online, the only difference is that it's still displayed as a breadcrumb while its pending to confirm the action was successful.

[luacmartins]

Agree with Tom. So the only instance in which we should disable the row is when it's pending to be deleted. Adding or updating any field should not block the user from interacting with it again.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Categories & Tags - Row is not grayed out entirely when disabled offline. #38443

If no regressions arise, payment will be issued on 2024-04-05. 🎊

For reference, here are some details about the assignees on this issue:

• @cubuspl42 requires payment automatic offer (Reviewer)
• @Krishna2323 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@cubuspl42] The PR that introduced the bug has been identified. Link to the PR:
• [@cubuspl42] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@cubuspl42] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@cubuspl42] Determine if we should create a regression test for this bug.
• [@cubuspl42] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mountiny]

$250 to @Krishna2323 and $250 to @cubuspl42

[mountiny]

Puneet has been originally assigned using the bug label so adding you to handle payments here, thank you!

[puneetlath]

@cubuspl42 friendly reminder on the checklist so that we can pay tomorrow.

[cubuspl42]

• The PR that introduced the bug has been identified. Link to the PR:
  • Feat/categories bulk actions #37734
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • Feat/categories bulk actions #37734 (comment)
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • No need for additional discussion
• Determine if we should create a regression test for this bug.
  • No
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • N/A

[puneetlath]

All paid. Thanks everyone!