[$500] Hold request - App crashes when saving a reason during hold request flow

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.43-0
Reproducible in staging?: y
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applasue internal team
Slack conversation:

Action Performed:

1. Launch New Expensify app.
2. Create a manual request from any user.
3. Go to request details page.
4. Click 3-dot menu > Hold request.
5. Add a reason and save it.

Expected Result:

App does not crash.

Actual Result:

App crashes.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6385223_1708394496532.Screen_Recording_20240220_081809_New_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0126f2cd8c5ade674d
• Upwork Job ID: 1759794310203371520
• Last Price Increase: 2024-02-20
• Automatic offers:
• shubham1206agra | Reviewer | 0
• mkhutornyi | Contributor | 0

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0126f2cd8c5ade674d

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @techievivek (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[mkhutornyi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Hold request - App crashes when saving a reason during hold request flow on native apps

What is the root cause of that problem?

App/src/components/ProcessMoneyRequestHoldMenu.tsx

Line 48 in 0797c0a

<TextPill textStyles={styles.holdRequestInline}>{translate('iou.hold')}</TextPill>;

; is at the end of TextPill render

What changes do you think we should make in order to solve the problem?

remove ;

[shubham1206agra]

Offending PR #32667

Since this was marked external, @mkhutornyi's proposal looks good.

🎀 👀 🎀 C+ Reviewed

[melvin-bot]

Current assignee @techievivek is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[shubham1206agra]

@mkhutornyi Please raise PR urgently as this is a deploy blocker.

[mkhutornyi]

Sure, waiting for assignment

[melvin-bot]

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[techievivek]

@mkhutornyi Assigned, can you please push the PR ASAP, thanks.

[melvin-bot]

📣 @mkhutornyi 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[joekaufmanexpensify]

PR is out to production as of 2 weeks ago. Automation didn't work. All set to issue payment. we need to pay:

• @mkhutornyi $500 for PR, paid via Upwork.
• @shubham1206agra $500 for C+, paid via Upwork.

[joekaufmanexpensify]

@mkhutornyi $500 sent and contract ended!

[joekaufmanexpensify]

@shubham1206agra please accept our offer so we can pay you

[shubham1206agra]

@joekaufmanexpensify Can you hold my payment temporarily as per https://expensify.slack.com/archives/C02NK2DQWUX/p1710150138788529?

[joekaufmanexpensify]

Got it. Sure!

[joekaufmanexpensify]

@shubham1206agra is payment here still held?

[shubham1206agra]

@joekaufmanexpensify Yes

Sorry for the inconvenience.

[joekaufmanexpensify]

All good! Is there an ETA for resolution?

[joekaufmanexpensify]

Discussing further here.

[shubham1206agra]

@joekaufmanexpensify I have discussed this internally. You may close this issue as I am keeping track of payment internally and will ask to pay once the issue is resolved. Just write in the payment summary that I have not been paid yet.

[joekaufmanexpensify]

Sounds good. TY! LMK when your Upwork situation is all set, and I'll re-open this and pay you.

[shubham1206agra]

@joekaufmanexpensify You can process payment here now.

[shubham1206agra]

@joekaufmanexpensify Bump here.

[joekaufmanexpensify]

Awesome. TY!

[joekaufmanexpensify]

OG upwork job is closed, so opened new one: https://www.upwork.com/jobs/~01456ff2950adec042

[joekaufmanexpensify]

@shubham1206agra offer sent for $500!

[shubham1206agra]

@joekaufmanexpensify Accepted

[joekaufmanexpensify]

@shubham1206agra $500 sent and contract ended!

[joekaufmanexpensify]

Upwork job closed.

[joekaufmanexpensify]

All set.