[$500] Distance - App crashes when creating a distance request after creating a new workspace

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Found when validating PR: #36147

Version Number: v1.4.43-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation:

Action Performed:

1. Navigate to staging.new.expensify.com
2. Create a new workspace.
3. Go to workspace chat.
4. Click + > Request money > Distance.
5. Enter addresses.
6. Proceed to confirmation page.
   (Step 2-6 must be done quickly.)

Expected Result:

App does not crash.

Actual Result:

App crashes.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6385297_1708401830321.bandicam_2024-02-20_09-31-11-883.mp4

Bug6385297_1708401830330!staging.new.expensify.com-1708401721990.txt

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e5db64f304cac8ab
• Upwork Job ID: 1759883217035563008
• Last Price Increase: 2024-02-20
• Automatic offers:
• c3024 | Reviewer | 0
• situchan | Contributor | 0

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e5db64f304cac8ab

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @cristipaval (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[izarutskaya]

We think that this bug might be related to #wave5-free-submitters
CC @dylanexpensify

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes.

What is the root cause of that problem?

policyCategories can be null in

App/src/pages/iou/request/step/IOURequestStepConfirmation.js

Line 135 in 0f372c2

if (policyCategories[transaction.category] && !policyCategories[transaction.category].enabled) {

What changes do you think we should make in order to solve the problem?

We need add null check for policyCategories in

App/src/pages/iou/request/step/IOURequestStepConfirmation.js

Line 135 in 0f372c2

if (policyCategories[transaction.category] && !policyCategories[transaction.category].enabled) {

        if (policyCategories && policyCategories[transaction.category] && !policyCategories[transaction.category].enabled) 

or we can define the default for policyCategories

What alternative solutions did you explore? (Optional)

NA

[ZhenjaHorbach]

Already known issue
#35540 (comment)
And regression related with this PR
#35540

[dukenv0307]

This issue is a regression related to my PR 35540 so I will create a follow-up PR to fix this issue.

[melvin-bot]

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @c3024 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @c3024 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[CortneyOfstad]

PR here and looks as though it was cherry-picked for Staging 5 hours ago 👍

[cristipaval]

@CortneyOfstad, FYI: @situchan is the only contributor to pay here. The C+ is the one who reviewed the original PR that introduced the regression (Thanks, @c3024, for quickly jumping into this! 🙏 )

[tienifr]

@CortneyOfstad @cristipaval Should we have a payment here since we used my proposal to fix this blocker?

Similar case: https://expensify.slack.com/archives/C01GTK53T8Q/p1707782382926619?thread_ts=1707781846.347169&cid=C01GTK53T8Q

[situchan]

@tienifr #35540 (comment) was posted before this issue created and your proposal is posted. And simple enough so not worth considering efforts made to request compensation.
(Just my opinion)

[CortneyOfstad]

I agree with @situchan. @cristipaval do you have any thoughts on whether payment is needed based on the comment here?

[cristipaval]

I get what @tienifr is saying, and that there were similar cases when other proposals were compensated if they were guiding the developer in fixing it, but given that the discussion about the fix for this issue happened a few days before this issue was created, I think @situchan is the only eligible for the payment here.

[CortneyOfstad]

Thanks @cristipaval!

Payment Summary

@situchan — paid $500 via Upwork