-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-03-22] Сhat - On selecting skin tone emoji symbol disappears #38049
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Triggered auto assignment to @rlinoz ( |
@rlinoz FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
We think that this bug might be related to #vip-vsp |
ProposalPlease re-state the problem that we are trying to solve in this issue.Сhat - On selecting skin tone emoji symbol disappears What is the root cause of that problem?We have a logic at this line return undefined if the skin tone index is 0 What changes do you think we should make in order to solve the problem?Instead of check - if (!preferredSkinToneIndex) {
+ if (preferredSkinToneIndex === undefined || preferredSkinToneIndex === null) {
return;
} POC Screen.Recording.2024-03-11.at.22.12.31.movWhat alternative solutions did you explore? (Optional)Simple condition const getEmojiCodeWithSkinColor = (item: Emoji, preferredSkinToneIndex: OnyxEntry<string | number>): string | undefined => {
const {code, types} = item;
if (typeof preferredSkinToneIndex !== 'number') {
return;
}
if (types?.[preferredSkinToneIndex]) {
return types[preferredSkinToneIndex];
}
return code;
}; Solution 2 - if (!preferredSkinToneIndex) {
- return;
- }
+ if (typeof preferredSkinToneIndex === 'number' && types?.[preferredSkinToneIndex]) {
return types[preferredSkinToneIndex];
} |
ProposalPlease re-state the problem that we are trying to solve in this issue.Сhat - On selecting skin tone emoji symbol disappears What is the root cause of that problem?We return from Line 245 in 3d4504e
What changes do you think we should make in order to solve the problem?Instead of ResultAlternativelyCreate a else statement here and return. Lines 251 to 253 in 3d4504e
Alternative 2Change the condition to: if (typeof preferredSkinToneIndex !== 'number' || !types?.[preferredSkinToneIndex]) {
return;
} |
@suneox, you updated your proposal after mine, pls comment |
@Krishna2323 you also updated the proposal so I think you also commented |
For deploy blockers, offending PR should be pointed out in root cause |
Offending PR: #34487 |
PR #34487 |
Added alternative 2 |
Looks like @suneox proposed first with the correct root cause. |
I also update my proposal alternative 2, the reason change on the PR is preferredSkinToneIndex include null value so the author of PR check |
I'm removing the deploy blocker label as this is not a crucial path and sending emojis still works. |
As @aimane-chnaif pointed out this should be handled by @kubabutkiewicz if possible. |
I will take a look on this today @rlinoz |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.52-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-03-22. 🎊 |
No payment due, closing. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.50
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4417529
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
Emoji symbol must not disappear in suggestion list
Actual Result:
Emoji symbol disappears in suggestion list
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6409714_1710167224561.skin.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: