[HOLD for payment 2024-04-05] [$250] Chats - Expensify / Chats is not aligned on the same line

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.52-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #37421

Action Performed:

1. Go to staging.new.expensify.com
2. Make sure the workspace filter is Expensify

Expected Result:

Expensify / Chats is aligned on the same line

Actual Result:

Expensify / Chats is not aligned on the same line

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c8acccc3eea77881
• Upwork Job ID: 1768272521223192576
• Last Price Increase: 2024-03-14
• Automatic offers:
• cubuspl42 | Reviewer | 0

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @amyevans (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

We think that this bug might be related to #vip-vsp
CC @quinthar

[lanitochka17]

@amyevans FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[mkhutornyi]

This is not blocker. Production doesn't have env badge.
Though I am curious why this was reported so late as happenning on dev/staging for a while.

Aka. prodution breadcrumbs are also misaligned

[MahmudjonToraqulov]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chats - Expensify / Chats is not aligned on the same line.

What is the root cause of that problem?

Offending PR:32221

This style is causing the issue.

App/src/components/Breadcrumbs.tsx

Line 43 in 0a512c9

<View style={styles.breadcrumbLogo}>

What changes do you think we should make in order to solve the problem?

Remove style={styles.breadcrumbLogo} here:

App/src/components/Breadcrumbs.tsx

Line 43 in 0a512c9

<View style={styles.breadcrumbLogo}>

What alternative solutions did you explore? (Optional)

Add styles.alignItemsCenter here:

App/src/components/Header.tsx

Line 26 in 206d293

<View style={[styles.flex1, styles.flexRow]}>

Result

With Environment Badge:

Without Environment Badge:

[mountiny]

I think this might have started after the update to breadcrumbs scaling #36655 cc @dukenv0307

@Expensify/design

[shawnborton]

Hmm that is definitely possible, and if so, let's treat it like a regression and have @dukenv0307 follow up with a fix.

[dukenv0307]

@mountiny I just tested locally by reverting my PR and the result is the same. Correct me if I missed st.

[mountiny]

I think we can make it external then for $250

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c8acccc3eea77881

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

[melvin-bot]

Upwork job price has been updated to $250

[mountiny]

for whatever proposal @MahmudjonToraqulov Could you please identify what PR caused this regression, I agree this cannot be more than couple releases old

[ghost]

@mountiny @shawnborton @cubuspl42 Is this what you need ? Please let me know if that is the case then I will put down a proposal and also offending PR asap

[MahmudjonToraqulov]

UPDATED with offending PR

[cubuspl42]

@godofoutcasts94

I keep forgetting about it. Sorry.

style={styles.breadcrumbLogo}

From my perspective, it has the same qualities as the first proposal, i.e. it looses the "pixel-perfect alignment". Also, it's last in the submitting order, so it would have to be measurably better than the one by @aneequeahmad to be selected.

But you're right that it should be included in the commentary.

[cubuspl42]

@MahmudjonToraqulov

What about my alternative solution?

I don't interpret the "What alternative solutions did you explore?" section like some other people do. For me, it's an optional section that's best suited for describing rejected solutions.

If you actually want to suggest two different solutions, which you both fully tested and are ready to sign under both, I think you should describe them as "Option A" / "Option B" in the "What changes do you think we should make in order to solve the problem?" section.

In the case of a visual issue like this one, you should provide screenshots for both "Option A" and "Option B".

Since this issue is "suspected" to be platform-specific, I think that screenshots for multiple platforms should be provided. At least iOS Native, Android Native, mobile Web (on minimum one OS), desktop Web (on one browser). You can use the<details> tag like in the template.

[aneequeahmad]

@cubuspl42 here are screenshot of my proposal on different platforms.

iOS Native:

Android native:

mobile Web (Safari):

desktop Web(Mac Os/Chrome):

[cubuspl42]

It looks good, as far as I can tell!

I approve the proposal by @aneequeahmad

I base my decision on a mix of simplicity, effectiveness, and the order of submission.

Thanks, everyone!

C+ reviewed 🎀 👀 🎀

[melvin-bot]

Current assignees @puneetlath and @amyevans are eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

📣 @cubuspl42 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @aneequeahmad You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[aneequeahmad]

@cubuspl42 PR is ready for review

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix expensify/chat alignments #38891

If no regressions arise, payment will be issued on 2024-04-05. 🎊

For reference, here are some details about the assignees on this issue:

• @cubuspl42 requires payment automatic offer (Reviewer)
• @aneequeahmad requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@cubuspl42] The PR that introduced the bug has been identified. Link to the PR:
• [@cubuspl42] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@cubuspl42] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@cubuspl42] Determine if we should create a regression test for this bug.
• [@cubuspl42] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[puneetlath]

@cubuspl42 friendly reminder on the checklist so that we can pay tomorrow.

[cubuspl42]

• The PR that introduced the bug has been identified. Link to the PR:
  • [NoQA] [Wave8] Breadcrumbs #32221
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [NoQA] [Wave8] Breadcrumbs #32221 (comment)
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • No need for additional discussion
• Determine if we should create a regression test for this bug.
  • No
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • N/A

[puneetlath]

@cubuspl42 has been paid.

@aneequeahmad I sent you an offer here. Ping me on this issue when you've accepted.

[aneequeahmad]

@puneetlath I have accepted the offer. Thank you for mentioning

[aneequeahmad]

@puneetlath Friendly reminder

[puneetlath]

Everyone has been paid. Thanks y'all!